From a1c954ab7d4c6a78913d1d1b7e6ba4b0ba2634aa Mon Sep 17 00:00:00 2001 From: Jesse Andrews Date: Wed, 22 Jan 2025 20:53:20 -0500 Subject: [PATCH 1/2] wip for cleaning up commonui --- .../common-ui/examples/components.html | 1 + typescript/packages/common-ui/package.json | 13 - .../common-ui/src/components/button.ts | 7 - .../src/components/common-audio-recorder.ts | 18 +- .../common-ui/src/components/common-charm.ts | 7 - .../src/components/common-datatable.ts | 8 - .../common-ui/src/components/common-dict.ts | 5 - .../common-ui/src/components/common-form.ts | 5 - .../src/components/common-hero-layout.ts | 2 +- .../src/components/common-hscroll.ts | 6 - .../common-ui/src/components/common-hstack.ts | 8 - .../common-ui/src/components/common-iframe.ts | 8 - .../src/components/common-input-file.ts | 11 - .../common-ui/src/components/common-input.ts | 9 - .../src/components/common-navpanel.ts | 74 --- .../common-ui/src/components/common-pill.ts | 6 - .../common-ui/src/components/common-record.ts | 3 - .../src/components/common-suggestions.ts | 8 - .../common-ui/src/components/common-table.ts | 10 - .../src/components/common-textarea.ts | 10 - .../common-ui/src/components/common-todo.ts | 10 - .../common-ui/src/components/common-unibox.ts | 10 - .../common-ui/src/components/common-vstack.ts | 8 - .../packages/common-ui/src/components/div.ts | 5 - .../packages/common-ui/src/components/h1.ts | 5 - .../common-ui/src/components/include.ts | 23 - .../common-ui/src/components/index.ts | 1 - .../common-ui/src/components/input.ts | 30 - .../packages/common-ui/src/components/p.ts | 5 - .../common-ui/src/components/send-input.ts | 8 - .../src/components/shoelace/components.ts | 616 ------------------ .../packages/common-ui/src/components/span.ts | 5 - typescript/packages/common-ui/src/example.ts | 128 ---- .../common-ui/src/hyperscript/render.ts | 320 --------- .../src/hyperscript/schema-helpers.ts | 73 --- .../common-ui/src/hyperscript/tags.ts | 20 - .../common-ui/src/hyperscript/view.ts | 188 ------ typescript/packages/common-ui/src/index.ts | 9 +- .../common-ui/src/shared/deep-freeze.ts | 21 - .../common-ui/src/shared/generator.ts | 12 - typescript/packages/common-ui/test/assert.js | 16 - .../common-ui/test/hyperscript.test.js | 61 -- .../src/components/charm-link.ts | 6 - .../src/components/recipe-link.ts | 5 - .../packages/lookslike-high-level/src/data.ts | 3 + .../src/recipes/examples/shoelace.tsx | 2 +- 46 files changed, 15 insertions(+), 1794 deletions(-) delete mode 100644 typescript/packages/common-ui/src/components/button.ts delete mode 100644 typescript/packages/common-ui/src/components/common-navpanel.ts delete mode 100644 typescript/packages/common-ui/src/components/div.ts delete mode 100644 typescript/packages/common-ui/src/components/h1.ts delete mode 100644 typescript/packages/common-ui/src/components/include.ts delete mode 100644 typescript/packages/common-ui/src/components/input.ts delete mode 100644 typescript/packages/common-ui/src/components/p.ts delete mode 100644 typescript/packages/common-ui/src/components/span.ts delete mode 100644 typescript/packages/common-ui/src/example.ts delete mode 100644 typescript/packages/common-ui/src/hyperscript/render.ts delete mode 100644 typescript/packages/common-ui/src/hyperscript/schema-helpers.ts delete mode 100644 typescript/packages/common-ui/src/hyperscript/tags.ts delete mode 100644 typescript/packages/common-ui/src/hyperscript/view.ts delete mode 100644 typescript/packages/common-ui/src/shared/deep-freeze.ts delete mode 100644 typescript/packages/common-ui/src/shared/generator.ts delete mode 100644 typescript/packages/common-ui/test/assert.js delete mode 100644 typescript/packages/common-ui/test/hyperscript.test.js diff --git a/typescript/packages/common-ui/examples/components.html b/typescript/packages/common-ui/examples/components.html index d095b764f..c3172ae85 100644 --- a/typescript/packages/common-ui/examples/components.html +++ b/typescript/packages/common-ui/examples/components.html @@ -9,6 +9,7 @@

Home screen

+ diff --git a/typescript/packages/common-ui/package.json b/typescript/packages/common-ui/package.json index ef41ae3ed..9ff2f180e 100644 --- a/typescript/packages/common-ui/package.json +++ b/typescript/packages/common-ui/package.json @@ -26,18 +26,6 @@ "types": "./lib/index.d.ts", "default": "./lib/index.js" }, - "./view.js": { - "types": "./lib/hyperscript/view.d.ts", - "default": "./lib/hyperscript/view.js" - }, - "./render.js": { - "types": "./lib/hyperscript/render.d.ts", - "default": "./lib/hyperscript/render.js" - }, - "./tags.js": { - "types": "./lib/hyperscript/tags.d.ts", - "default": "./lib/hyperscript/tags.js" - }, "./components.js": { "types": "./lib/components/index.d.ts", "default": "./lib/components/index.js" @@ -66,7 +54,6 @@ "wireit": { "build": { "dependencies": [ - "../common-frp:build", "../common-system:build" ], "files": [ diff --git a/typescript/packages/common-ui/src/components/button.ts b/typescript/packages/common-ui/src/components/button.ts deleted file mode 100644 index c5b64da50..000000000 --- a/typescript/packages/common-ui/src/components/button.ts +++ /dev/null @@ -1,7 +0,0 @@ -import { view } from "../hyperscript/render.js"; -import { eventProps } from "../hyperscript/schema-helpers.js"; - -export const button = view("button", { - ...eventProps(), - id: { type: "string" }, -}); diff --git a/typescript/packages/common-ui/src/components/common-audio-recorder.ts b/typescript/packages/common-ui/src/components/common-audio-recorder.ts index 1090ad3cc..14e0141e6 100644 --- a/typescript/packages/common-ui/src/components/common-audio-recorder.ts +++ b/typescript/packages/common-ui/src/components/common-audio-recorder.ts @@ -59,10 +59,10 @@ export class CommonAudioRecorderElement extends LitElement { }); const data = await response.json(); - this.dispatchEvent(new CommonAudioRecordingEvent({ + this.dispatchEvent(new CommonAudioRecordingEvent({ id: this.id, blob: audioBlob, - transcription: data.transcription + transcription: data.transcription })); } catch (error) { console.error("Transcription error:", error); @@ -89,9 +89,9 @@ export class CommonAudioRecorderElement extends LitElement { const audioBlob = new Blob(this.audioChunks, { type: "audio/wav", }); - this.dispatchEvent(new CommonAudioRecordingEvent({ + this.dispatchEvent(new CommonAudioRecordingEvent({ id: this.id, - blob: audioBlob + blob: audioBlob })); await this.runTranscription(audioBlob); }; @@ -119,16 +119,14 @@ export class CommonAudioRecorderElement extends LitElement { override render() { return html` -