minor clean-ups

- use single quotes for strings that do not require interpolation
- whitespace clean-up
- lines <80 characters

Author: TimidRobot

addTeamspaceCCIDUser.php

@@ -23,38 +23,41 @@
 class AddCCIDUser extends Maintenance {
 
     public function __construct() {
-    	   parent::__construct();
-		$this->mDescription = "Create a new CCID user account for Teamspace.";
+        parent::__construct();
+        $this->mDescription = 'Create a new CCID user account for Teamspace.';
 
-        #$this->addArg( "global", "CCID global identifier of new user" );
-        $this->addArg( "email", "CCID email of new user (will be used as user name as well)" );
-	$this->addArg( "name", "Real name of user" );
+        $this->addArg(
+            'email',
+            'CCID email of new user (will be used as the username as well)'
+        );
+        $this->addArg( 'name', 'Real name of user' );
     }
 
     public function execute() {
         global $CASAuth;
 
         if (! isset( $CASAuth )) {
-            $this->error('$CASAuth not set in LocalSettings.php', true);
+            $this->error( '$CASAuth not set in LocalSettings.php', true );
         }
 
-        $name = $global = $this->getArg( 1 );
         $casuid = $email = $this->getArg( 0 );
+        $name = $global = $this->getArg( 1 );
         $ccid_name = ucfirst ( $email );
 
         $u = User::newFromName( $ccid_name );
         // Create a new account if the user does not exists
         if ($u->getID() != 0) {
-            $this->error("User already exists", true);
+            $this->error( 'User already exists', true );
             exit(1);
         } else {
-            //$nickname = $attr['nickname'];
             // Create the user
             $u->addToDatabase();
-            $u->setRealName($name);
-            $u->setEmail($casuid);
+            $u->setRealName( $name );
+            $u->setEmail( $casuid );
             $u->confirmEmail();
-            $u->setPassword( md5($casuid.$CASAuth["PwdSecret"]) ); //PwdSecret is used to salt the casuid, which is then used to create an md5 hash which becomes the password
+            //PwdSecret is used to salt the casuid, which is then used to
+            //  create an md5 hash which becomes the password
+            $u->setPassword( md5($casuid.$CASAuth['PwdSecret']) );
             $u->setToken();
             $u->saveSettings();
             // Update user count
@@ -64,5 +67,5 @@ public function execute() {
     }
 }
 
-$maintClass = "AddCCIDUser";
+$maintClass = 'AddCCIDUser';
 require_once RUN_MAINTENANCE_IF_MAIN;