better align script with best and local practices

Author: TimidRobot

bin/load_data.sh

@@ -1,7 +1,9 @@
-#!/bin/bash
+#!/usr/bin/env bash
 #
 # Load Django application data
 #
+#### SETUP ####################################################################
+
 set -o errexit
 set -o errtrace
 set -o nounset
@@ -12,6 +14,8 @@ trap '_es=${?};
     printf " exited with a status of ${_es}\n";
     exit ${_es}' ERR
 
+DATA_FILE='../cc-legal-tools-data/config/app_data.yaml'
+DIR_REPO="$(cd -P -- "${0%/*}/.." && pwd -P)"
 # https://en.wikipedia.org/wiki/ANSI_escape_code
 E0="$(printf "\e[0m")"        # reset
 E30="$(printf "\e[30m")"      # black foreground
@@ -20,7 +24,6 @@ E107="$(printf "\e[107m")"    # bright white background
 
 #### FUNCTIONS ################################################################
 
-
 check_docker() {
     local _msg
     if ! docker compose exec app true 2>/dev/null; then
@@ -30,29 +33,27 @@ check_docker() {
     fi
 }
 
-
 error_exit() {
     # Echo error message and exit with error
     echo -e "${E31}ERROR:${E0} ${*}" 1>&2
     exit 1
 }
 
-
 print_header() {
     # Print 80 character wide black on white heading with time
     printf "${E30}${E107}# %-70s$(date '+%T') ${E0}\n" "${@}"
 }
 
-
 #### MAIN #####################################################################
 
+cd "${DIR_REPO}"
+
 check_docker
 
-print_header 'Load data (LegalCode and Tool models)'
-data_file='../cc-legal-tools-data/config/app_data.yaml'
-du -h "${data_file}"
+print_header 'Django loaddata - Import LegalCode and Tool model data'
+du -h "${DATA_FILE}"
 docker compose exec app ./manage.py loaddata \
     --app legal_tools \
     --verbosity 3 \
-    "${data_file}"
+    "${DATA_FILE}"
 echo