Skip to content

[Bug] GitHub token authentication fails #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 task done
TimidRobot opened this issue Mar 10, 2023 · 0 comments · Fixed by #170
Closed
1 task done

[Bug] GitHub token authentication fails #167

TimidRobot opened this issue Mar 10, 2023 · 0 comments · Fixed by #170
Assignees
@TimidRobot
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be fixed soon 🔒 staff only Restricted to CC staff members 🏁 status: ready for work Ready for work

Comments

@TimidRobot
Copy link
Member

Description

GitHub token authentication fails.

I think something changed between Python versions that impacted the behavior of global variables.

The end result is that the following will result in https://None:None:

ccos-scripts/ccos/teams/set_codeowners.py

Line 279 in cebc132

f"https://{GITHUB_USERNAME}:{GITHUB_TOKEN}"

Reproduction

Ope, I was in the middle of too many errors and didn't save good artifacts for this issue 😬

Expectation

Authentication is a necessity

Additional context

Resolution

  • I would be interested in resolving this bug.
@TimidRobot TimidRobot added 🟨 priority: medium Not blocking but should be fixed soon 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository 🔒 staff only Restricted to CC staff members 🏁 status: ready for work Ready for work labels Mar 10, 2023
@TimidRobot TimidRobot self-assigned this Mar 10, 2023
@TimidRobot TimidRobot mentioned this issue Mar 11, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TimidRobot TimidRobot

Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be fixed soon 🔒 staff only Restricted to CC staff members 🏁 status: ready for work Ready for work
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Logging sync etc creativecommons/ccos-scripts
1 participant
@TimidRobot