Skip to content

Account for case differences when syncing labels #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 task
dhruvkb opened this issue Sep 25, 2020 · 7 comments · Fixed by #89
Closed
1 task

Account for case differences when syncing labels #84

dhruvkb opened this issue Sep 25, 2020 · 7 comments · Fixed by #89
Assignees
@wescran
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix good first issue New-contributor friendly help wanted Open to participation from the community 🟨 priority: medium Not blocking but should be fixed soon 💪 skill: python Requires proficiency in 'Python' 🏁 status: ready for work Ready for work

Comments

@dhruvkb
Copy link
Member

dhruvkb commented Sep 25, 2020

Description

While Python does not see the label "hacktoberfest" and "Hacktoberfest" as equal, GitHub does. So if there is a case difference, the script will try to create the label and GitHub will raise an error that it already exists.

ccos-scripts/normalize_repos/models.py

Line 106 in 7d7ee1d

def __eq__(self, remote):

Reproduction

  1. Change the case of a standard label.
  2. Sync workflow will fail.
  3. See error.

Expectation

Python should be able to sync the names to their correct values, while accounting for different cases when matching labels to the JSON file.

Resolution

  • I would be interested in resolving this bug.
@dhruvkb dhruvkb added 🟨 priority: medium Not blocking but should be fixed soon 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository good first issue New-contributor friendly help wanted Open to participation from the community 💪 skill: python Requires proficiency in 'Python' Hacktoberfest 🏁 status: ready for work Ready for work labels Sep 25, 2020
@wescran
Copy link
Contributor

wescran commented Sep 25, 2020

Hello, I am interested in taking on this task!

@kgodey
Copy link
Member

kgodey commented Sep 25, 2020

go ahead @wescran

@tushar912
Copy link

@wescran are u working on this. If not can i take it up?

@dhruvkb
Copy link
Member Author

dhruvkb commented Sep 28, 2020

@tushar912 please allow a 7 day buffer period of inactivity before considering an issue as inactive. In the meantime, might I suggest our Issue Finder?

@tushar912
Copy link

Ok

@wescran
Copy link
Contributor

wescran commented Sep 28, 2020

Hi there, I will have a [WIP] PR opened today!

@wescran wescran mentioned this issue Sep 28, 2020
Merged
4 tasks
@wescran
Copy link
Contributor

wescran commented Oct 2, 2020

PR is ready for review!

@kgodey kgodey closed this as completed in #89 Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wescran wescran

Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix good first issue New-contributor friendly help wanted Open to participation from the community 🟨 priority: medium Not blocking but should be fixed soon 💪 skill: python Requires proficiency in 'Python' 🏁 status: ready for work Ready for work
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added casefolding for label name comparisons. wescran/ccos-scripts
4 participants
@kgodey @dhruvkb @wescran @tushar912