Skip to content

Commit d3f32c6

Browse files
authored
Merge pull request #566 from creativecommons/more_labels
Document and style more labels
2 parents 96e8dda + 2c4b157 commit d3f32c6

File tree

3 files changed

+17
-3
lines changed

3 files changed

+17
-3
lines changed

content/contributing-code/repo-labels/contents.lr

+14-2
Original file line numberDiff line numberDiff line change
@@ -134,6 +134,10 @@ label based on whether it was closed with or without resolution, respectively.
134134
🧹 status: ticket work required
135135
</span>
136136
- **Description:** Needs more details before it can be worked on
137+
- <span class="gh-label status-dark">
138+
🏷 status: label work required
139+
</span>
140+
- **Description:** Needs proper labelling before it can be worked on
137141
- <span class="gh-label status-lighter">
138142
⛔️ status: discarded
139143
</span>
@@ -211,11 +215,19 @@ recognized by GitHub. The special ones don't have emojis either._
211215

212216
### Miscellaneous
213217

214-
- <span class="gh-label has-background-black has-text-white">
218+
- <span class="gh-label miscellaneous">
215219
🤯 ノಠ益ಠノ彡┻━┻
216220
</span>
217221
- **Description:** Aaargh!
218-
222+
- <span class="gh-label hacktoberfest">
223+
Hacktoberfest
224+
</span>
225+
- **Description:** Good issues for Hacktoberfest participants
226+
- <span class="gh-label invalid">
227+
invalid
228+
</span>
229+
- **Description:** Inappropriate or invalid (ex. Hacktoberfest spam)
230+
219231
## Usage rules
220232

221233
In the above categories, some are marked with an `*` sign. Those are mandatory

webpack/js/components.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ export const IssueLabel = {
2929
* @returns {string} the name of the class to apply to the label
3030
*/
3131
className() {
32-
return this.$root.categories[this.name] || 'miscellaneous'
32+
return this.$root.categories[this.name] || `${this.name.toLocaleLowerCase()} miscellaneous`
3333
}
3434
}
3535
}

webpack/sass/main.scss

+2
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,8 @@ pre {
7070
('priority-positive' #cfda2c #000000),
7171
('priority-favourable' #008672 #ffffff),
7272
('miscellaneous' #000000 #ffffff),
73+
('hacktoberfest' #883255 #ffffff),
74+
('invalid' #eeeeee #000000),
7375
);
7476
@each $category, $background-color, $foreground-color in $label-colors {
7577
&.#{$category} {

0 commit comments

Comments
 (0)