Skip to content

Commit 1b39467

Browse files
author
Ari
committed
Resolve merge conflict
2 parents b74e686 + 28e81d5 commit 1b39467

18 files changed

+20
-876
lines changed

README.md

+1-5
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,9 @@ The Creative Commons License Chooser is meant to help people learn about CC lice
55
## About
66
Repository containing the source code for the new Creative Commons License Chooser. The new chooser is still in beta, and a beta deployment can be found [here](https://chooser-beta.creativecommons.org/).
77

8-
This site is built using [Vue.js](https://vuejs.org/), [Bulma](https://bulma.io/), [Buefy](https://buefy.org/), and [Webpack](https://webpack.js.org/).
8+
This site is built using [Vue.js](https://vuejs.org/) (and vue-cli), and [Buefy](https://buefy.org/), among other things.
99

1010
#### Roadmap
11-
There is still some work to go before the new chooser is ready to replace the existing chooser. These tasks include:
12-
- Improvments to the Chooser's UI
13-
- Internationalization
14-
- Infrastructural work (Setting up analytics, monitoring, error logging)
1511

1612
Tasks, issues, and discussion related to the release of the new chooser are tracked with the [`Launch Milestone`](https://github.com/creativecommons/cc-chooser/milestone/1).
1713

src/components/HelpSection.vue

+16-14
Original file line numberDiff line numberDiff line change
@@ -170,18 +170,20 @@
170170
<p v-html="this.$t('help.how-licenses-communicated.text')" />
171171
<table class="table is-hoverable is-fullwidth help-section__table">
172172
<tbody>
173-
<tr>
174-
<th>{{ $t('help.how-licenses-communicated.full-name') }}</th>
175-
<td>{{ $t('help.how-licenses-communicated.CC-BY-SA') }}</td>
176-
</tr>
177-
<tr>
178-
<th>{{ $t('help.how-licenses-communicated.short-name') }}</th>
179-
<td>CC BY-NC</td>
180-
</tr>
181-
<tr>
182-
<th>{{ $t('help.how-licenses-communicated.license-icons') }}</th>
183-
<td><LicenseIconography :icon-list="['', 'by', 'nc']" /></td>
184-
</tr>
173+
<tr>
174+
<th>{{$t('help.how-licenses-communicated.full-name')}}</th>
175+
<td>{{$t('help.how-licenses-communicated.CC-BY-NC')}}</td>
176+
</tr>
177+
<tr>
178+
<th>{{$t('help.how-licenses-communicated.short-name')}}</th>
179+
<td>CC BY-NC</td>
180+
</tr>
181+
<tr>
182+
<th>{{$t('help.how-licenses-communicated.license-icons')}}</th>
183+
<td>
184+
<LicenseIcons :iconsArr="['by', 'nc']"/>
185+
</td>
186+
</tr>
185187
</tbody>
186188
</table>
187189
</section>
@@ -202,7 +204,7 @@
202204
</div>
203205
</template>
204206
<script>
205-
import LicenseIconography from './LicenseIconography'
207+
import LicenseIcons from './LicenseIcons'
206208
207209
// eslint-disable-next-line
208210
const ModalForm = {
@@ -224,7 +226,7 @@ const ModalForm = {
224226
}
225227
export default {
226228
components: {
227-
LicenseIconography
229+
LicenseIcons
228230
},
229231
data() {
230232
return {

src/components/LicenseIconography.vue

-61
This file was deleted.

src/locales/en.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,7 @@
168168
"full-name": "Full Name",
169169
"short-name": "Short Name",
170170
"license-icons": "Icons",
171-
"CC-BY-SA": "Creative Commons Attribution 4.0 International"
171+
"CC-BY-NC": "Attribution-NonCommercial 4.0 International"
172172
},
173173
"considerations-before-licensing": {
174174
"heading": "Considerations Before Licensing",

tests/README.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,12 @@ This file will be used to document some useful commands and tips for tests. Also
88
If you want to run only unit tests, use:
99

1010
``` bash
11-
$ npm run unit
11+
$ npm run test:unit
1212
```
1313

1414
If you want to run only e2e tests, use:
1515
``` bash
16-
$ npm run e2e
16+
$ npm run test:e2e
1717
```
1818

1919
### About Snapshots Test

tests/e2e/specs/CopyButton.js

-31
This file was deleted.

tests/e2e/specs/LicenseDescription.js

-59
This file was deleted.

tests/unit/specs/components/AttributionDetailsStep.spec.js

-44
This file was deleted.

tests/unit/specs/components/HelpSection.spec.js

-97
This file was deleted.

0 commit comments

Comments
 (0)