Skip to content

Commit 2a4e827

Browse files
committed
Use domain names instead of URLs and harmonize example creator
1 parent fb8e447 commit 2a4e827

File tree

3 files changed

+11
-10
lines changed

3 files changed

+11
-10
lines changed

src/locales/ru.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,15 +73,15 @@
7373
},
7474
"creator-profile": {
7575
"label": "URL of creator profile",
76-
"placeholder": "www.author.com"
76+
"placeholder": "https://janedoe.com"
7777
},
7878
"work-title": {
7979
"label": "Title of Work",
8080
"placeholder": "This work"
8181
},
8282
"work-url": {
8383
"label": "Work URL",
84-
"placeholder": "www.author.com/work.jpg"
84+
"placeholder": "https://janedoe.com/best-photo-ever.jpg"
8585
}
8686
}
8787
}

tests/e2e/specs/LicenseCode.js

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,15 +17,16 @@ module.exports = {
1717
// 'Check if the links in the license code redirects properly': function(browser) {
1818
// browser
1919
// .setValue('input[placeholder="Jane Doe"]', 'Jane Doe')
20-
// .setValue('input[placeholder="www.author.com"]', 'www.author.com')
20+
// .setValue('input[placeholder="https://janedoe.com"]', 'https://janedoe.com')
2121
// .setValue('input[placeholder="This work"]', 'This work')
22-
// .setValue('input[placeholder="www.author.com/work.jpg"]', 'www.author.com/work.jpg')
22+
// .setValue('input[placeholder="https://janedoe.com/best-photo-ever.jpg"]', 'https://janedoe.com/best-photo-ever.jpg')
2323
// .assert.elementPresent('p[class="license-text"] a')
2424
// .getAttribute('p > span > a:nth-child(1)', 'href', function(result) {
25-
// this.assert.equal(result.value, 'http://www.author.com/work.jpg')
25+
// this.assert.equal(result.value, 'https://janedoe.com/best-photo-ever.jpg')
26+
// })
2627
// })
2728
// .getAttribute('p > span > a:nth-child(2)', 'href', function(result) {
28-
// this.assert.equal(result.value, 'http://www.author.com/')
29+
// this.assert.equal(result.value, 'https://janedoe.com')
2930
// })
3031
// .getAttribute('p > span > a:nth-child(4)', 'href', function(result) {
3132
// const urlString = result.value.split('/').slice(3).join('/')
@@ -51,7 +52,7 @@ module.exports = {
5152
// browser
5253
// .expect.element('#attribution-text > p > span:nth-child(1) > span:nth-child(4)').text.to.equal('CC BY-SA 4.0')
5354
// },
54-
// 'Check if the author-name in plain text is displayed': function(browser) {
55+
// 'Check if the creator-name in plain text is displayed': function(browser) {
5556
// browser
5657
// .expect.element('#attribution-text > p > span:nth-child(1) > span:nth-child(2) > span').text.to.equal('Jane Doe')
5758
// },

tests/unit/specs/components/LicenseCode.spec.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,9 @@ import { CCBYAttributes } from '@/utils/license-utilities'
77

88
const TEST_DATA = {
99
creatorName: 'Jane Doe',
10-
creatorProfileUrl: 'www.author.com',
10+
creatorProfileUrl: 'https://janedoe.com',
1111
workTitle: 'My work',
12-
workUrl: 'www.author.com/picture.jpg'
12+
workUrl: 'https://janedoe.com/best-photo-ever.jpg'
1313
}
1414

1515
describe('LicenseCode.vue', () => {
@@ -85,7 +85,7 @@ describe('LicenseCode.vue', () => {
8585
const creatorElement = wrapper.find('[property="cc:attributionName"]')
8686
expect(Object.keys(creatorElement.attributes()).length).toEqual(3)
8787
expect(creatorElement.text()).toEqual(TEST_DATA.creatorName)
88-
expect(creatorElement.attributes().href).toEqual('http://' + TEST_DATA.creatorProfileUrl)
88+
expect(creatorElement.attributes().href).toEqual(TEST_DATA.creatorProfileUrl)
8989
expect(creatorElement.attributes().rel).toEqual('cc:attributionURL')
9090
expect(creatorElement.name()).toEqual('a')
9191
})

0 commit comments

Comments
 (0)