Skip to content

Commit 575fa7a

Browse files
committed
Merge master
2 parents 1f8778b + 3216482 commit 575fa7a

File tree

7 files changed

+20585
-20
lines changed

7 files changed

+20585
-20
lines changed

.cc-metadata.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,4 +5,4 @@ english_name: CC Chooser
55
# All technologies used
66
technologies: HTML, CSS, JS, Bulma, Vue, Jest
77
# Whether this repository should be featured on the CC Open Source site
8-
featured: false
8+
featured: true

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,6 @@ To run e2e tests, you must have Java installed. [[download Java here](https://ja
4444

4545

4646
## Deployment
47-
The source files for the beta deployment are contained in the `./docs/` dir, and are live. Any changes to this dir's contents will be automatically deployed, so please take care when making modifications to this location.
47+
The chooser is deployed to GitHub Pages. The source files for the beta deployment are contained in the `./docs/` dir, and are live. Any changes to this dir's contents will be automatically deployed, so please take care when making modifications to this location.
4848

4949
To update the dist bundle, run ```$ npm run build```, and copy the generated files from `./dist/` to `./docs/`, taking care to not delete the CNAME file in `./docs/`.

package-lock.json

Lines changed: 20555 additions & 9 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/App.vue

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,21 @@
55
id="site-container"
66
class="container"
77
>
8+
<nav
9+
class="breadcrumb caption bold"
10+
aria-label="breadcrumbs"
11+
>
12+
<ul>
13+
<li><a href="#">Home</a></li>
14+
<li><a href="#">Child Page</a></li>
15+
<li class="is-active">
16+
<a
17+
href="#"
18+
aria-current="page"
19+
>Chooser</a>
20+
</li>
21+
</ul>
22+
</nav>
823
<div class="page-head">
924
<div class="select-license-column">
1025
<h2 class="vocab">
@@ -115,6 +130,9 @@ export default {
115130
#site-container {
116131
padding: 0.75rem;
117132
}
133+
.breadcrumb {
134+
margin-bottom: 2rem;
135+
}
118136
.page-head {
119137
display: grid;
120138
grid-template-columns: 1fr;

src/locales/ru.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,15 +73,15 @@
7373
},
7474
"creator-profile": {
7575
"label": "URL of creator profile",
76-
"placeholder": "www.author.com"
76+
"placeholder": "https://janedoe.com"
7777
},
7878
"work-title": {
7979
"label": "Title of Work",
8080
"placeholder": "This work"
8181
},
8282
"work-url": {
8383
"label": "Work URL",
84-
"placeholder": "www.author.com/work.jpg"
84+
"placeholder": "https://janedoe.com/best-photo-ever.jpg"
8585
}
8686
}
8787
}

tests/e2e/specs/LicenseCode.js

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,15 +17,16 @@ module.exports = {
1717
// 'Check if the links in the license code redirects properly': function(browser) {
1818
// browser
1919
// .setValue('input[placeholder="Jane Doe"]', 'Jane Doe')
20-
// .setValue('input[placeholder="www.author.com"]', 'www.author.com')
20+
// .setValue('input[placeholder="https://janedoe.com"]', 'https://janedoe.com')
2121
// .setValue('input[placeholder="This work"]', 'This work')
22-
// .setValue('input[placeholder="www.author.com/work.jpg"]', 'www.author.com/work.jpg')
22+
// .setValue('input[placeholder="https://janedoe.com/best-photo-ever.jpg"]', 'https://janedoe.com/best-photo-ever.jpg')
2323
// .assert.elementPresent('p[class="license-text"] a')
2424
// .getAttribute('p > span > a:nth-child(1)', 'href', function(result) {
25-
// this.assert.equal(result.value, 'http://www.author.com/work.jpg')
25+
// this.assert.equal(result.value, 'https://janedoe.com/best-photo-ever.jpg')
26+
// })
2627
// })
2728
// .getAttribute('p > span > a:nth-child(2)', 'href', function(result) {
28-
// this.assert.equal(result.value, 'http://www.author.com/')
29+
// this.assert.equal(result.value, 'https://janedoe.com')
2930
// })
3031
// .getAttribute('p > span > a:nth-child(4)', 'href', function(result) {
3132
// const urlString = result.value.split('/').slice(3).join('/')
@@ -51,7 +52,7 @@ module.exports = {
5152
// browser
5253
// .expect.element('#attribution-text > p > span:nth-child(1) > span:nth-child(4)').text.to.equal('CC BY-SA 4.0')
5354
// },
54-
// 'Check if the author-name in plain text is displayed': function(browser) {
55+
// 'Check if the creator-name in plain text is displayed': function(browser) {
5556
// browser
5657
// .expect.element('#attribution-text > p > span:nth-child(1) > span:nth-child(2) > span').text.to.equal('Jane Doe')
5758
// },

tests/unit/specs/components/LicenseText.spec.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,9 @@ import { CCBYAttributes, LICENSES } from '@/utils/license-utilities'
77

88
const TEST_DATA = {
99
creatorName: 'Jane Doe',
10-
creatorProfileUrl: 'www.author.com',
10+
creatorProfileUrl: 'https://janedoe.com',
1111
workTitle: 'My work',
12-
workUrl: 'www.author.com/picture.jpg'
12+
workUrl: 'https://janedoe.com/best-photo-ever.jpg'
1313
}
1414

1515
describe('LicenseText.vue', () => {

0 commit comments

Comments
 (0)