Skip to content

Commit 95cf8b8

Browse files
obulatobulat
committed
Review strings and string names
Signed-off-by: Olga Bulat <obulat@gmail.com>
1 parent b4a543f commit 95cf8b8

File tree

9 files changed

+131
-201
lines changed

9 files changed

+131
-201
lines changed

‎src/App.vue‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<template>
22
<div id="app">
3-
<Header :title="$t('app-title')"/>
3+
<Header :title="$t('app.title')"/>
44
<div class="container" id="site-container">
55
<div class="page-head columns">
66
<div class="column">

‎src/components/Footer.vue‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<footer class="footer chooser-footer">
33
<div class="container chooser-footer-container">
44
<section class="cc-info-column">
5-
<img src="../assets/cc-logo_white.png" :alt="$t('cc-logo')" class="footer-cc-logo">
5+
<img src="../assets/cc-logo_white.png" :alt="$t('alt.cc-logo')" class="footer-cc-logo">
66
<p class="vocab-body-normal no-bottom-margin">Creative Commons</p>
77
<p class="vocab-body-normal">PO Box 1866, Mountain View, CA 94042</p>
88
<p class="vocab-body-normal"><a href="mailto:info@creativecommons.org">info@creativecommons.org</a></p>

‎src/components/HelpSection.vue‎

Lines changed: 41 additions & 41 deletions
Original file line numberDiff line numberDiff line change
@@ -12,30 +12,30 @@
1212

1313
<b-modal :active.sync="modals[1].status">
1414
<header class="modal-card-head">
15-
<p class="modal-card-title modal-title" v-html="this.$t('help.what_are_cc_licenses.heading')"/>
15+
<p class="modal-card-title modal-title" v-html="this.$t('help.what-are-cc-licenses.heading')"/>
1616
</header>
1717
<section class="modal-card-body">
18-
<article class="help-text" v-html="this.$t('help.what_are_cc_licenses.text')"/>
18+
<article class="help-text" v-html="this.$t('help.what-are-cc-licenses.text')"/>
1919
<footer class="modal-card-foot">
20-
<p v-html="this.$t('help.what_are_cc_licenses.footer')"/>
20+
<p v-html="this.$t('help.what-are-cc-licenses.footer')"/>
2121
</footer>
2222
</section>
2323
</b-modal>
2424
<b-modal :active.sync="modals[2].status">
2525
<header class="modal-card-head">
2626
<p class="modal-card-title modal-title">
27-
{{ $t('help.how_licenses_work.heading') }}
27+
{{ $t('help.how-licenses-work.heading')}}
2828
</p>
2929
</header>
3030
<section class="modal-card-body">
31-
<article v-html="this.$t('help.how_licenses_work.text')"/>
32-
<footer class="modal-card-foot" v-html="this.$t('help.how_licenses_work.footer')"/>
31+
<article v-html="this.$t('help.how-licenses-work.text')"/>
32+
<footer class="modal-card-foot" v-html="this.$t('help.how-licenses-work.footer')"/>
3333
</section>
3434
</b-modal>
3535
<b-modal :active.sync="modals[3].status">
3636
<header class="modal-card-head">
3737
<p class="modal-card-title modal-title">
38-
{{ $t('help.what_icons_mean.heading') }}
38+
{{ $t('help.what-icons-mean.heading')}}
3939
</p>
4040
</header>
4141
<section class="modal-card-body">
@@ -45,24 +45,24 @@
4545
<div class="edu-icons-title-section is-gapless">
4646
<img src="../assets/license-icons/cc-by_icon.svg">
4747
<div class="icon-title">
48-
<b>{{ $t('help.what_icons_mean.BY.long_name') }}</b>
49-
<p class="help">{{ $t('help.what_icons_mean.BY.short_name') }}</p>
48+
<b>{{ $t('help.what-icons-mean.BY.long-name')}}</b>
49+
<p class="help">{{ $t('help.what-icons-mean.BY.short-name')}}</p>
5050
</div>
5151
</div>
5252
<p>
53-
{{ $t('help.what_icons_mean.BY.text')}}
53+
{{ $t('help.what-icons-mean.BY.text')}}
5454
</p>
5555
</div>
5656
<div class="edu-icons-section is-gapless">
5757
<div class="edu-icons-title-section">
5858
<img src="../assets/license-icons/cc-nd_icon.svg">
5959
<div class="icon-title">
60-
<b>{{ $t('help.what_icons_mean.ND.long_name') }}</b>
61-
<p class="help">{{ $t('help.what_icons_mean.ND.short_name') }}</p>
60+
<b>{{ $t('help.what-icons-mean.ND.long-name')}}</b>
61+
<p class="help">{{ $t('help.what-icons-mean.ND.short-name')}}</p>
6262
</div>
6363
</div>
6464
<p>
65-
{{ $t('help.what_icons_mean.ND.text') }}
65+
{{ $t('help.what-icons-mean.ND.text')}}
6666

6767
</p>
6868
</div>
@@ -72,65 +72,65 @@
7272
<div class="edu-icons-title-section">
7373
<img class="icon-img" src="../assets/license-icons/cc-nc_icon.svg">
7474
<div class="icon-title">
75-
<b>{{ $t('help.what_icons_mean.NC.long_name') }}</b>
76-
<p class="help">{{ $t('help.what_icons_mean.NC.short_name') }}</p>
75+
<b>{{ $t('help.what-icons-mean.NC.long-name')}}</b>
76+
<p class="help">{{ $t('help.what-icons-mean.NC.short-name')}}</p>
7777
</div>
7878
</div>
79-
<div v-html="this.$t('help.what_icons_mean.NC.text')"></div>
79+
<div v-html="this.$t('help.what-icons-mean.NC.text')"></div>
8080
</div>
8181
<div class="edu-icons-section">
8282
<div class="edu-icons-title-section is-gapless">
8383
<img src="../assets/license-icons/cc-sa_icon.svg">
8484
<div class="icon-title">
85-
<b>{{ $t('help.what_icons_mean.SA.long_name') }}</b>
86-
<p class="help">{{ $t('help.what_icons_mean.SA.short_name') }}</p>
85+
<b>{{ $t('help.what-icons-mean.SA.long-name')}}</b>
86+
<p class="help">{{ $t('help.what-icons-mean.SA.short-name')}}</p>
8787
</div>
8888
</div>
8989
<p>
90-
{{ $t('help.what_icons_mean.SA.text') }}
90+
{{ $t('help.what-icons-mean.SA.text')}}
9191
</p>
9292
</div>
9393
</div>
9494
</div>
95-
<footer class="modal-card-foot" v-html="this.$t('help.what_icons_mean.footer')">
95+
<footer class="modal-card-foot" v-html="this.$t('help.what-icons-mean.footer')">
9696

9797
</footer>
9898
</section>
9999
</b-modal>
100100
<b-modal :active.sync="modals[4].status">
101101
<header class="modal-card-head">
102102
<p class="modal-card-title modal-title">
103-
{{ $t('help.considerations_before_licensing.heading') }}
103+
{{ $t('help.considerations-before-licensing.heading')}}
104104
</p>
105105
</header>
106106
<section class="modal-card-body">
107-
<article v-html="this.$t('help.considerations_before_licensing.text')" />
107+
<article v-html="this.$t('help.considerations-before-licensing.text')" />
108108
<footer class="modal-card-foot">
109-
<p v-html="this.$t('help.considerations_before_licensing.footer')" />
109+
<p v-html="this.$t('help.considerations-before-licensing.footer')" />
110110
</footer>
111111
</section>
112112
</b-modal>
113113
<b-modal :active.sync="modals[5].status">
114114
<header class="modal-card-head">
115115
<p class="modal-card-title modal-title">
116-
{{ $t('help.how_formally_license.heading') }}
116+
{{ $t('help.how-formally-license.heading')}}
117117
</p>
118118
</header>
119119
<section class="modal-card-body">
120-
<article v-html="this.$t('help.how_formally_license.text')"/>
120+
<article v-html="this.$t('help.how-formally-license.text')"/>
121121
</section>
122122
</b-modal>
123123
<b-modal :active.sync="modals[6].status">
124124
<header class="modal-card-head">
125125
<p class="modal-card-title modal-title">
126-
{{ $t('help.six_cc_licenses.heading') }}
126+
{{ $t('help.six-cc-licenses.heading')}}
127127
</p>
128128
</header>
129129
<section class="modal-card-body">
130130
<div class="columns">
131131
<div class="column is-two-thirds">
132132
<article
133-
v-html="this.$t('help.six_cc_licenses.text')">
133+
v-html="this.$t('help.six-cc-licenses.text')">
134134
</article>
135135
</div>
136136
<div class="column">
@@ -139,29 +139,29 @@
139139
</div>
140140

141141
<footer class="modal-card-foot">
142-
<p v-html="this.$t('help.six_cc_licenses.footer')" />
142+
<p v-html="this.$t('help.six-cc-licenses.footer')" />
143143
</footer>
144144
</section>
145145
</b-modal>
146146
<b-modal :active.sync="modals[7].status">
147147
<header class="modal-card-head">
148-
<p class="modal-card-title modal-title">{{ $t('help.how_licenses_communicated.heading') }}
148+
<p class="modal-card-title modal-title">{{$t('help.how-licenses-communicated.heading')}}
149149
</p>
150150
</header>
151151
<section class="modal-card-body">
152-
<p v-html="this.$t('help.how_licenses_communicated.text')" />
152+
<p v-html="this.$t('help.how-licenses-communicated.text')" />
153153
<table class="table is-hoverable is-fullwidth">
154154
<tbody>
155155
<tr>
156-
<th>{{ $t('general.license_full_name') }}</th>
157-
<td>{{ $t('license_full_names.CC-BY-SA') }}</td>
156+
<th>{{$t('help.how-licenses-communicated.full-name')}}</th>
157+
<td>{{$t('help.how-licenses-communicated.CC-BY-SA')}}</td>
158158
</tr>
159159
<tr>
160-
<th>{{ $t('general.license_short_name') }}</th>
160+
<th>{{$t('help.how-licenses-communicated.short-name')}}</th>
161161
<td>CC BY-NC</td>
162162
</tr>
163163
<tr>
164-
<th>{{ $t('general.license_icons') }}</th>
164+
<th>{{$t('help.how-licenses-communicated.license-icons')}}</th>
165165
<td><LicenseIconography :icon-list="['', 'by', 'nc']"/></td>
166166
</tr>
167167
</tbody>
@@ -201,31 +201,31 @@ export default {
201201
modals: {
202202
1: {
203203
status: false,
204-
title: 'what_are_cc_licenses'
204+
title: 'what-are-cc-licenses'
205205
},
206206
2: {
207207
status: false,
208-
title: 'how_licenses_work'
208+
title: 'how-licenses-work'
209209
},
210210
3: {
211211
status: false,
212-
title: 'what_icons_mean'
212+
title: 'what-icons-mean'
213213
},
214214
4: {
215215
status: false,
216-
title: 'considerations_before_licensing'
216+
title: 'considerations-before-licensing'
217217
},
218218
5: {
219219
status: false,
220-
title: 'how_formally_license'
220+
title: 'how-formally-license'
221221
},
222222
6: {
223223
status: false,
224-
title: 'six_cc_licenses'
224+
title: 'six-cc-licenses'
225225
},
226226
7: {
227227
status: false,
228-
title: 'how_licenses_communicated'
228+
title: 'how-licenses-communicated'
229229
}
230230
}
231231
}

‎src/components/LicenseDetailsCard.vue‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<template>
22
<div class="selected-license-card">
3-
<h3 class="vocab ha h3a">{{$t('selected-license.heading')}}</h3>
3+
<h3 class="vocab ha h3a">{{$t('license-details-card.heading')}}</h3>
44
<h4 class="vocab h4b hb">
55
<a :href="licenseUrl" class="license-name">{{fullName}} ({{shortName}})
66
<LicenseIcons

‎src/components/LicenseUseCard.vue‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,18 @@
11
<template>
22
<div class="license-use-card">
33
<h4 class="vocab h4b hb">Use Your License</h4>
4-
<p class="license-use-instructions">{{$t('use-license.common-instructions')}}</p>
4+
<p class="license-use-instructions">{{$t('license-use.common-instructions')}}</p>
55
<b-tabs>
66
<b-tab-item label="Website">
7-
{{$t('use-license.web-instructions')}}
7+
{{$t('license-use.web-instructions')}}
88
<SelectedLicenseCode v-model="value"/>
99
</b-tab-item>
1010
<b-tab-item label="Print Work">
11-
{{$t('use-license.print-instructions')}}
12-
<SelectedLicenseCode v-model="value"/>
11+
{{$t('license-use.print-instructions')}}
12+
<license-code attribution-type="print"/>
1313
</b-tab-item>
1414
<b-tab-item label="Media">
15-
{{$t('use-license.media-instructions')}}
15+
{{$t('license-use.media-instructions')}}
1616
</b-tab-item>
1717
</b-tabs>
1818
</div>

‎src/components/LocaleChooser.vue‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<template>
22
<div class="locale-chooser">
3-
<b-field :label="this.$t('locale-chooser.label')" :class="'locale-chooser-field'">
3+
<b-field :label="this.$t('locale-selector.label')" :class="'locale-chooser-field'">
44
<b-select v-model="$i18n.locale">
55
<option
66
v-for="lang in this.availableLocaleNames"

0 commit comments

Comments
 (0)