Skip to content

Add unit and e2e tests for the LicenseDropdown component #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
akmadian opened this issue Mar 5, 2020 · 11 comments · Fixed by #201
Closed

Add unit and e2e tests for the LicenseDropdown component #120

akmadian opened this issue Mar 5, 2020 · 11 comments · Fixed by #201
Labels
💻 aspect: code Concerns the software code in the repository 🤖 aspect: dx Concerns developers' experience with the codebase good first issue New-contributor friendly help wanted Open to participation from the community

Comments

@akmadian
Copy link
Member

akmadian commented Mar 5, 2020

Unit and e2e tests need to be written for the LicenseDropdown component. Unit tests are done with Jest, and e2e tests are done with nightwatch.

Please remember to test the following things:

  • That individual parts of the component are present when appropriate. (unit and e2e)
  • That any computed props and methods work properly, if there are any. (unit)
  • Any common interactions between the user and component, if there are any. (e2e)
  • Any other functionality unique to the component being tested!

Additional Context

@akmadian akmadian added help wanted Open to participation from the community good first issue New-contributor friendly test-coverage labels Mar 5, 2020
@akmadian akmadian mentioned this issue Mar 5, 2020
14 tasks
@abhisheknaiidu
Copy link

Want to work on this.

@akmadian
Copy link
Member Author

akmadian commented Mar 5, 2020

Go ahead @abhisheknaiidu :)

@hemanth-hk
Copy link
Contributor

Any help @abhisheknaiidu?

@abhisheknaiidu
Copy link

@hemanth-hk you can work on this if you want. Right now, I am just contributing to CC Search repo as I wanted to contribute to their codebase as much as can.

@hemanth-hk
Copy link
Contributor

@abhisheknaiidu I have already submitted 2 PR's, If you are stuck anywhere I can help you

@abhisheknaiidu
Copy link

@hemanth-hk Thanks, but I haven't yet started working on this, As I said earlier, if you want, you can work on this :)

@akmadian
Copy link
Member Author

I'm gonna free this issue up to other contributors. @hemanth-hk since you've already had a couple PRs merged, let's wait for a few days to see if anyone wants to take this up. If noone indicates their interest, you can go ahead :)

@Tanmay1201
Copy link
Contributor

Hey @akmadian! Can i work on this?

@akmadian
Copy link
Member Author

go ahead @Tanmay1201! As per our new code contribution guidelines, you don't need to ask for permission to work on an issue, you can just submit a PR. It's best to state that you're working on the issue before starting work, though :)

@dhruvkb dhruvkb added 💻 aspect: code Concerns the software code in the repository 🤖 aspect: dx Concerns developers' experience with the codebase and removed test-coverage labels Oct 25, 2020
@codetheorem
Copy link
Contributor

assign this to me.

@obulat
Copy link
Contributor

obulat commented Nov 2, 2020

assign this to me.

Go ahead!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🤖 aspect: dx Concerns developers' experience with the codebase good first issue New-contributor friendly help wanted Open to participation from the community
Projects
None yet
8 participants