Skip to content

Add unit and e2e tests for the App component #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
akmadian opened this issue Mar 5, 2020 · 7 comments · Fixed by #186
Closed

Add unit and e2e tests for the App component #124

akmadian opened this issue Mar 5, 2020 · 7 comments · Fixed by #186
Labels
💻 aspect: code Concerns the software code in the repository 🤖 aspect: dx Concerns developers' experience with the codebase good first issue New-contributor friendly help wanted Open to participation from the community

Comments

@akmadian
Copy link
Member

akmadian commented Mar 5, 2020

Unit and e2e tests need to be written for the App component. Unit tests are done with Jest, and e2e tests are done with nightwatch.

Please remember to test the following things:

  • That individual parts of the component are present when appropriate. (unit and e2e)
  • That any computed props and methods work properly, if there are any. (unit)
  • Any common interactions between the user and component, if there are any. (e2e)
  • Any other functionality unique to the component being tested!

Additional Context
@akmadian akmadian added help wanted Open to participation from the community good first issue New-contributor friendly test-coverage labels Mar 5, 2020
@akmadian akmadian mentioned this issue Mar 5, 2020
Closed
14 tasks
@achilep
Copy link

achilep commented Mar 14, 2020

hello please i will like to work o this issue

@akmadian
Copy link
Member Author

@achilep go ahead!

@achilep
Copy link

achilep commented Mar 16, 2020

Thank you

@achilep achilep mentioned this issue Mar 16, 2020
Closed
@achilep
Copy link

achilep commented Mar 16, 2020

please can cheek my pr

@JackieBinya
Copy link
Contributor

@akmadian and @obulat
May I contribute to this issue.

@achilep
Copy link

achilep commented Apr 10, 2020

Do you have any suggestions @JackieBinya

@JackieBinya
Copy link
Contributor

JackieBinya commented Apr 10, 2020 •
edited
Loading

Hey @achilep what's the status of this issue, is it closed?
If not, sure I do have ideas.
But please clarify for me.

@akmadian akmadian mentioned this issue Oct 6, 2020
Merged
7 tasks
@dhruvkb dhruvkb added 💻 aspect: code Concerns the software code in the repository 🤖 aspect: dx Concerns developers' experience with the codebase and removed test-coverage labels Oct 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💻 aspect: code Concerns the software code in the repository 🤖 aspect: dx Concerns developers' experience with the codebase good first issue New-contributor friendly help wanted Open to participation from the community
Projects
None yet
Milestone
No milestone
5 participants
@kgodey @dhruvkb @akmadian @achilep @JackieBinya