Skip to content

FirstStep Component unit tests failing #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JackieBinya opened this issue Mar 30, 2020 · 6 comments
Closed

FirstStep Component unit tests failing #148

JackieBinya opened this issue Mar 30, 2020 · 6 comments

Comments

@JackieBinya
Copy link
Contributor

JackieBinya commented Mar 30, 2020

Describe the bug

  • The unit tests for the FirstStep component are failing.
  • e2e tests are missing

To Reproduce

  1. Run tests in the FirstStep.spec.js file by typing the command
    npm run test:unit FirstStep.spec.js
  2. On the terminal, you will get the error message that says that the test suite failed to run as shown in the screenshot below.

Expected behavior

  • All unit tests must pass

Screenshots

Screenshot from 2020-03-30 20-52-56

Desktop (please complete the following information)

  • OS: (ex. iOS) : Ubuntu
  • Browser (ex. chrome, safari): N/A
  • Version (ex. 22):

Smartphone (please complete the following information)

  • Device: (ex. iPhone6): N/A
  • OS: (ex. iOS8.1): N/A
  • Browser (ex. stock browser, safari): N/A
  • Version (ex. 22): 19.10

Additional context

  • N/A
@hemanth-hk
Copy link
Contributor

I see that the FirstStep.vue doesn't have even the e2e tests and the unit tests need to be updated so it would be better if you create an issue for both unit and e2e like all other components and solve this thing here itself. This would be better I believe

Let's see what Ari or other members say about this

@JackieBinya
Copy link
Contributor Author

I hadn't realized that the e2e tests are missing.
Opened a PR already just completed the unit tests PR #149
I guess I would then have to update it and add e2e tests.
Waiting for @akmadian for the go-ahead

@hemanth-hk
Copy link
Contributor

You can always append to that PR

@Tanmay1201
Copy link
Contributor

Tanmay1201 commented Apr 2, 2020

@JackieBinya I see that there is a configuration error. On my machine this test file seems to run fine without displaying any error. Other than this FirstStep.spec.js file should be in the "unit/specs/components" folder which is mentioned in my PR #147 . :)

@JackieBinya
Copy link
Contributor Author

JackieBinya commented Apr 2, 2020

@Tanmay1201 hi
I'm pretty new at this.
Sorry about the delay.
Well I saw that file was misplaced and I identified a bunch of other issues as well, the issue of file configuration and the issue of coverage and the issue of missing e2e tests
I made an attempt to solve all those issues on PR #149
At this point I am not really sure what can be done.
But for interest sake please check out my implementation on my PR

I've checked yours out.

@obulat
Copy link
Contributor

obulat commented Apr 4, 2020

I've moved the FirstStep.spec.js to "unit/specs/components" folder and edited the import to '@/components' to solve this issue, so I am closing it. I will make more comments re: FirstStep tests in the corresponding PRs.

@obulat obulat closed this as completed Apr 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants