Skip to content

Implement Tools for enhancing the code quality and developer experience. #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task done
Cronus1007 opened this issue Jan 9, 2021 · 1 comment
Closed
1 task done
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing feature 🟩 priority: low Low priority and doesn't need to be rushed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work

Comments

@Cronus1007
Copy link
Member

Problem

The chooser repo lacks in various terms. Enlisting a few like

  1. CI/CD integration while formation of a pull request like TravisCI,CircleCI
  2. Codecov tools like Codecov
  3. Dependabot-preview for regulating the dependencies.

Description

The reports formed by ci/cd and codecov tools will lead to better maintenance of the repo in the long run.
Dependabot is a widely accepted practice in majority of the open source organisation. So just a suggestion.
A need for the discussion is a high priority.

Alternatives

Additional context

Implementation

  • I would be interested in implementing this feature.
@Cronus1007 Cronus1007 added ✨ goal: improvement Improvement to an existing feature 💻 aspect: code Concerns the software code in the repository 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work 🟩 priority: low Low priority and doesn't need to be rushed labels Jan 9, 2021
@obulat
Copy link
Contributor

obulat commented Jan 10, 2021

Thank you, @cronus.
The Chooser already has a CI/CD setup through Github actions. You can see it work in this screenshot, where one of the PRs has a red cross next to it, instead of a green tick, due to the failing tests:
image

Code coverage is not checked during the CI process, but we do inspect it when we run tests locally. I do not see the value for a separate tool like Codecov here.

We have previously discussed that the Dependabot has sometimes made false positive/negative PRs in other repos, so we are not going to add it here at this moment.

@obulat obulat closed this as completed Jan 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing feature 🟩 priority: low Low priority and doesn't need to be rushed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work
Projects
None yet
Development

No branches or pull requests

2 participants