Skip to content

Link to work not displayed in HTML attribution code if no work title provided #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task
obulat opened this issue Jan 10, 2021 · 2 comments · Fixed by #298
Closed
1 task

Link to work not displayed in HTML attribution code if no work title provided #297

obulat opened this issue Jan 10, 2021 · 2 comments · Fixed by #298
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix help wanted Open to participation from the community 🟧 priority: high Stalls work on the project or its dependents 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work 🏁 status: ready for work Ready for work

Comments

@obulat
Copy link
Contributor

obulat commented Jan 10, 2021

Description

When the user provides a link to work, but does not provide a title, HTML attribution code in the 'MARK YOUR WORK' should add a link with href of the user-provided link, and text of 'This work'. Because there is no title, there should not be the property="dct:title" attribute:

<a rel="cc:attributionURL" href="http://www.example.com/picture.jpg">This work</a>

Instead, now no link is added even if the user provides a URL to their work:
This work

Reproduction

  1. Select any license and get to the last step, Attribution details form.
  2. Fill in only the 'Link to work' field with a URL.
  3. Select 'HTML' tab in the 'MARK YOUR WORK' section.
  4. See error: The code has only This work

Expectation

HTML code should have <a rel="cc:attributionURL" href="http://www.example.com/picture.jpg">This work</a> in it.

Resolution

  • I would be interested in resolving this bug.
@obulat obulat added help wanted Open to participation from the community 🟧 priority: high Stalls work on the project or its dependents 🏁 status: ready for work Ready for work 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository labels Jan 10, 2021
@rohan-goel
Copy link
Contributor

Can I work on this issue?

@obulat
Copy link
Contributor Author

obulat commented Jan 10, 2021

Sure, @rohan-goel , go ahead!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix help wanted Open to participation from the community 🟧 priority: high Stalls work on the project or its dependents 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work 🏁 status: ready for work Ready for work
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants