Skip to content

Add step to determine appropriateness of CC licenses #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zackkrida opened this issue Feb 4, 2021 · 9 comments · Fixed by #315
Closed

Add step to determine appropriateness of CC licenses #314

zackkrida opened this issue Feb 4, 2021 · 9 comments · Fixed by #315
Labels
💻 aspect: code Concerns the software code in the repository 🕹 aspect: interface Concerns end-users' experience with the software 🌟 goal: addition Addition of new feature 🟧 priority: high Stalls work on the project or its dependents 🏁 status: ready for work Ready for work

Comments

@zackkrida
Copy link
Member

Description

Users who aren't familiar with Creative Commons licenses might not know if the licenses are actually appropriate for their work and use case. We would like to add a step to the chooser that lets the user confirm a CC license is the right fit.

This issue will be updated with the exact copy, but in the meantime a draft pull request may be created that adds a 'generic' new second step to the chooser flow, that can be filled in with the appropriate content when ready.

@zackkrida zackkrida added 🟧 priority: high Stalls work on the project or its dependents 🌟 goal: addition Addition of new feature 💻 aspect: code Concerns the software code in the repository 🕹 aspect: interface Concerns end-users' experience with the software labels Feb 4, 2021
@neeraj-2
Copy link
Contributor

neeraj-2 commented Feb 4, 2021

I would like to work on it. Can I?

@zackkrida
Copy link
Member Author

Sure @neeraj-2! Thanks.

@cc-open-source-bot cc-open-source-bot added 🏷 status: label work required Needs proper labelling before it can be worked on and removed 🏷 status: label work required Needs proper labelling before it can be worked on labels Feb 5, 2021
@zackkrida
Copy link
Member Author

Hey @neeraj-2 will you be actively working on this this week? Just curious. Thank you!

@neeraj-2
Copy link
Contributor

neeraj-2 commented Feb 8, 2021

Hey @neeraj-2 will you be actively working on this this week? Just curious. Thank you!

Yes, @zackkrida. I am actively working on this one right now. (What I did in last some days) was just doing some background research to have a start on this issue. Explored the 7 CC licenses and their details and looking at our chooser website to get through what details already exist and what I should add-in. And now want your guidance so that I can understand from where I should exactly start 😊.

@neeraj-2
Copy link
Contributor

neeraj-2 commented Feb 8, 2021

Should I propose some interface/design on Figma? Or something like that to have a start with this issue?

@zackkrida
Copy link
Member Author

It shouldn't require any design work; we need a new step added to the stepper (a new step 2) so the current step 2 becomes step 3. If they choose "no, i need help" it will go to the new step, otherwise it will still skip multiple steps the same way it currently works.

You can just use lorem ipsum / placeholder text for the new step.

2021-02-08-137

@neeraj-2
Copy link
Contributor

neeraj-2 commented Feb 8, 2021

Thanks, @zackkrida for the details. I Will create a Draft PR soon.

@obulat
Copy link
Contributor

obulat commented Feb 8, 2021

Will this step have radio inputs, just like the first step? If so, we could add another step object to the list of step objects:

export const initialSteps = [
{ id: 0, name: 'FS', visible: true, enabled: true, status: 'active', selected: undefined },
{ id: 1, name: 'BY', visible: true, enabled: true, status: 'inactive', selected: undefined },
{ id: 2, name: 'NC', visible: true, enabled: true, status: 'inactive', selected: undefined },
{ id: 3, name: 'ND', visible: true, enabled: true, status: 'inactive', selected: undefined },
{ id: 4, name: 'SA', visible: true, enabled: true, status: 'inactive', selected: undefined },
{ id: 5, name: 'DD', visible: false, enabled: true, status: 'inactive', selected: undefined },
{ id: 6, name: 'CW', visible: false, enabled: true, status: 'inactive', selected: undefined },
{ id: 7, name: 'AD', visible: true, enabled: true, status: 'inactive', selected: undefined }
]

and use the ChooserStep component for it. Here is where the selection of components for a step object is done:
stepActionComponent({ name }) {
switch (name) {
case 'CW': return CopyrightWaiverStep
case 'DD': return DropdownStep
case 'AD': return AttributionDetailsStep
default: return ChooserStep

@neeraj-2
Copy link
Contributor

neeraj-2 commented Feb 12, 2021

Have just created a draft PR. But some work is still required. So, I am on it and will try to complete it by this week and will request a review after that. Thanks, @zackkrida, and @obulat.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🕹 aspect: interface Concerns end-users' experience with the software 🌟 goal: addition Addition of new feature 🟧 priority: high Stalls work on the project or its dependents 🏁 status: ready for work Ready for work
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants