Skip to content

Add integration test for Mark Your Work section and its interaction with Stepper and Attribution Details Step #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task
obulat opened this issue Feb 15, 2021 · 6 comments · Fixed by #322
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing feature 🟩 priority: low Low priority and doesn't need to be rushed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work

Comments

@obulat
Copy link
Contributor

obulat commented Feb 15, 2021

Problem

'Mark Your Work' section shows the license code for attribution purposes, in rich text, plain text, or HTML format. It is updated automatically any time the license or attribution information (Creator name, etc.) is changed. The interaction of the 'Mark Your Work' section needs to be tested using Cypress tests.

Description

This is the list of scenarios that need to be tested:

Mark Your Work section appears and is hidden at the correct moments

  • The 'Mark Your Work' section should be invisible at the beginning
  • It should appear when the user selects a license from the dropdown and clicks Next
  • It should disappear when the user clicks Back.
  • When the user clicks back again, and then uses the steps (i.e. clicking I need help on the first step) to choose the license, the 'Mark Your Work' section should appear again when the last step is selected.

Mark Your Work section correctly shows the license in the correct format:

  • When the user selects 'CC BY', the license is shown correctly in all tabs
  • When the user changes attribution type, the license changes from Short to Full, accordingly

Attribution details are updated correctly:

  • When the user adds information in the attribution details, the license code is updated accordingly

The license code can be copied to the clipboard:

  • When the user clicks on 'Copy', the button text changes to 'Copied', and the clipboard contains the license text.

Implementation

  • I would be interested in implementing this feature.
@obulat obulat added 🟩 priority: low Low priority and doesn't need to be rushed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work ✨ goal: improvement Improvement to an existing feature 💻 aspect: code Concerns the software code in the repository labels Feb 15, 2021
@obulat obulat mentioned this issue Feb 15, 2021
1 task
@Cronus1007
Copy link
Member

@obulat I would like to implement this issue.

@obulat
Copy link
Contributor Author

obulat commented Feb 15, 2021

Sure, @Cronus1007 , go ahead!

@Cronus1007
Copy link
Member

Cronus1007 commented Feb 19, 2021

When the user changes attribution type, the license changes from Short to Full, accordingly

@obulat Enhance this point of yours.Unable to predict anything from this. Does it mean CC By converts into CC0

@zackkrida
Copy link
Member

@Cronus1007 Olga is talking about testing this toggle:

2021-02-19-149

2021-02-19-148

@Cronus1007
Copy link
Member

@zackkrida One more doubt related to the Attribution Steps.What to type in Link of Work and Link to Creator Profile. Also I have to check working of these links.
Screenshot from 2021-02-20 09-25-16

@zackkrida
Copy link
Member

@Cronus1007 good questions. you don't need to test if the links work, or even if they're valid urls, those are implementation details best left to the user.

You can use https://creativecommons.org as the url for both in your tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing feature 🟩 priority: low Low priority and doesn't need to be rushed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work
Projects
None yet
3 participants