Skip to content

Upgrade Cypress to latest #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task done
Cronus1007 opened this issue Mar 10, 2023 · 5 comments · Fixed by #470
Closed
1 task done

Upgrade Cypress to latest #460

Cronus1007 opened this issue Mar 10, 2023 · 5 comments · Fixed by #470
Assignees
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟩 priority: low Low priority and doesn't need to be rushed 🔒 staff only Restricted to CC staff members 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work 💬 talk: discussion Open for discussions and feedback

Comments

@Cronus1007
Copy link
Member

Description

Right now the version of Cypress used for the E2E testing is v6 while the latest version of cypress is v12. I believe that the Cypress testing should be upgraded since several new features have been implemented especially for Vue.js especially in the version 10.

Important Links

Migration Guide for Cypress

Resolution

  • I would be interested in resolving this bug.

@possumbilities Would like to know your opinion about it?

@Cronus1007 Cronus1007 added 🟧 priority: high Stalls work on the project or its dependents 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository 🔒 staff only Restricted to CC staff members 💬 talk: discussion Open for discussions and feedback 🟩 priority: low Low priority and doesn't need to be rushed and removed 🟧 priority: high Stalls work on the project or its dependents labels Mar 10, 2023
@possumbilities
Copy link
Contributor

@Cronus1007 My first major concern would be if newer Cypress is going to be compatible with the older version of Vue that's running in the chooser and its related dependencies and whether it makes more sense to do this upgrade after the Vue3 upgrade?

Thoughts?

@Cronus1007
Copy link
Member Author

Cronus1007 commented Mar 17, 2023

@possumbilities In Chooser we are using cypress as a frontend tool so it hadn't much to do with the framework used or the version of the framework used.
The main reason I am proposing it is the reason of a new feature called initSpecRoutine since the version which we are using right now doesn't have a great support for before, beforeAll, after and afterAll functionsfunctions as compared to that of the older version. Additionally we can test the application on Firefox browser as well so such reasons are prime reason why I would like to have an upgrade.

@possumbilities
Copy link
Contributor

possumbilities commented Mar 20, 2023

@Cronus1007 I'm fine with this if there's data to support (even just testing it) that it won't break. My concern was node version conflicts between technologies.

@Cronus1007
Copy link
Member Author

@possumbilities I dont have any data to support it. One thing which we can do is by just testing it out whether cypressv12 is going to be compatible with nodev14. And then you can test it on your local enviornment. In my opinion it will be we just need to tweak code a little bit i.e. introduce the hooks like before, beforeAll, after and afterAll statements.

@Cronus1007
Copy link
Member Author

@possumbilities Nothing is breaking as of now in PR #470 . I just made the required shifts of the files.Could you please have a local run of the new scripts of the branch issue-460. Upgrading Cypress tov12 was supported by nodev14.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟩 priority: low Low priority and doesn't need to be rushed 🔒 staff only Restricted to CC staff members 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work 💬 talk: discussion Open for discussions and feedback
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants