Skip to content

Add list of websites that use creativecommons-base as their base theme #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
brylie opened this issue Jun 28, 2021 · 10 comments · Fixed by #78
Open

Add list of websites that use creativecommons-base as their base theme #77

brylie opened this issue Jun 28, 2021 · 10 comments · Fixed by #78
Assignees
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing feature 🟩 priority: low Low priority and doesn't need to be rushed 🧹 status: ticket work required Needs more details before it can be worked on

Comments

@brylie
Copy link
Contributor

brylie commented Jun 28, 2021

Problem

We don't currently have a list of CC websites that use creativecommons-base as a base theme.

Description

Add a list of all CC websites that use creativecommons-base as a base theme to the project README

WIP table

The following table shows Creative Commons WordPress projects and indicates whether the theme inherits from creativecommons-base. The table will be used as the basis for the final list of projects inheriting from creativecommons-base and includes negative cases for thoroughness.

The following themes inherit from creativecommons-base:

Project is child-them not child-theme
certificate ✔️
commoners ✔️
new-creativecommons.org ✔️
open4us.org ✔️
openpolicynetwork.org ✔️
sotc-2016-wordpress ✔️
wp-theme-cc-chapter ✔️
wp-theme-cc-commoners ✔️
wp-theme-cctoolkit ✔️
wp-theme-openglam ✔️
wp-theme-summit ✔️
wp-theme-creativecommons.org ✔️

Additional context

This is related to the possibility of deprecating Queulat (#69), on which this base theme depends.

@brylie brylie added 🟩 priority: low Low priority and doesn't need to be rushed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work ✨ goal: improvement Improvement to an existing feature 💻 aspect: code Concerns the software code in the repository labels Jun 28, 2021
@brylie brylie self-assigned this Jun 28, 2021
@brylie
Copy link
Contributor Author

brylie commented Jun 29, 2021

@TimidRobot on initial audit, it seems that only certificate and wp-theme-creativecommons.org inherit from creativecommons-base. Would you and perhaps @hugosolar mind peer-reviewing the table above to make sure I didn't make any mistakes or overlook any projects that might inherit from creativecommons-base?

@brylie
Copy link
Contributor Author

brylie commented Jun 30, 2021

The table above may be missing some information. For example, when logged in to the Global Summit website and viewing the Theme settings, it says the Global Summit theme inherits from creativecommons-base:

image

So, I'm trying to figure out

  • where is the source code for the Global Summit child theme
  • whether the wp-theme-summit is the correct source for the current summit theme

@brylie
Copy link
Contributor Author

brylie commented Jun 30, 2021

Re-opening issue since it is still under investigation.

@brylie brylie reopened this Jun 30, 2021
@hugosolar
Copy link
Contributor

@brylie the sites currently using the creativecommons-base are

  • New certificate website
  • new version creativecommons.org (still on staging?)
  • Summit
  • New Global network

@brylie
Copy link
Contributor Author

brylie commented Jun 30, 2021

Thanks, @hugosolar! I'll update the list and README. For reference, how can I quickly determine when these sites inherit from creativecommons-base? E.g. for cases where there isn't a composer.json.

@hugosolar
Copy link
Contributor

there isn't a composer.json but that would be a great idea to add or maybe there's a better approach to handle this like considering adding the whole wp-content in the repository and manage the dependencies (plugins and themes) with a composer.json in the root of the folder, that's the way it's managed in the WordPress VIP platform and it works very well

@brylie
Copy link
Contributor Author

brylie commented Jun 30, 2021

OK, I just read in the WordPress Child Themes documentation that it is required for child themes to define their base template in style.css. So, I'll look for examples of creativecommons-base in the style.css for our other WordPress themes.

https://github.com/creativecommons/wp-theme-summit/blob/d02892426d2f89c0561c9d87acd44783468a6795/style.css#L7

@brylie
Copy link
Contributor Author

brylie commented Jun 30, 2021

adding the whole wp-content in the repository and manage the dependencies (plugins and themes) with a composer.json in the root of the folder, that's the way it's managed in the WordPress VIP platform and it works very well

That sounds like an interesting way to manage WordPress projects. Themes and plugins probably don't need that level of orchestration.

@hugosolar
Copy link
Contributor

hugosolar commented Jun 30, 2021

adding the whole wp-content in the repository and manage the dependencies (plugins and themes) with a composer.json in the root of the folder, that's the way it's managed in the WordPress VIP platform and it works very well

That sounds like an interesting way to manage WordPress projects. Themes and plugins probably don't need that level of orchestration.

agreed

OK, I just read in the WordPress Child Themes documentation that it is required for child themes to define their base template in style.css. So, I'll look for examples of creativecommons-base in the style.css for our other WordPress themes.

https://github.com/creativecommons/wp-theme-summit/blob/d02892426d2f89c0561c9d87acd44783468a6795/style.css#L7

And yes! I think that's the only way for now to determine a theme is a child from creativecommons-base

@brylie
Copy link
Contributor Author

brylie commented Jun 30, 2021

Thanks for your help @hugosolar 😃

@TimidRobot TimidRobot moved this to Triage in possumbilities Sep 10, 2024
@possumbilities possumbilities added 🧹 status: ticket work required Needs more details before it can be worked on and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Sep 18, 2024
@possumbilities possumbilities moved this from Triage to Backlog in possumbilities Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing feature 🟩 priority: low Low priority and doesn't need to be rushed 🧹 status: ticket work required Needs more details before it can be worked on
Projects
Status: Backlog
Development

Successfully merging a pull request may close this issue.

3 participants