Skip to content

add_cc4_links.py is unreliable and inconsistent #1063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TimidRobot opened this issue Jan 2, 2020 · 0 comments · Fixed by #1072
Closed

add_cc4_links.py is unreliable and inconsistent #1063

TimidRobot opened this issue Jan 2, 2020 · 0 comments · Fixed by #1072
Assignees

Comments

@TimidRobot
Copy link
Member

Describe the bug

add_cc4_links.py (current version 564146d as of 2020-01-02) is unreliable and inconsistent. It appends a link for the language specified in the command line argument. This means that the languages are ordered arbitrarily and if a translation branch is created before another translation branch is merged, it won't have the link for that language.

Expected behavior

The script should remove all language links and replace it with the current list (sorted). Ideally, one per line to make diffs easier to read.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant