Skip to content

Modify height & width of SVGs used #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 task done
rajat2502 opened this issue Oct 8, 2020 · 3 comments · Fixed by #9
Closed
1 task done

Modify height & width of SVGs used #5

rajat2502 opened this issue Oct 8, 2020 · 3 comments · Fixed by #9
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing feature 🟩 priority: low Low priority and doesn't need to be rushed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work

Comments

@rajat2502
Copy link
Contributor

Problem

The width & height of the images/logos should be allowed to modify.

Description

A feature to modify the width and height of the images that are used in the og-image. This will help in fixing the overflow problem of the images.
image

Implementation

  • I would be interested in implementing this feature.
@rajat2502 rajat2502 added ✨ goal: improvement Improvement to an existing feature 💻 aspect: code Concerns the software code in the repository 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work 🟩 priority: low Low priority and doesn't need to be rushed labels Oct 8, 2020
@rajat2502
Copy link
Contributor Author

I think this one is already implemented. I will close this one.

@zackkrida zackkrida reopened this Oct 8, 2020
@zackkrida
Copy link
Member

@rajat2502 One thing that would be good is forcing a max-width: 100% on the logos, so they can't overlap like in this screenshot.

@rajat2502
Copy link
Contributor Author

Yeah, that would fix the issue. I will make a PR for the same.

@rajat2502 rajat2502 mentioned this issue Oct 8, 2020
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing feature 🟩 priority: low Low priority and doesn't need to be rushed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add max-width to logo rajat2502/og-image-generator
2 participants
@zackkrida @rajat2502