Skip to content

[Feature] Add Thingiverse as an External Source #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task done
dullbenz opened this issue Oct 14, 2022 · 5 comments · Fixed by #102
Closed
1 task done

[Feature] Add Thingiverse as an External Source #94

dullbenz opened this issue Oct 14, 2022 · 5 comments · Fixed by #102
Assignees
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing feature 🟩 priority: low Low priority and doesn't need to be rushed 🏁 status: ready for work Ready for work

Comments

@dullbenz
Copy link
Contributor

Problem

The goal is to add a good number of external sources to give users a variety of results from different sources.

Description

In particular, Thingiverse is one such external source with free 3D design models that can be downloaded and used.
Adding Thingiverse as an external source to CC search will be a good addition and will benefit our users.

image

Implementation

  • I would be interested in implementing this feature.
@dullbenz dullbenz added ✨ goal: improvement Improvement to an existing feature 💻 aspect: code Concerns the software code in the repository 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work 🟩 priority: low Low priority and doesn't need to be rushed labels Oct 14, 2022
@possumbilities possumbilities added 🏁 status: ready for work Ready for work and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Oct 14, 2022
@dullbenz
Copy link
Contributor Author

What caption text should we use to describe the content for Thingiverse. The site contains various 3D model designs.
Was thinking of using "Image" or "MODEL_3D" or "3D Model"

@PreciousOritsedere
Copy link
Contributor

3D models sounds good

@dikehprosper
Copy link
Contributor

“3D Model” is okay

@dullbenz
Copy link
Contributor Author

I've run into a little issue with this task.

In effect, the problem is that in order to apply the "commercial purposes" and "modify, adapt ..." filters as indicated by the checkboxes in the picture below, I browsed the Thingiverse site and discovered that applying the "customizable" filter corresponds to "modify, adapt, ... " for CC search.

image

The problem is that, in order to implement "commercial purposes" filter for CC search, I thought about leveraging the license filters on Thingiverse, but selecting any of the licenses simply displays "NO Results" yet I actually verified and could see that there are items with these licenses.

@dullbenz
Copy link
Contributor Author

dullbenz commented Oct 15, 2022

I used the search param "&license=cc" (which on Thingiverse stands for the CC Attribution Licence) as the equivalent to the "use for commercial purposes" filter on "CC search".

Note that as I indicated in the previous comment, for now, the license filters on Thingiverse don't work and always return 0 results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing feature 🟩 priority: low Low priority and doesn't need to be rushed 🏁 status: ready for work Ready for work
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants