Skip to content

Commit 2360af2

Browse files
committed
Menu: make the hasScroll method private
1 parent b1e4aa9 commit 2360af2

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

ui/jquery.ui.menu.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ $.widget("ui.menu", {
118118

119119
activate: function( event, item ) {
120120
this.deactivate();
121-
if (this.hasScroll()) {
121+
if (this._hasScroll()) {
122122
var offset = item.offset().top - this.element.offset().top,
123123
scroll = this.element.attr("scrollTop"),
124124
elementHeight = this.element.height();
@@ -177,7 +177,7 @@ $.widget("ui.menu", {
177177

178178
// TODO merge with previousPage
179179
nextPage: function(event) {
180-
if (this.hasScroll()) {
180+
if (this._hasScroll()) {
181181
// TODO merge with no-scroll-else
182182
if (!this.active || this.last()) {
183183
this.activate(event, this.element.children(":first"));
@@ -203,7 +203,7 @@ $.widget("ui.menu", {
203203

204204
// TODO merge with nextPage
205205
previousPage: function(event) {
206-
if (this.hasScroll()) {
206+
if (this._hasScroll()) {
207207
// TODO merge with no-scroll-else
208208
if (!this.active || this.first()) {
209209
this.activate(event, this.element.children(":last"));
@@ -228,7 +228,7 @@ $.widget("ui.menu", {
228228
}
229229
},
230230

231-
hasScroll: function() {
231+
_hasScroll: function() {
232232
return this.element.height() < this.element.attr("scrollHeight");
233233
},
234234

0 commit comments

Comments
 (0)