-
Notifications
You must be signed in to change notification settings - Fork 47
PostCSS Plugins not work #65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
same problem here! in version 0.13.0 works. Tested with my async postcss plugin I think that the commit f9a2ea2 broke the loader of postcss plugin. |
revert / reimplement ? |
Oh, you're right about that commit breaking it sorry - looks like we're now creating the Will submit a patch today, is anyone able to help with writing a test case along the lines of "extra postcss plugins are applied"? |
@tinchoz49 / @justgook can you please check #67 to see whether this fixes the issue in your case? |
hi @joshwnj ! with your change the postcss plugins like autoprefixer works great 👍 , but it seems that the async plugins not. I made an example of one async plugin and the process of css-modulesify never finish. function asyncPlugin() {
return postcss.plugin('async-plugin', function (opts) {
return function (css, result) {
return new Promise(function (resolve, reject) {
setTimeout(function () {
resolve();
}, 2000);
});
};
});
}
var bundler = browserify({
entries: [sourceFile]
})
.plugin(watchify)
.plugin(cssModulesify, {
rootDir: __dirname,
output: path.join(destFolder, cssDestFile),
postcssAfter: [
autoprefixer,
asyncPlugin
]
}); |
if you want i can upload tomorrow my example repository where i'm testing this things ;) Because my idea is to show how you can use css-modulesify with my |
Thanks @tinchoz49 - an example repo would be great. I think if #67 solves part of the issue I'll go ahead and merge it tomorrow, and we can create a new issue for async plugins.
|
+1 |
@tinchoz49 I've created #68 to track a solution to the issue you mentioned with async plugins |
i have add
postbuild
script to mimify/autoprefix my cssbased on README there is possibility add those plugins in "--after" argument - but looks like it don't work
or maybe im doing something wrong?
https://github.com/justgook/sokoban-react
The text was updated successfully, but these errors were encountered: