Skip to content

Commit 013a1b4

Browse files
committed
cleanup style and class name of ArticleDetail
1 parent d2377bd commit 013a1b4

5 files changed

Lines changed: 298 additions & 620 deletions

File tree

browser/components/ModeSelect.js

Lines changed: 10 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -37,27 +37,9 @@ export default class ModeSelect extends React.Component {
3737
}
3838

3939
handleIdleSelectClick (e) {
40-
this.setState({mode: EDIT_MODE})
41-
}
42-
43-
componentDidUpdate (prevProps, prevState) {
44-
if (prevState.mode !== this.state.mode && this.state.mode === EDIT_MODE) {
45-
let searchElement = ReactDOM.findDOMNode(this.refs.search)
46-
searchElement.focus()
47-
if (this.searchKeyDownListener == null) {
48-
this.searchKeyDownListener = e => this.handleSearchKeyDown
49-
}
50-
searchElement.addEventListener('keydown', this.searchKeyDownListener)
51-
}
52-
}
53-
54-
componentWillUpdate (nextProps, nextState) {
55-
if (nextProps.mode !== this.state.mode && nextState.mode === IDLE_MODE) {
56-
let searchElement = ReactDOM.findDOMNode(this.refs.search)
57-
if (searchElement != null && this.searchKeyDownListener != null) {
58-
searchElement.removeEventListener('keydown', this.searchKeyDownListener)
59-
}
60-
}
40+
this.setState({mode: EDIT_MODE, search: this.props.value}, () => {
41+
ReactDOM.findDOMNode(this.refs.search).select()
42+
})
6143
}
6244

6345
handleModeOptionClick (modeName) {
@@ -82,9 +64,9 @@ export default class ModeSelect extends React.Component {
8264
case 40:
8365
e.preventDefault()
8466
{
67+
let search = _.escapeRegExp(this.state.search)
8568
let filteredModes = modes
8669
.filter(mode => {
87-
let search = this.state.search
8870
let nameMatched = mode.name.match(search)
8971
let aliasMatched = _.some(mode.alias, alias => alias.match(search))
9072
return nameMatched || aliasMatched
@@ -97,9 +79,9 @@ export default class ModeSelect extends React.Component {
9779
case 13:
9880
e.preventDefault()
9981
{
82+
let search = _.escapeRegExp(this.state.search)
10083
let filteredModes = modes
10184
.filter(mode => {
102-
let search = this.state.search
10385
let nameMatched = mode.name.match(search)
10486
let aliasMatched = _.some(mode.alias, alias => alias.match(search))
10587
return nameMatched || aliasMatched
@@ -148,33 +130,31 @@ export default class ModeSelect extends React.Component {
148130
if (this.state.mode === IDLE_MODE) {
149131
let mode = _.findWhere(modes, {name: this.props.value})
150132
let modeName = mode != null ? mode.name : 'text'
151-
let modeLabel = mode != null ? mode.label : 'Plain text'
152133

153134
return (
154135
<div className={className + ' idle'} onClick={e => this.handleIdleSelectClick(e)}>
155136
<ModeIcon mode={modeName}/>
156-
<span className='modeLabel'>{modeLabel}</span>
157137
</div>
158138
)
159139
}
160140

141+
let search = _.escapeRegExp(this.state.search)
161142
let filteredOptions = modes
162143
.filter(mode => {
163-
let search = this.state.search
164-
let nameMatched = mode.name.match(_.escapeRegExp(search))
165-
let aliasMatched = _.some(mode.alias, alias => alias.match(_.escapeRegExp(search)))
144+
let nameMatched = mode.name.match(search)
145+
let aliasMatched = _.some(mode.alias, alias => alias.match(search))
166146
return nameMatched || aliasMatched
167147
})
168148
.map((mode, index) => {
169149
return (
170-
<div key={mode.name} className={index === this.state.focusIndex ? 'option active' : 'option'} onClick={e => this.handleModeOptionClick(mode.name)(e)}><ModeIcon mode={mode.name}/>{mode.label}</div>
150+
<div key={mode.name} className={index === this.state.focusIndex ? 'ModeSelect-options-item active' : 'ModeSelect-options-item'} onClick={e => this.handleModeOptionClick(mode.name)(e)}><ModeIcon mode={mode.name}/>{mode.label}</div>
171151
)
172152
})
173153

174154
return (
175155
<div className={className + ' edit'}>
176156
<input onKeyDown={e => this.handleSearchKeyDown(e)} ref='search' onChange={e => this.handleSearchChange(e)} value={this.state.search} type='text'/>
177-
<div ref='options' className='modeOptions hide'>
157+
<div ref='options' className='ModeSelect-options hide'>
178158
{filteredOptions}
179159
</div>
180160
</div>

browser/components/TagSelect.js

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -117,10 +117,10 @@ export default class TagSelect extends React.Component {
117117

118118
let tagElements = _.isArray(tags)
119119
? this.props.tags.map(tag => (
120-
<span key={tag} className='tagItem'>
121-
<button onClick={e => this.handleItemRemoveButton(tag)(e)} className='tagRemoveBtn'><i className='fa fa-fw fa-times'/></button>
122-
<span className='tagLabel'>{tag}</span>
123-
</span>))
120+
<div key={tag} className='TagSelect-tags-item'>
121+
<button onClick={e => this.handleItemRemoveButton(tag)(e)} className='TagSelect-tags-item-remove'><i className='fa fa-fw fa-times'/></button>
122+
<div className='TagSelect-tags-item-label'>{tag}</div>
123+
</div>))
124124
: null
125125

126126
let suggestElements = this.shouldShowSuggest() ? suggestTags
@@ -134,21 +134,21 @@ export default class TagSelect extends React.Component {
134134

135135
return (
136136
<div className='TagSelect' onClick={e => this.handleThisClick(e)}>
137-
<div className='tags'>
137+
<div className='TagSelect-tags'>
138138
{tagElements}
139139
<input
140140
type='text'
141141
onKeyDown={e => this.handleKeyDown(e)}
142142
ref='tagInput'
143143
valueLink={this.linkState('input')}
144144
placeholder='Click here to add tags'
145-
className='tagInput'
145+
className='TagSelect-input'
146146
onFocus={e => this.handleInputFocus(e)}
147147
/>
148148
</div>
149149
{suggestElements != null && suggestElements.length > 0
150150
? (
151-
<div ref='suggestTags' className='suggestTags'>
151+
<div ref='suggestTags' className='TagSelect-suggest'>
152152
{suggestElements}
153153
</div>
154154
)

browser/main/HomePage/ArticleDetail/ShareButton.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ export default class ShareButton extends React.Component {
111111
)
112112
}
113113
</button>
114-
<div ref='dropdown' className={'share-dropdown' + (this.state.openDropdown ? '' : ' hide')}>
114+
<div ref='dropdown' className={'ShareButton-dropdown' + (this.state.openDropdown ? '' : ' hide')}>
115115
{
116116
!hasPublicURL ? (
117117
<button

0 commit comments

Comments
 (0)