clean code

Author: Rokt33r

browser/lib/modal.js

@@ -22,7 +22,7 @@ class ModalBase extends React.Component {
   render () {
     return (
       <div className={'ModalBase' + (this.state.isHidden ? ' hide' : '')}>
-        <div onClick={e => this.close(e)} className='modalBack'/>
+        <div onClick={(e) => this.close(e)} className='modalBack'/>
         {this.state.component == null ? null : (
           <this.state.component {...this.state.componentProps} close={this.close}/>
         )}

browser/main/HomePage/ArticleDetail/index.js

@@ -2,10 +2,6 @@ import React, { PropTypes } from 'react'
 import ReactDOM from 'react-dom'
 import moment from 'moment'
 import _ from 'lodash'
-import {
-  switchFolder,
-  updateArticle
-} from '../../actions'
 import linkState from 'browser/lib/linkState'
 import TagSelect from 'browser/components/TagSelect'
 import ModeSelect from 'browser/components/ModeSelect'
@@ -67,25 +63,25 @@ export default class ArticleDetail extends React.Component {
   constructor (props) {
     super(props)
 
-    this.deleteHandler = e => {
+    this.deleteHandler = (e) => {
       if (isModalOpen()) return true
       this.handleDeleteButtonClick()
     }
-    this.uncacheHandler = e => {
+    this.uncacheHandler = (e) => {
       if (isModalOpen()) return true
       this.handleUncache()
     }
-    this.titleHandler = e => {
+    this.titleHandler = (e) => {
       if (isModalOpen()) return true
       if (this.refs.title) {
         this.focusTitle()
       }
     }
-    this.editHandler = e => {
+    this.editHandler = (e) => {
       if (isModalOpen()) return true
       if (this.refs.editor) this.refs.editor.switchEditMode()
     }
-    this.previewHandler = e => {
+    this.previewHandler = (e) => {
       if (isModalOpen()) return true
       if (this.refs.editor) this.refs.editor.switchPreviewMode()
     }
@@ -100,7 +96,7 @@ export default class ArticleDetail extends React.Component {
 
   componentDidMount () {
     this.refreshTimer = setInterval(() => this.forceUpdate(), 60 * 1000)
-    this.shareDropdownInterceptor = e => {
+    this.shareDropdownInterceptor = (e) => {
       e.stopPropagation()
     }
 
@@ -159,12 +155,12 @@ export default class ArticleDetail extends React.Component {
       updatedAt: new Date()
     })
 
-    dispatch(updateArticle(article))
+    // dispatch(updateArticle(article))
 
     let targetFolderKey = e.target.value
     if (status.targetFolders.length > 0) {
       let targetFolder = _.findWhere(folders, {key: targetFolderKey})
-      dispatch(switchFolder(targetFolder.name))
+      // dispatch(switchFolder(targetFolder.name))
     }
   }
 
@@ -174,7 +170,7 @@ export default class ArticleDetail extends React.Component {
       title: e.target.value,
       updatedAt: new Date()
     })
-    dispatch(updateArticle(article))
+    // dispatch(updateArticle(article))
   }
 
   handleTagsChange (newTag, tags) {
@@ -184,7 +180,7 @@ export default class ArticleDetail extends React.Component {
       updatedAt: new Date()
     })
 
-    dispatch(updateArticle(article))
+    // dispatch(updateArticle(article))
   }
 
   handleModeChange (value) {
@@ -194,7 +190,7 @@ export default class ArticleDetail extends React.Component {
       updatedAt: new Date()
     })
 
-    dispatch(updateArticle(article))
+    // dispatch(updateArticle(article))
     this.switchEditMode()
   }
 
@@ -206,7 +202,7 @@ export default class ArticleDetail extends React.Component {
         updatedAt: new Date()
       })
 
-      dispatch(updateArticle(article))
+      // dispatch(updateArticle(article))
     }
   }
 
@@ -254,7 +250,7 @@ export default class ArticleDetail extends React.Component {
   render () {
     let { folders, status, tags, activeArticle, modified, user } = this.props
     if (activeArticle == null) return this.renderEmpty()
-    let folderOptions = folders.map(folder => {
+    let folderOptions = folders.map((folder) => {
       return (
         <option key={folder.key} value={folder.key}>{folder.name}</option>
       )
@@ -269,7 +265,7 @@ export default class ArticleDetail extends React.Component {
             <select
               className='ArticleDetail-info-folder'
               value={activeArticle.FolderKey}
-              onChange={e => this.handleFolderKeyChange(e)}
+              onChange={(e) => this.handleFolderKeyChange(e)}
             >
               {folderOptions}
             </select>
@@ -282,25 +278,14 @@ export default class ArticleDetail extends React.Component {
             />
 
             <div className='ArticleDetail-info-control'>
-              {/*<div className={'ArticleDetail-info-control-save' + (!isUnsaved ? ' hide' : '')}>
-                <button
-                  onClick={e => this.handleSaveButtonClick(e)}
-                  className='ArticleDetail-info-control-save-button'
-                  disabled={!isUnsaved}
-                  >
-                  <i className='fa fa-fw fa-save'/>&nbsp;Save
-                  <span className='tooltip' children={`Save Post (${OSX ? '⌘' : '^'} + S)`}/>
-                </button>
-              </div>*/}
-
               <ShareButton
                 article={activeArticle}
                 user={user}
                 />
 
-              <button className='ArticleDetail-info-control-delete-button' onClick={e => this.handleOthersButtonClick(e)}>
+              <button className='ArticleDetail-info-control-delete-button' onClick={(e) => this.handleOthersButtonClick(e)}>
                 <i className='fa fa-fw fa-trash'/>
-                <span className='tooltip' children={`Delete Post (^ + Del)`}/>
+                <span className='tooltip'>Delete Post (^ + Del)</span>
               </button>
             </div>
           </div>
@@ -319,20 +304,20 @@ export default class ArticleDetail extends React.Component {
           <div className='ArticleDetail-panel-header'>
             <div className='ArticleDetail-panel-header-title'>
               <input
-                onKeyDown={e => this.handleTitleKeyDown(e)}
+                onKeyDown={(e) => this.handleTitleKeyDown(e)}
                 placeholder='(Untitled)'
                 ref='title'
                 value={activeArticle.title}
-                onChange={e => this.handleTitleChange(e)}
+                onChange={(e) => this.handleTitleChange(e)}
                 style={{
                   fontFamily: this.state.fontFamily
                 }}
               />
             </div>
             <ModeSelect
               ref='mode'
-              onChange={e => this.handleModeChange(e)}
-              onKeyDown={e => this.handleModeSelectKeyDown(e)}
+              onChange={(e) => this.handleModeChange(e)}
+              onKeyDown={(e) => this.handleModeSelectKeyDown(e)}
               value={activeArticle.mode}
               className='ArticleDetail-panel-header-mode'
             />
@@ -341,7 +326,7 @@ export default class ArticleDetail extends React.Component {
           <ArticleEditor
             ref='editor'
             article={activeArticle}
-            onChange={content => this.handleContentChange(content)}
+            onChange={(content) => this.handleContentChange(content)}
           />
         </div>
       </div>
@@ -351,11 +336,6 @@ export default class ArticleDetail extends React.Component {
 
 ArticleDetail.propTypes = {
   dispatch: PropTypes.func,
-  status: PropTypes.shape(),
-  tags: PropTypes.array,
-  user: PropTypes.shape(),
-  folders: PropTypes.array,
-  modified: PropTypes.array,
-  activeArticle: PropTypes.shape()
+  repositories: PropTypes.array
 }
 ArticleDetail.prototype.linkState = linkState

browser/main/HomePage/ArticleList.js

@@ -2,7 +2,6 @@ import React, { PropTypes } from 'react'
 import ReactDOM from 'react-dom'
 import ModeIcon from 'browser/components/ModeIcon'
 import moment from 'moment'
-import { switchArticle } from '../actions'
 import FolderMark from 'browser/components/FolderMark'
 import TagLink from './TagLink'
 import _ from 'lodash'
@@ -15,7 +14,7 @@ export default class ArticleList extends React.Component {
   constructor (props) {
     super(props)
 
-    this.focusHandler = e => this.focus()
+    this.focusHandler = (e) => this.focus()
   }
 
   componentDidMount () {
@@ -30,8 +29,8 @@ export default class ArticleList extends React.Component {
   }
 
   componentDidUpdate () {
-    let { articles, activeArticle } = this.props
-    var index = articles.indexOf(activeArticle)
+    return false
+    var index = articles.indexOf(null)
     var el = ReactDOM.findDOMNode(this)
     var li = el.querySelectorAll('.ArticleList>div')[index]
 
@@ -130,16 +129,12 @@ export default class ArticleList extends React.Component {
   }
 
   render () {
-    let { articles, modified, activeArticle, folders } = this.props
-
-    let articleElements = articles.map(article => {
-      let modifiedArticle = _.findWhere(modified, {key: article.key})
+    let articles = []
+    let folders = []
+    let articleElements = articles.map((article) => {
       let originalArticle = article
-      if (modifiedArticle) {
-        article = Object.assign({}, article)
-      }
       let tagElements = Array.isArray(article.tags) && article.tags.length > 0
-        ? article.tags.slice().map(tag => {
+        ? article.tags.slice().map((tag) => {
           return (<TagLink key={tag} tag={tag}/>)
         })
         : (<span>Not tagged yet</span>)
@@ -153,27 +148,21 @@ export default class ArticleList extends React.Component {
 
       return (
         <div key={'article-' + article.key}>
-          <div onClick={e => this.handleArticleClick(article)(e)} className={'ArticleList-item' + (activeArticle.key === article.key ? ' active' : '')}>
+          <div onClick={(e) => this.handleArticleClick(article)(e)} className={'ArticleList-item' + (article.key === 'ACTIVE_POST_KEY' ? ' active' : '')}>
             <div className='ArticleList-item-top'>
               {folder != null
                 ? folderChanged
                   ? <span className='folderName'>
-                      <FolderMark color={originalFolder.color}/>{originalFolder.name}
-                      ->
-                      <FolderMark color={folder.color}/>{folder.name}
-                    </span>
+                    <FolderMark color={originalFolder.color}/>{originalFolder.name}
+                    ->
+                    <FolderMark color={folder.color}/>{folder.name}
+                  </span>
                   : <span className='folderName'>
-                      <FolderMark color={folder.color}/>{folder.name}
-                    </span>
+                    <FolderMark color={folder.color}/>{folder.name}
+                  </span>
                 : <span><FolderMark color={-1}/>Unknown</span>
               }
-              <span className='updatedAt'
-                children={
-                  modifiedArticle != null
-                    ? <span><span className='unsaved-mark'>●</span> Unsaved</span>
-                    : moment(article.updatedAt).fromNow()
-                }
-              />
+              <span className='updatedAt'>{moment(article.updatedAt).fromNow()}</span>
             </div>
             <div className='ArticleList-item-middle'>
               <ModeIcon className='mode' mode={article.mode}/> <div className='title' children={title}/>
@@ -191,7 +180,7 @@ export default class ArticleList extends React.Component {
     })
 
     return (
-      <div tabIndex='3' onKeyDown={e => this.handleArticleListKeyDown(e)} className='ArticleList'>
+      <div tabIndex='3' onKeyDown={(e) => this.handleArticleListKeyDown(e)} className='ArticleList'>
         {articleElements}
       </div>
     )
@@ -200,8 +189,5 @@ export default class ArticleList extends React.Component {
 
 ArticleList.propTypes = {
   dispatch: PropTypes.func,
-  folders: PropTypes.array,
-  articles: PropTypes.array,
-  modified: PropTypes.array,
-  activeArticle: PropTypes.shape()
+  repositories: PropTypes.array
 }