Skip to content

Commit f70cf78

Browse files
authored
Merge pull request BoostIO#231 from sota1235/master
[Refactor] Use ESLint instead of StandarJS and add settings for TravisCI
2 parents 3ca18c0 + bd0a326 commit f70cf78

53 files changed

Lines changed: 123 additions & 134 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.eslintignore

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
node_modules/
2+
compiled/
3+
dist/

.eslintrc

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
{
2+
"extends": ["standard", "standard-jsx"],
3+
"rules": {
4+
"no-useless-escape": 0
5+
}
6+
}

.travis.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
language: node_js
2+
node_js:
3+
- 'stable'
4+
- 'lts/*'
5+
6+
script: npm run lint && npm run test

browser/components/NoteItem.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -75,8 +75,8 @@ const NoteItem = ({ isActive, note, dateDisplay, handleNoteClick, handleNoteCont
7575
: <i styleName='item-title-icon' className='fa fa-fw fa-file-text-o' />
7676
}
7777

78-
{note.isStarred ?
79-
<i styleName='item-star' className='fa fa-star' /> : ''
78+
{note.isStarred
79+
? <i styleName='item-star' className='fa fa-star' /> : ''
8080
}
8181
</div>
8282
</div>
@@ -91,10 +91,10 @@ NoteItem.propTypes = {
9191
type: PropTypes.string.isRequired,
9292
title: PropTypes.string.isrequired,
9393
tags: PropTypes.array,
94-
isStarred: PropTypes.bool.isRequired,
94+
isStarred: PropTypes.bool.isRequired
9595
}),
9696
handleNoteClick: PropTypes.func.isRequired,
97-
handleNoteContextMenu: PropTypes.func.isRequired,
97+
handleNoteContextMenu: PropTypes.func.isRequired
9898
}
9999

100100
export default CSSModules(NoteItem, styles)

browser/components/NoteItemSimple.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,10 +40,10 @@ NoteItemSimple.propTypes = {
4040
storage: PropTypes.string.isRequired,
4141
key: PropTypes.string.isRequired,
4242
type: PropTypes.string.isRequired,
43-
title: PropTypes.string.isrequired,
43+
title: PropTypes.string.isrequired
4444
}),
4545
handleNoteClick: PropTypes.func.isRequired,
46-
handleNoteContextMenu: PropTypes.func.isRequired,
46+
handleNoteContextMenu: PropTypes.func.isRequired
4747
}
4848

4949
export default CSSModules(NoteItemSimple, styles)

browser/components/ProfileImage.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ export default class ProfileImage extends React.Component {
1212
className={className}
1313
width={this.props.size}
1414
height={this.props.size}
15-
src={src}/>
15+
src={src} />
1616
)
1717
}
1818
}

browser/components/SideNavFilter.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,17 +17,17 @@ const SideNavFilter = ({
1717
isFolded, isHomeActive, handleAllNotesButtonClick,
1818
isStarredActive, handleStarredButtonClick
1919
}) => (
20-
<div styleName={ isFolded ? 'menu--folded' : 'menu' }>
20+
<div styleName={isFolded ? 'menu--folded' : 'menu'}>
2121
<button styleName={isHomeActive ? 'menu-button--active' : 'menu-button'}
2222
onClick={handleAllNotesButtonClick}
2323
>
24-
<i className='fa fa-book fa-fw'/>
24+
<i className='fa fa-book fa-fw' />
2525
<span styleName='menu-button-label'>All Notes</span>
2626
</button>
2727
<button styleName={isStarredActive ? 'menu-button--active' : 'menu-button'}
2828
onClick={handleStarredButtonClick}
2929
>
30-
<i className='fa fa-star fa-fw'/>
30+
<i className='fa fa-star fa-fw' />
3131
<span styleName='menu-button-label'>Starred</span>
3232
</button>
3333
</div>
@@ -38,7 +38,7 @@ SideNavFilter.propTypes = {
3838
isHomeActive: PropTypes.bool.isRequired,
3939
handleAllNotesButtonClick: PropTypes.func.isRequired,
4040
isStarredActive: PropTypes.bool.isRequired,
41-
handleStarredButtonClick: PropTypes.func.isRequired,
41+
handleStarredButtonClick: PropTypes.func.isRequired
4242
}
4343

4444
export default CSSModules(SideNavFilter, styles)

browser/components/SnippetTab.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import React, { PropTypes } from 'react'
1+
import React from 'react'
22
import CSSModules from 'browser/lib/CSSModules'
33
import styles from './SnippetTab.styl'
44
import context from 'browser/lib/context'
@@ -117,7 +117,7 @@ class SnippetTab extends React.Component {
117117
<button styleName='deleteButton'
118118
onClick={(e) => this.handleDeleteButtonClick(e)}
119119
>
120-
<i className='fa fa-times'/>
120+
<i className='fa fa-times' />
121121
</button>
122122
}
123123
</div>

browser/components/StorageItem.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,8 @@ const StorageItem = ({
2727
onClick={handleButtonClick}
2828
onContextMenu={handleContextMenu}
2929
>
30-
<span styleName={isFolded ?
31-
'folderList-item-name--folded' : 'folderList-item-name'
30+
<span styleName={isFolded
31+
? 'folderList-item-name--folded' : 'folderList-item-name'
3232
}
3333
style={{borderColor: folderColor}}
3434
>
@@ -52,7 +52,7 @@ StorageItem.propTypes = {
5252
folderName: PropTypes.string.isRequired,
5353
folderColor: PropTypes.string,
5454
isFolded: PropTypes.bool.isRequired,
55-
noteCount: PropTypes.number,
55+
noteCount: PropTypes.number
5656
}
5757

5858
export default CSSModules(StorageItem, styles)

browser/finder/NoteDetail.js

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import React, { PropTypes } from 'react'
1+
import React from 'react'
22
import CSSModules from 'browser/lib/CSSModules'
33
import styles from './NoteDetail.styl'
44
import MarkdownPreview from 'browser/components/MarkdownPreview'
@@ -97,9 +97,7 @@ class NoteDetail extends React.Component {
9797
let { note, config } = this.props
9898
if (note == null) {
9999
return (
100-
<div styleName='root'>
101-
102-
</div>
100+
<div styleName='root' />
103101
)
104102
}
105103

0 commit comments

Comments
 (0)