Skip to content

Commit 107b79c

Browse files
committed
Merge branch 'master' into training
2 parents a3b3a8e + 51c6ab6 commit 107b79c

11 files changed

Lines changed: 16 additions & 13 deletions

controllers/kataCtrl.js

Lines changed: 9 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ const db = app.get('db');
44
module.exports = {
55
getKata: (req, res, next) => {
66
if (!req.params.kataId) {
7-
db.read.get_kata([], (err, kata) => {
7+
db.read.kata((err, kata) => {
88
if (err) {
99
console.log(err);
1010
res.status(500).json(err);
@@ -21,42 +21,39 @@ module.exports = {
2121
})
2222
}
2323
},
24-
24+
// GET from mainService must be in the form of req.params.kyu
2525
getRandomKata: (req, res, next) => {
2626
if (!req.params.kyu) {
27-
db.read.get_random_kata([], (err, katas) => {
27+
db.read.kata((err, katas) => {
2828
if (err) {
2929
console.log(err);
3030
res.status(500).json(err);
3131
}
32-
// math floor for random
33-
return res.status(200).json(katas);
32+
return res.status(200).json(katas[Math.floor(Math.random() * katas.length + 1)]);
3433
})
3534
} else {
36-
db.read.get_random_by_kyu([req.params.kyu], (err, katas) => {
35+
db.read.random_by_kyu([req.params.kyu], (err, katas) => {
3736
if (err) {
3837
console.log(err);
3938
res.status(500).json(err);
4039
}
41-
// get random kata based on kyu choice
42-
return res.status(200).json(katas);
40+
return res.status(200).json(katas[Math.floor(Math.random() * katas.length + 1)]);
4341
})
4442
}
4543
},
4644

4745
getCompletedKatas: (req, res, next) => {
48-
db.read.get_completed_katas([req.params.userId], (err, katas) => {
46+
db.read.completed_katas([req.user.id], (err, katas) => {
4947
if (err) {
5048
console.log(err);
5149
res.status(500).json(err);
5250
}
53-
// get kata info based on if they have been completed by that user
5451
return res.status(200).json(katas);
5552
})
5653
},
5754

5855
getKataSolutions: (req, res, next) => {
59-
db.read.get_kata_solutions([req.params.kataId], (err, solutions) => {
56+
db.read.kata_solutions([req.params.kataId], (err, solutions) => {
6057
if (err) {
6158
console.log(err);
6259
res.status(500).json(err);
@@ -66,7 +63,7 @@ module.exports = {
6663
},
6764

6865
postSolution: (req, res, next) => {
69-
db.create.post_solution([req.body.script, req.params.kataId], (err, solution) => {
66+
db.create.solution([req.user.id, req.params.kataId, req.body.script, ], (err, solution) => {
7067
if (err) {
7168
console.log(err);
7269
res.status(500).json(err);

db/create/post_solution.sql

Whitespace-only changes.

db/create/solution.sql

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
INSERT INTO solutions (user_id, kata_id, script) VALUES ($1, $2, $3);

db/read/completed_katas.sql

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
SELECT script, kyu, description, name FROM katas
2+
JOIN solutions ON katas.id = solutions.kata_id
3+
WHERE user_id = $1;

db/read/get_completed_katas.sql

Whitespace-only changes.

db/read/get_random_by_kyu.sql

Whitespace-only changes.

db/read/get_random_kata.sql

Whitespace-only changes.
File renamed without changes.

db/read/random_by_kyu.sql

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
SELECT * FROM katas
2+
WHERE kyu = $1;

0 commit comments

Comments
 (0)