forked from instructure/canvas-lms
-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy pathcourses_controller_spec.rb
More file actions
2313 lines (1965 loc) · 90 KB
/
Copy pathcourses_controller_spec.rb
File metadata and controls
2313 lines (1965 loc) · 90 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
#
# Copyright (C) 2011 - present Instructure, Inc.
#
# This file is part of Canvas.
#
# Canvas is free software: you can redistribute it and/or modify it under
# the terms of the GNU Affero General Public License as published by the Free
# Software Foundation, version 3 of the License.
#
# Canvas is distributed in the hope that it will be useful, but WITHOUT ANY
# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
# A PARTICULAR PURPOSE. See the GNU Affero General Public License for more
# details.
#
# You should have received a copy of the GNU Affero General Public License along
# with this program. If not, see <http://www.gnu.org/licenses/>.
#
require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
describe CoursesController do
describe "GET 'index'" do
it "should force login" do
course_with_student(:active_all => true)
get 'index'
expect(response).to be_redirect
end
it "should assign variables" do
course_with_student_logged_in(:active_all => true)
get 'index'
expect(response).to be_success
expect(assigns[:current_enrollments]).not_to be_nil
expect(assigns[:current_enrollments]).not_to be_empty
expect(assigns[:current_enrollments][0]).to eql(@enrollment)
expect(assigns[:past_enrollments]).not_to be_nil
expect(assigns[:future_enrollments]).not_to be_nil
end
it "should not duplicate enrollments in variables" do
course_with_student_logged_in(:active_all => true)
course_factory
@course.start_at = Time.now + 2.weeks
@course.restrict_enrollments_to_course_dates = true
@course.save!
@course.offer!
@course.enroll_student(@user)
get 'index'
expect(response).to be_success
assigns[:future_enrollments].each do |e|
expect(assigns[:current_enrollments]).not_to include e
end
end
describe 'current_enrollments' do
it "should group enrollments by course and type" do
# enrollments with multiple sections of the same type should be de-duped
course_factory(active_all: true)
user_factory(active_all: true)
sec1 = @course.course_sections.create!(:name => "section1")
sec2 = @course.course_sections.create!(:name => "section2")
ens = []
ens << @course.enroll_student(@user, :section => sec1, :allow_multiple_enrollments => true)
ens << @course.enroll_student(@user, :section => sec2, :allow_multiple_enrollments => true)
ens << @course.enroll_teacher(@user, :section => sec2, :allow_multiple_enrollments => true)
ens.each(&:accept!)
ens[1].conclude # the current enrollment should take precedence over the concluded one
user_session(@user)
get 'index'
expect(response).to be_success
current_ens = assigns[:current_enrollments]
expect(current_ens.count).to eql(2)
student_e = current_ens.detect(&:student?)
teacher_e = current_ens.detect(&:teacher?)
expect(student_e.course_section).to be_nil
expect(teacher_e.course_section).to eq sec2
expect(assigns[:past_enrollments]).to eql([])
expect(assigns[:future_enrollments]).to eql([])
end
end
describe 'past_enrollments' do
it "should include 'completed' courses" do
enrollment1 = course_with_student active_all: true
expect(enrollment1).to be_active
enrollment1.course.complete!
user_session(@student)
get 'index'
expect(response).to be_success
expect(assigns[:past_enrollments]).to eql([enrollment1])
expect(assigns[:current_enrollments]).to eql([])
expect(assigns[:future_enrollments]).to eql([])
end
it "should include 'rejected' and 'completed' enrollments" do
active_enrollment = course_with_student name: 'active', active_course: true
active_enrollment.accept!
rejected_enrollment = course_with_student user: @student, course_name: 'rejected', active_course: true
rejected_enrollment.update_attribute(:workflow_state, 'rejected')
completed_enrollment = course_with_student user: @student, course_name: 'completed', active_course: true
completed_enrollment.update_attribute(:workflow_state, 'completed')
user_session(@student)
get 'index'
expect(response).to be_success
expect(assigns[:past_enrollments]).to eq [completed_enrollment, rejected_enrollment]
expect(assigns[:current_enrollments]).to eq [active_enrollment]
expect(assigns[:future_enrollments]).to be_empty
end
it "should prioritize completed enrollments over inactive ones" do
course_with_student(:active_all => true)
old_enroll = @student.enrollments.first
section2 = @course.course_sections.create!
inactive_enroll = @course.enroll_student(@student, :section => section2, :allow_multiple_enrollments => true)
inactive_enroll.deactivate
@course.update_attributes(:start_at => 2.days.ago, :conclude_at => 1.day.ago, :restrict_enrollments_to_course_dates => true)
user_session(@student)
get 'index'
expect(response).to be_success
expect(assigns[:past_enrollments]).to eq [old_enroll]
end
it "should include 'active' enrollments whose term is past" do
@student = user_factory
# by course date, unrestricted
course1 = Account.default.courses.create! start_at: 2.months.ago,
conclude_at: 1.month.ago, # oh hey this already "ended" (not really because it's unrestricted) but whatever
restrict_enrollments_to_course_dates: false,
name: 'One'
course1.offer!
enrollment1 = course_with_student course: course1, user: @student, active_all: true
# by course date, restricted
course2 = Account.default.courses.create! start_at: 2.months.ago, conclude_at: 1.month.ago,
restrict_enrollments_to_course_dates: true,
name: 'Two'
course2.offer!
enrollment2 = course_with_student course: course2, user: @student, active_all: true
# by enrollment term
enrollment3 = course_with_student user: @student, course_name: 'Three', active_all: true
past_term = Account.default.enrollment_terms.create! name: 'past term', start_at: 1.month.ago, end_at: 1.day.ago
enrollment3.course.enrollment_term = past_term
enrollment3.course.save!
# by course date, unrestricted but the course dates aren't over yet
course4 = Account.default.courses.create! start_at: 2.months.ago, conclude_at: 1.month.from_now,
restrict_enrollments_to_course_dates: false,
name: 'Fore'
course4.offer!
enrollment4 = course_with_student course: course4, user: @student, active_all: true
# by course date, unrestricted past view
course5 = Account.default.courses.create! start_at: 2.months.ago, conclude_at: 1.month.ago,
restrict_enrollments_to_course_dates: false,
name: 'Phive',
restrict_student_past_view: false
course5.offer!
enrollment5 = course_with_student course: course5, user: @student, active_all: true
# by course date, restricted past view & enrollment dates
course6 = Account.default.courses.create! start_at: 2.months.ago, conclude_at: 1.month.ago,
restrict_enrollments_to_course_dates: true,
name: 'Styx',
restrict_student_past_view: true
course6.offer!
enrollment6 = course_with_student course: course6, user: @student, active_all: true
user_session(@student)
get 'index'
expect(response).to be_success
expect(assigns[:past_enrollments]).to match_array([enrollment6, enrollment5, enrollment3, enrollment2, enrollment1])
expect(assigns[:current_enrollments]).to eq [enrollment4]
expect(assigns[:future_enrollments]).to be_empty
end
it "should do other terrible date logic based on sections" do
@student = user_factory
# section date in past
course1 = Account.default.courses.create! start_at: 2.months.ago, conclude_at: 1.month.from_now
course1.default_section.update_attributes(:end_at => 1.month.ago)
course1.offer!
enrollment1 = course_with_student course: course1, user: @student, active_all: true
# by section date, in future
course2 = Account.default.courses.create! start_at: 2.months.ago, conclude_at: 1.month.ago
course2.default_section.update_attributes(:end_at => 1.month.from_now)
course2.offer!
enrollment2 = course_with_student course: course2, user: @student, active_all: true
user_session(@student)
get 'index'
expect(response).to be_success
expect(assigns[:past_enrollments]).to eq [enrollment1]
expect(assigns[:current_enrollments]).to eq [enrollment2]
expect(assigns[:future_enrollments]).to be_empty
end
it "should not include 'invited' enrollments whose term is past" do
@student = user_factory
# by enrollment term
enrollment = course_with_student user: @student, course_name: 'Three', :active_course => true
past_term = Account.default.enrollment_terms.create! name: 'past term', start_at: 1.month.ago, end_at: 1.day.ago
enrollment.course.enrollment_term = past_term
enrollment.course.save!
enrollment.reload
expect(enrollment.workflow_state).to eq "invited"
expect(enrollment).to_not be_invited # state_based_on_date
user_session(@student)
get 'index'
expect(response).to be_success
expect(assigns[:past_enrollments]).to be_empty
expect(assigns[:future_enrollments]).to be_empty
end
it "should not include the course if the caller is a student or observer and the course restricts students viewing courses after the end date" do
course1 = Account.default.courses.create!(:restrict_student_past_view => true)
course1.offer!
enrollment = course_with_student course: course1
enrollment.accept!
teacher = user_with_pseudonym(:active_all => true)
teacher_enrollment = course_with_teacher course: course1, :user => teacher
teacher_enrollment.accept!
course1.start_at = 2.months.ago
course1.conclude_at = 1.month.ago
course1.save!
course1.enrollment_term.update_attribute(:end_at, 1.month.ago)
user_session(@student)
get 'index'
expect(response).to be_success
expect(assigns[:past_enrollments]).to match_array([enrollment])
expect(assigns[:current_enrollments]).to be_empty
expect(assigns[:future_enrollments]).to be_empty
observer = user_with_pseudonym(active_all: true)
o = @student.user_observers.build; o.observer = observer; o.save!
user_session(observer)
get 'index'
expect(response).to be_success
expect(assigns[:past_enrollments]).to match_array([o.observer.enrollments.first])
expect(assigns[:current_enrollments]).to be_empty
expect(assigns[:future_enrollments]).to be_empty
user_session(teacher)
get 'index'
expect(response).to be_success
expect(assigns[:past_enrollments]).to eq [teacher_enrollment]
expect(assigns[:current_enrollments]).to be_empty
expect(assigns[:future_enrollments]).to be_empty
end
end
describe 'current_enrollments' do
it "should include courses with no applicable start/end dates" do
# no dates at all
enrollment1 = student_in_course active_all: true, course_name: 'A'
course2 = Account.default.courses.create! start_at: 2.weeks.ago, conclude_at: 1.week.from_now,
restrict_enrollments_to_course_dates: false,
name: 'B'
course2.offer!
enrollment2 = student_in_course user: @student, course: course2, active_all: true
# future date that doesn't count
course3 = Account.default.courses.create! start_at: 1.weeks.from_now, conclude_at: 2.weeks.from_now,
restrict_enrollments_to_course_dates: false,
name: 'C'
course3.offer!
enrollment3 = student_in_course user: @student, course: course3, active_all: true
user_session(@student)
get 'index'
expect(response).to be_success
expect(assigns[:past_enrollments]).to be_empty
expect(assigns[:current_enrollments]).to eq [enrollment1, enrollment2, enrollment3]
expect(assigns[:future_enrollments]).to be_empty
end
it "should include courses with current start/end dates" do
course1 = Account.default.courses.create! start_at: 1.week.ago, conclude_at: 1.week.from_now,
restrict_enrollments_to_course_dates: true,
name: 'A'
course1.offer!
enrollment1 = student_in_course course: course1
enrollment2 = course_with_student user: @student, course_name: 'B', active_all: true
current_term = Account.default.enrollment_terms.create! name: 'current term', start_at: 1.month.ago, end_at: 1.month.from_now
enrollment2.course.enrollment_term = current_term
enrollment2.course.save!
user_session(@student)
get 'index'
expect(response).to be_success
expect(assigns[:past_enrollments]).to be_empty
expect(assigns[:current_enrollments]).to eq [enrollment1, enrollment2]
expect(assigns[:future_enrollments]).to be_empty
end
it "should include 'invited' enrollments, and list them before 'active'" do
enrollment1 = course_with_student course_name: 'Z'
@student.register!
@course.offer!
enrollment1.invite!
enrollment2 = course_with_student user: @student, course_name: 'A', active_all: true
user_session(@student)
get 'index'
expect(response).to be_success
expect(assigns[:past_enrollments]).to be_empty
expect(assigns[:current_enrollments]).to eq [enrollment1, enrollment2]
expect(assigns[:future_enrollments]).to be_empty
end
it "should include unpublished courses" do
enrollment = course_with_student
expect(@course).to be_unpublished
enrollment.invite!
user_session(@student)
get 'index'
expect(response).to be_success
expect(assigns[:past_enrollments]).to be_empty
expect(assigns[:current_enrollments]).to eq [enrollment]
expect(assigns[:future_enrollments]).to be_empty
end
end
describe 'future_enrollments' do
it "should include courses with a start date in the future, regardless of published state" do
# published course
course1 = Account.default.courses.create! start_at: 1.month.from_now, restrict_enrollments_to_course_dates: true, name: 'A'
course1.offer!
enrollment1 = course_with_student course: course1
# unpublished course
course2 = Account.default.courses.create! start_at: 1.month.from_now, restrict_enrollments_to_course_dates: true, name: 'B'
expect(course2).to be_unpublished
enrollment2 = course_with_student user: @student, course: course2
user_session(@student)
get 'index'
expect(response).to be_success
expect(assigns[:past_enrollments]).to be_empty
expect(assigns[:current_enrollments]).to be_empty
expect(assigns[:future_enrollments].map(&:course_id)).to eq [course1.id, course2.id]
observer = user_with_pseudonym(active_all: true)
o = @student.user_observers.build; o.observer = observer; o.save!
user_session(observer)
get 'index'
expect(response).to be_success
expect(assigns[:past_enrollments]).to be_empty
expect(assigns[:current_enrollments]).to be_empty
expect(assigns[:future_enrollments].map(&:course_id)).to eq [course1.id, course2.id]
end
it "should include courses with accepted enrollments and future start dates" do
course1 = Account.default.courses.create! start_at: 1.month.from_now, restrict_enrollments_to_course_dates: true, name: 'A'
course1.offer!
student_in_course course: course1, active_all: true
user_session(@student)
get 'index'
expect(assigns[:future_enrollments].map(&:course_id)).to eq [course1.id]
end
it "should not be empty if the caller is a student or observer and the root account restricts students viewing courses before the start date" do
course1 = Account.default.courses.create! start_at: 1.month.from_now, restrict_enrollments_to_course_dates: true
course1.offer!
enrollment1 = course_with_student course: course1
enrollment1.root_account.settings[:restrict_student_future_view] = true
enrollment1.root_account.save!
expect(course1.restrict_student_future_view?).to be_truthy # should inherit
user_session(@student)
get 'index'
expect(response).to be_success
expect(assigns[:past_enrollments]).to be_empty
expect(assigns[:current_enrollments]).to be_empty
expect(assigns[:future_enrollments]).to eq [enrollment1]
observer = user_with_pseudonym(active_all: true)
o = @student.user_observers.build; o.observer = observer; o.save!
user_session(observer)
get 'index'
expect(response).to be_success
expect(assigns[:past_enrollments]).to be_empty
expect(assigns[:current_enrollments]).to be_empty
expect(assigns[:future_enrollments]).to eq [observer.enrollments.first]
teacher = user_with_pseudonym(:active_all => true)
teacher_enrollment = course_with_teacher course: course1, :user => teacher
user_session(teacher)
get 'index'
expect(response).to be_success
expect(assigns[:past_enrollments]).to be_empty
expect(assigns[:current_enrollments]).to be_empty
expect(assigns[:future_enrollments]).to eq [teacher_enrollment]
end
end
end
describe "GET 'statistics'" do
it 'does not break using new student_ids method from course' do
course_with_teacher_logged_in(:active_all => true)
get 'statistics', :format => 'json', :course_id => @course.id
expect(response).to be_success
end
end
describe "GET 'settings'" do
before :once do
course_with_teacher(active_all: true)
student_in_course(active_all: true)
end
it "should set tool creation permissions true for roles that are granted rights" do
user_session(@teacher)
get 'settings', :course_id => @course.id
expect(controller.js_env[:PERMISSIONS][:create_tool_manually]).to eq(true)
end
it "should not set tool creation permissions for roles not granted rights" do
user_session(@student)
get 'settings', :course_id => @course.id
expect(controller.js_env[:PERMISSIONS]).to be_nil
end
it "should require authorization" do
get 'settings', :course_id => @course.id
assert_unauthorized
end
it "should should not allow students" do
user_session(@student)
get 'settings', :course_id => @course.id
assert_unauthorized
end
it "should render properly" do
user_session(@teacher)
get 'settings', :course_id => @course.id
expect(response).to be_success
expect(response).to render_template("settings")
end
it "should give a helpful error message for students that can't access yet" do
user_session(@student)
@course.workflow_state = 'claimed'
@course.save!
get 'settings', :course_id => @course.id
assert_status(401)
expect(assigns[:unauthorized_reason]).to eq :unpublished
expect(assigns[:unauthorized_message]).not_to be_nil
@course.workflow_state = 'available'
@course.save!
@enrollment.start_at = 2.days.from_now
@enrollment.end_at = 4.days.from_now
@enrollment.save!
get 'settings', :course_id => @course.id
assert_status(401)
expect(assigns[:unauthorized_reason]).to eq :unpublished
expect(assigns[:unauthorized_message]).not_to be_nil
end
it "does not record recent activity for unauthorize actions" do
user_session(@student)
@course.workflow_state = 'available'
@course.restrict_student_future_view = true
@course.save!
@enrollment.start_at = 2.days.from_now
@enrollment.end_at = 4.days.from_now
@enrollment.last_activity_at = nil
@enrollment.save!
get 'settings', course_id: @course.id
assert_status(401)
expect(assigns[:unauthorized_reason]).to eq(:unpublished)
expect(@enrollment.reload.last_activity_at).to be(nil)
end
it "should assign active course_settings_sub_navigation external tools" do
user_session(@teacher)
@teacher.enable_feature!(:lor_for_user)
shared_settings = { consumer_key: 'test', shared_secret: 'secret', url: 'http://example.com/lti' }
other_tool = @course.context_external_tools.create(shared_settings.merge(name: 'other', course_navigation: {enabled: true}))
inactive_tool = @course.context_external_tools.create(shared_settings.merge(name: 'inactive', course_settings_sub_navigation: {enabled: true}))
active_tool = @course.context_external_tools.create(shared_settings.merge(name: 'active', course_settings_sub_navigation: {enabled: true}))
inactive_tool.workflow_state = 'deleted'
inactive_tool.save!
get 'settings', :course_id => @course.id
expect(assigns[:course_settings_sub_navigation_tools].size).to eq 1
assigned_tool = assigns[:course_settings_sub_navigation_tools].first
expect(assigned_tool.id).to eq active_tool.id
end
end
describe "GET 'enrollment_invitation'" do
it "should successfully reject invitation for logged-in user" do
course_with_student_logged_in(:active_course => true)
post 'enrollment_invitation', :course_id => @course.id, :reject => '1', :invitation => @enrollment.uuid
expect(response).to be_redirect
expect(response).to redirect_to(dashboard_url)
expect(assigns[:pending_enrollment]).to eql(@enrollment)
expect(assigns[:pending_enrollment]).to be_rejected
end
it "should successfully reject invitation for not-logged-in user" do
course_with_student(:active_course => true, :active_user => true)
post 'enrollment_invitation', :course_id => @course.id, :reject => '1', :invitation => @enrollment.uuid
expect(response).to be_redirect
expect(response).to redirect_to(root_url)
expect(assigns[:pending_enrollment]).to eql(@enrollment)
expect(assigns[:pending_enrollment]).to be_rejected
end
it "should successfully reject temporary invitation" do
user_with_pseudonym(:active_all => 1)
user_session(@user, @pseudonym)
user = User.create! { |u| u.workflow_state = 'creation_pending' }
user.communication_channels.create!(:path => @cc.path)
course_factory(active_all: true)
@enrollment = @course.enroll_student(user)
post 'enrollment_invitation', :course_id => @course.id, :reject => '1', :invitation => @enrollment.uuid
expect(response).to be_redirect
expect(response).to redirect_to(root_url)
expect(assigns[:pending_enrollment]).to eql(@enrollment)
expect(assigns[:pending_enrollment]).to be_rejected
end
it "should not reject invitation for bad parameters" do
course_with_student(:active_course => true, :active_user => true)
post 'enrollment_invitation', :course_id => @course.id, :reject => '1', :invitation => "#{@enrollment.uuid}https://canvas.instructure.com/courses/#{@course.id}?invitation=#{@enrollment.uuid}"
expect(response).to be_redirect
expect(response).to redirect_to(course_url(@course.id))
expect(assigns[:pending_enrollment]).to be_nil
end
it "should accept invitation for logged-in user" do
course_with_student_logged_in(:active_course => true, :active_user => true)
post 'enrollment_invitation', :course_id => @course.id, :accept => '1', :invitation => @enrollment.uuid
expect(response).to be_redirect
expect(response).to redirect_to(course_url(@course.id))
expect(assigns[:context_enrollment]).to eql(@enrollment)
expect(assigns[:context_enrollment]).to be_active
end
it "should ask user to login for registered not-logged-in user" do
user_with_pseudonym(:active_course => true, :active_user => true)
course_factory(active_all: true)
@enrollment = @course.enroll_user(@user)
post 'enrollment_invitation', :course_id => @course.id, :accept => '1', :invitation => @enrollment.uuid
expect(response).to be_redirect
expect(response).to redirect_to(login_url)
end
it "should defer to registration_confirmation for pre-registered not-logged-in user" do
user_with_pseudonym
course_factory(active_course: true, :active_user => true)
@enrollment = @course.enroll_user(@user)
post 'enrollment_invitation', :course_id => @course.id, :accept => '1', :invitation => @enrollment.uuid
expect(response).to be_redirect
expect(response).to redirect_to(registration_confirmation_url(@pseudonym.communication_channel.confirmation_code, :enrollment => @enrollment.uuid))
end
it "should defer to registration_confirmation if logged-in user does not match enrollment user" do
user_with_pseudonym
@u2 = @user
course_with_student_logged_in(:active_course => true, :active_user => true)
@e2 = @course.enroll_user(@u2)
post 'enrollment_invitation', :course_id => @course.id, :accept => '1', :invitation => @e2.uuid
expect(response).to redirect_to(registration_confirmation_url(:nonce => @pseudonym.communication_channel.confirmation_code, :enrollment => @e2.uuid))
end
it "should ask user to login if logged-in user does not match enrollment user, and enrollment user doesn't have an e-mail" do
user_factory
@user.register!
@u2 = @user
course_with_student_logged_in(:active_course => true, :active_user => true)
@e2 = @course.enroll_user(@u2)
post 'enrollment_invitation', :course_id => @course.id, :accept => '1', :invitation => @e2.uuid
expect(response).to redirect_to(login_url(:force_login => 1))
end
it "should accept an enrollment for a restricted by dates course" do
course_with_student_logged_in(:active_all => true)
@course.update_attributes(:restrict_enrollments_to_course_dates => true,
:start_at => Time.now + 2.weeks)
@enrollment.update_attributes(:workflow_state => 'invited', last_activity_at: nil)
post 'enrollment_invitation', :course_id => @course.id, :accept => '1',
:invitation => @enrollment.uuid
expect(response).to redirect_to(course_url(@course))
@enrollment.reload
expect(@enrollment.workflow_state).to eq('active')
expect(@enrollment.last_activity_at).to be(nil)
end
end
describe "GET 'show'" do
before :once do
course_with_teacher(active_all: true)
student_in_course(active_all: true)
end
it "should require authorization" do
get 'show', :id => @course.id
assert_unauthorized
end
it "should not find deleted courses" do
user_session(@teacher)
@course.destroy
assert_page_not_found do
get 'show', :id => @course.id
end
end
it "should assign variables" do
user_session(@student)
get 'show', :id => @course.id
expect(response).to be_success
expect(assigns[:context]).to eql(@course)
expect(assigns[:stream_items]).to eql([])
end
it "should give a helpful error message for students that can't access yet" do
user_session(@student)
@course.workflow_state = 'claimed'
@course.restrict_student_future_view = true
@course.save!
get 'show', :id => @course.id
assert_status(401)
expect(assigns[:unauthorized_reason]).to eq :unpublished
expect(assigns[:unauthorized_message]).not_to be_nil
@course.workflow_state = 'available'
@course.save!
@enrollment.start_at = 2.days.from_now
@enrollment.end_at = 4.days.from_now
@enrollment.save!
controller.instance_variable_set(:@js_env, nil)
get 'show', :id => @course.id
assert_status(401)
expect(assigns[:unauthorized_reason]).to eq :unpublished
expect(assigns[:unauthorized_message]).not_to be_nil
end
it "should allow student view student to view unpublished courses" do
@course.update_attribute :workflow_state, 'claimed'
user_session(@teacher)
@fake_student = @course.student_view_student
session[:become_user_id] = @fake_student.id
get 'show', :id => @course.id
expect(response).to be_success
end
it "should not allow student view students to view other courses" do
course_with_teacher_logged_in(:active_user => true)
@c1 = @course
course_factory(active_course: true)
@c2 = @course
@fake1 = @c1.student_view_student
session[:become_user_id] = @fake1.id
get 'show', :id => @c2.id
assert_unauthorized
end
def check_course_show(should_show)
controller.instance_variable_set(:@context_all_permissions, nil)
controller.instance_variable_set(:@js_env, nil)
get 'show', :id => @course.id
if should_show
expect(response).to be_success
expect(assigns[:context]).to eql(@course)
else
assert_status(401)
end
end
it "should show unauthorized/authorized to a student for a future course depending on restrict_student_future_view setting" do
course_with_student_logged_in(:active_course => 1)
@course.start_at = Time.now + 2.weeks
@course.restrict_enrollments_to_course_dates = true
@course.restrict_student_future_view = true
@course.save!
check_course_show(false)
expect(assigns[:unauthorized_message]).not_to be_nil
@course.restrict_student_future_view = false
@course.save!
check_course_show(true)
end
it "should show unauthorized/authorized to a student for a past course depending on restrict_student_past_view setting" do
course_with_student_logged_in(:active_course => 1)
@course.start_at = 3.weeks.ago
@course.conclude_at = 2.weeks.ago
@course.restrict_enrollments_to_course_dates = true
@course.restrict_student_past_view = true
@course.save!
check_course_show(false)
# manually completed
@course.conclude_at = 2.weeks.from_now
@course.save!
@student.enrollments.first.complete!
check_course_show(false)
@course.restrict_student_past_view = false
@course.save!
check_course_show(true)
end
context 'when default_view is `syllabus`' do
before do
course_with_student_logged_in(active_course: 1)
@course.default_view = 'syllabus'
@course.syllabus_body = '<p>This is your syllabus.</p>'
@course.save!
end
it 'assigns syllabus_body' do
get :show, id: @course.id
expect(assigns[:syllabus_body]).not_to be_nil
end
it 'assigns groups' do
get :show, id: @course.id
expect(assigns[:groups]).not_to be_nil
end
end
context "show feedback for the current course only on course front page" do
before(:once) do
course_with_student(:active_all => true)
@me = @user
@course1 = @course
course_with_teacher(:course => @course1)
course_with_student(:active_all => true, :user => @student)
@course2 = @course
course_with_teacher(:course => @course2, :user => @teacher)
@a1 = @course1.assignments.new(:title => "some assignment course 1")
@a1.workflow_state = "published"
@a1.save
@s1 = @a1.submit_homework(@student)
@c1 = @s1.add_comment(:author => @teacher, :comment => "some comment1")
# this shouldn't show up in any course 1 list
@a2 = @course2.assignments.new(:title => "some assignment course 2")
@a2.workflow_state = "published"
@a2.save
@s2 = @a2.submit_homework(@student)
@c2 = @s2.add_comment(:author => @teacher, :comment => "some comment2")
end
before(:each) do
user_session(@me)
end
it "should work for module view" do
@course1.default_view = "modules"
@course1.save
get 'show', :id => @course1.id
expect(assigns(:recent_feedback).count).to eq 1
expect(assigns(:recent_feedback).first.assignment_id).to eq @a1.id
end
it "should work for assignments view" do
@course1.default_view = "assignments"
@course1.save!
get 'show', :id => @course1.id
expect(assigns(:recent_feedback).count).to eq 1
expect(assigns(:recent_feedback).first.assignment_id).to eq @a1.id
end
it "should disable management and set env urls on assignment homepage" do
@course1.default_view = "assignments"
@course1.save!
get 'show', :id => @course1.id
expect(controller.js_env[:URLS][:new_assignment_url]).not_to be_nil
expect(controller.js_env[:PERMISSIONS][:manage]).to be_falsey
end
it "should set ping_url" do
get 'show', :id => @course1.id
expect(controller.js_env[:ping_url]).not_to be_nil
end
it "should not show unpublished assignments to students" do
@course1.default_view = "assignments"
@course1.save!
@a1a = @course1.assignments.new(:title => "some assignment course 1", due_at: 1.day.from_now)
@a1a.save
@a1a.unpublish
get 'show', :id => @course1.id
expect(assigns(:upcoming_assignments).map(&:id).include?(@a1a.id)).to be_falsey
end
it "should work for wiki view" do
@course1.default_view = "wiki"
@course1.save
get 'show', :id => @course1.id
expect(assigns(:recent_feedback).count).to eq 1
expect(assigns(:recent_feedback).first.assignment_id).to eq @a1.id
end
it "should work for wiki view with draft state enabled" do
@course1.default_view = "wiki"
@course1.save!
@course1.wiki.wiki_pages.create!(:title => 'blah').set_as_front_page!
get 'show', :id => @course1.id
expect(controller.js_env[:WIKI_RIGHTS].symbolize_keys).to eql({:read => true})
expect(controller.js_env[:PAGE_RIGHTS].symbolize_keys).to eql({:read => true})
expect(controller.js_env[:COURSE_TITLE]).to eql @course1.name
end
it "should work for wiki view with home page announcements enabled" do
@course1.default_view = "wiki"
@course1.show_announcements_on_home_page = true
@course1.home_page_announcement_limit = 3
@course1.save!
@course1.wiki.wiki_pages.create!(:title => 'blah').set_as_front_page!
get 'show', :id => @course1.id
expect(controller.js_env[:COURSE_HOME]).to be_truthy
expect(controller.js_env[:SHOW_ANNOUNCEMENTS]).to be_truthy
expect(controller.js_env[:ANNOUNCEMENT_LIMIT]).to eq(3)
end
it "should not show announcements for public users" do
@course1.default_view = "wiki"
@course1.show_announcements_on_home_page = true
@course1.home_page_announcement_limit = 3
@course1.is_public = true
@course1.save!
@course1.wiki.wiki_pages.create!(:title => 'blah').set_as_front_page!
remove_user_session
get 'show', :id => @course1.id
expect(response).to be_success
expect(controller.js_env[:COURSE_HOME]).to be_truthy
expect(controller.js_env[:SHOW_ANNOUNCEMENTS]).to be_falsey
end
it "should work for syllabus view" do
@course1.default_view = "syllabus"
@course1.save
get 'show', :id => @course1.id
expect(assigns(:recent_feedback).count).to eq 1
expect(assigns(:recent_feedback).first.assignment_id).to eq @a1.id
end
it "should work for feed view" do
@course1.default_view = "feed"
@course1.save
get 'show', :id => @course1.id
expect(assigns(:recent_feedback).count).to eq 1
expect(assigns(:recent_feedback).first.assignment_id).to eq @a1.id
end
it "should only show recent feedback if user is student in specified course" do
course_with_teacher(:active_all => true, :user => @student)
@course3 = @course
get 'show', :id => @course3.id
expect(assigns(:show_recent_feedback)).to be_falsey
end
end
context "invitations" do
before :once do
Account.default.settings[:allow_invitation_previews] = true
Account.default.save!
course_with_teacher(active_course: true)
@teacher_enrollment = @enrollment
student_in_course(course: @course)
end
it "should allow an invited user to see the course" do
expect(@enrollment).to be_invited
get 'show', :id => @course.id, :invitation => @enrollment.uuid
expect(response).to be_success
expect(assigns[:pending_enrollment]).to eq @enrollment
end
it "should still show unauthorized if unpublished, regardless of if previews are allowed" do
# unpublished course with invited student in default account (allows previews)
@course.workflow_state = 'claimed'
@course.save!
get 'show', :id => @course.id, :invitation => @enrollment.uuid
assert_unauthorized
expect(assigns[:unauthorized_message]).not_to be_nil
# unpublished course with invited student in account that disallows previews
@account = Account.create!
course_with_student(:account => @account)
@course.workflow_state = 'claimed'
@course.save!
controller.instance_variable_set(:@js_env, nil)
get 'show', :id => @course.id, :invitation => @enrollment.uuid
assert_unauthorized
expect(assigns[:unauthorized_message]).not_to be_nil
end
it "should not show unauthorized for invited teachers when unpublished" do
# unpublished course with invited teacher
@course.workflow_state = 'claimed'
@course.save!
get 'show', :id => @course.id, :invitation => @teacher_enrollment.uuid
expect(response).to be_success
end
it "should re-invite an enrollment that has previously been rejected" do
expect(@enrollment).to be_invited
@enrollment.reject!
get 'show', :id => @course.id, :invitation => @enrollment.uuid
expect(response).to be_success
@enrollment.reload
expect(@enrollment).to be_invited
end
it "should auto-accept if previews are not allowed" do
# Currently, previews are only allowed for the default account
@account = Account.create!
course_with_student_logged_in(:active_course => 1, :account => @account)
get 'show', :id => @course.id, :invitation => @enrollment.uuid
expect(response).to be_success
expect(response).to render_template('show')
expect(assigns[:context_enrollment]).to eq @enrollment
@enrollment.reload
expect(@enrollment).to be_active
end
it "should not error when previewing an unpublished course as an invited admin" do
@account = Account.create!
@account.settings[:allow_invitation_previews] = false
@account.save!
course_factory(:account => @account)
user_factory(active_all: true)
enrollment = @course.enroll_teacher(@user, :enrollment_state => 'invited')
user_session(@user)
get 'show', :id => @course.id
expect(response).to be_success
expect(response).to render_template('show')
expect(assigns[:context_enrollment]).to eq enrollment
enrollment.reload
expect(enrollment).to be_invited
end
it "should ignore invitations that have been accepted (not logged in)" do
@enrollment.accept!
get 'show', :id => @course.id, :invitation => @enrollment.uuid
assert_unauthorized
end
it "should ignore invitations that have been accepted (logged in)" do
@enrollment.accept!
user_session(@student)