Refactor coffeescript and specs

Refs: SIS-2715

Test Plan: QA will review the functionality in the final commit.

Change-Id: I6e1fbb1fc11cff2f711943e0f2bdfe2a33e811b3
Reviewed-on: https://gerrit.instructure.com/102914
Tested-by: Jenkins
Reviewed-by: Nick Houle <nhoule@instructure.com>
Product-Review: Stewie aka Nicholas Stewart <nstewart@instructure.com>
QA-Review: Stewie aka Nicholas Stewart <nstewart@instructure.com>

Author: Stewie (Nicholas Stewart)

app/coffeescripts/views/DiscussionTopics/EditView.coffee

@@ -21,10 +21,29 @@ define [
   'compiled/util/deparam'
   'compiled/jquery.rails_flash_notifications' #flashMessage
   'jsx/shared/helpers/numberHelper'
-], (I18n, ValidatedFormView, AssignmentGroupSelector, GradingTypeSelector,
-GroupCategorySelector, PeerReviewsSelector, PostToSisSelector, _, template, RichContentEditor,
-htmlEscape, DiscussionTopic, Announcement, Assignment, $, preventDefault, MissingDateDialog, KeyboardShortcuts,
-ConditionalRelease, deparam, flashMessage, numberHelper) ->
+], (
+    I18n,
+    ValidatedFormView,
+    AssignmentGroupSelector,
+    GradingTypeSelector,
+    GroupCategorySelector,
+    PeerReviewsSelector,
+    PostToSisSelector,
+    _,
+    template,
+    RichContentEditor,
+    htmlEscape,
+    DiscussionTopic,
+    Announcement,
+    Assignment,
+    $,
+    preventDefault,
+    MissingDateDialog,
+    KeyboardShortcuts,
+    ConditionalRelease,
+    deparam,
+    flashMessage,
+    numberHelper) ->
 
   RichContentEditor.preloadRemoteModule()
 
@@ -361,10 +380,10 @@ ConditionalRelease, deparam, flashMessage, numberHelper) ->
     _validateTitle: (data, errors) =>
       max_name_length = 256
       if data.assignment.attributes.post_to_sis == '1' && ENV.MAX_NAME_LENGTH_REQUIRED_FOR_ACCOUNT == true
-        max_name_length = ENV.MAX_NAME_LENGTH + 1
+        max_name_length = ENV.MAX_NAME_LENGTH
       if $.trim(data.title.toString()).length > max_name_length
         errors["title"] = [
-          message: I18n.t "Title is too long, must be under %{length} characters", length: max_name_length
+          message: I18n.t("Title is too long, must be under %{length} characters", length: (max_name_length + 1))
         ]
       errors
 

spec/coffeescripts/views/DiscussionTopics/EditViewSpec.coffee

@@ -14,9 +14,21 @@ define [
   'helpers/fakeENV'
   'jsx/shared/rce/RichContentEditor'
   'helpers/jquery.simulate'
-], ($, _, SectionCollection, Assignment, DueDateList, Section, DiscussionTopic,
-Announcement, DueDateOverrideView, EditView, AssignmentGroupCollection,
-GroupCategorySelector, fakeENV, RichContentEditor) ->
+], (
+  $,
+  _,
+  SectionCollection,
+  Assignment,
+  DueDateList,
+  Section,
+  DiscussionTopic,
+  Announcement,
+  DueDateOverrideView,
+  EditView,
+  AssignmentGroupCollection,
+  GroupCategorySelector,
+  fakeENV,
+  RichContentEditor) ->
 
   editView = (opts = {}, discussOpts = {}) ->
     modelClass = if opts.isAnnouncement then Announcement else DiscussionTopic
@@ -42,6 +54,16 @@ GroupCategorySelector, fakeENV, RichContentEditor) ->
     (app.assignmentGroupCollection = new AssignmentGroupCollection).contextAssetString = ENV.context_asset_string
     app.render()
 
+  nameLengthHelper = (view, length, maxNameLengthRequiredForAccount, maxNameLength, postToSis) ->
+    ENV.MAX_NAME_LENGTH_REQUIRED_FOR_ACCOUNT = maxNameLengthRequiredForAccount
+    ENV.MAX_NAME_LENGTH = maxNameLength
+    ENV.IS_LARGE_ROSTER = true
+    ENV.CONDITIONAL_RELEASE_SERVICE_ENABLED = false
+    title = 'a'.repeat(length)
+    assignment = view.assignment
+    assignment.attributes.post_to_sis = postToSis
+    return view.validateBeforeSave({title: title, set_assignment: '1', assignment: assignment}, [])
+
   QUnit.module 'EditView',
     setup: ->
       fakeENV.setup()
@@ -169,86 +191,29 @@ GroupCategorySelector, fakeENV, RichContentEditor) ->
     view.loadConditionalRelease()
     equal 1, view.$conditionalReleaseTarget.children().size()
 
-  test "has an error when a title > 255 chars", ->
-    view = @editView({ withAssignment: true})
-    assignment = view.assignment
-    l1 = 'aaaaaaaaaa'
-    l2 = l1 + l1 + l1 + l1 + l1 + l1
-    l3 = l2 + l2 + l2 + l2 + l2 + l2
-
-    ENV.IS_LARGE_ROSTER = true
-    ENV.CONDITIONAL_RELEASE_SERVICE_ENABLED = false
-    errors = view.validateBeforeSave({title: l3, set_assignment: '1', assignment: assignment}, [])
-
-    equal errors["title"][0]["message"], "Title is too long, must be under 256 characters"
-
-  test "allows dicussion to save when a title < 255 chars, MAX_NAME_LENGTH is not required and post_to_sis is true", ->
+  test "has an error when a title is 257 chars", ->
     view = @editView({ withAssignment: true})
-    assignment = view.assignment
-    assignment.attributes.post_to_sis = '1'
-    l1 = 'aaaaaaaaaa'
+    errors = nameLengthHelper(view, 257, false, 30, '0')
+    equal errors["title"][0]["message"], "Title is too long, must be under 257 characters"
 
-    ENV.MAX_NAME_LENGTH_REQUIRED_FOR_ACCOUNT = false
-    ENV.IS_LARGE_ROSTER = true
-    ENV.CONDITIONAL_RELEASE_SERVICE_ENABLED = false
-    errors = view.validateBeforeSave({title: l1, set_assignment: '1', assignment: assignment}, [])
-    equal errors.length, 0
-
-  test "allows dicussion to save when a title < 255 chars, MAX_NAME_LENGTH is not required and post_to_sis is false", ->
+  test "allows dicussion to save when a title is 256 chars, MAX_NAME_LENGTH is not required and post_to_sis is true", ->
     view = @editView({ withAssignment: true})
-    assignment = view.assignment
-    assignment.attributes.post_to_sis = '1'
-    l1 = 'aaaaaaaaaa'
-
-    ENV.MAX_NAME_LENGTH_REQUIRED_FOR_ACCOUNT = false
-    ENV.IS_LARGE_ROSTER = true
-    ENV.CONDITIONAL_RELEASE_SERVICE_ENABLED = false
-    errors = view.validateBeforeSave({title: l1, set_assignment: '1', assignment: assignment}, [])
+    errors = nameLengthHelper(view, 256, false, 30, '1')
     equal errors.length, 0
 
   test "has an error when a title > MAX_NAME_LENGTH chars if MAX_NAME_LENGTH is custom, required and post_to_sis is true", ->
     view = @editView({ withAssignment: true})
-    assignment = view.assignment
-    assignment.attributes.post_to_sis = '1'
-    l1 = 'aaaaaaaaaa'
-
-    ENV.MAX_NAME_LENGTH = 5
-    ENV.MAX_NAME_LENGTH_REQUIRED_FOR_ACCOUNT = true
-    ENV.IS_LARGE_ROSTER = true
-    ENV.CONDITIONAL_RELEASE_SERVICE_ENABLED = false
-    errors = view.validateBeforeSave({title: l1, set_assignment: '1', assignment: assignment}, [])
-
-    equal errors["title"][0]["message"], "Title is too long, must be under #{ENV.MAX_NAME_LENGTH + 1} characters"
+    errors = nameLengthHelper(view, 40, true, 30, '1')
+    equal errors["title"][0]["message"], "Title is too long, must be under 31 characters"
 
   test "allows discussion to save when title > MAX_NAME_LENGTH chars if MAX_NAME_LENGTH is custom, required and post_to_sis is false", ->
     view = @editView({ withAssignment: true})
-    assignment = view.assignment
-    assignment.attributes.post_to_sis = '0'
-    l1 = 'aaaaaaaaaa'
-    l2 = l1 + l1 + l1 + l1 + l1 + l1
-    l3 = l2 + l2 + l2 + l2 + l2 + l2
-
-    ENV.MAX_NAME_LENGTH = 5
-    ENV.MAX_NAME_LENGTH_REQUIRED_FOR_ACCOUNT = true
-    ENV.IS_LARGE_ROSTER = true
-    ENV.CONDITIONAL_RELEASE_SERVICE_ENABLED = false
-    errors = view.validateBeforeSave({title: l3, set_assignment: '1', assignment: assignment}, [])
-
+    errors = nameLengthHelper(view, 40, true, 30, '0')
     equal errors.length, 0
 
-
   test "allows discussion to save when title < MAX_NAME_LENGTH chars if MAX_NAME_LENGTH is custom, required and post_to_sis is true", ->
     view = @editView({ withAssignment: true})
-    assignment = view.assignment
-    assignment.attributes.post_to_sis = '1'
-    l1 = 'aaaaaaaaaa'
-
-    ENV.MAX_NAME_LENGTH = 20
-    ENV.MAX_NAME_LENGTH_REQUIRED_FOR_ACCOUNT = true
-    ENV.IS_LARGE_ROSTER = true
-    ENV.CONDITIONAL_RELEASE_SERVICE_ENABLED = false
-    errors = view.validateBeforeSave({title: l1, set_assignment: '1', assignment: assignment}, [])
-
+    errors = nameLengthHelper(view, 30, true, 40, '1')
     equal errors.length, 0
 
   test 'conditional release editor is updated on tab change', ->