sending last name to turnitin

test plan
* submit assignment to turnitin
* verify that canvas gets an originality score
* verify that the student's last name in turnitin is their last name (not 'Student')
	* for students with no last name in canvas we still send 'Student'

Change-Id: I1e66ae0041be26b82ebed9324d7cde3057047048
Reviewed-on: https://gerrit.instructure.com/14566
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>

Author: wbhumphrey

lib/turnitin.rb

@@ -313,8 +313,9 @@ def prepare_params(command, fcmd, args)
           params[:ufn] = user.name
           params[:uln] = "Course"
         else
-          params[:ufn] = user.name
-          params[:uln] = "Student"
+          params[:ufn] = user.first_name
+          params[:uln] = user.last_name
+          params[:uln] = "Student" if params[:uln].empty?
         end
       end
       if course

spec/lib/turnitin_spec.rb

@@ -169,6 +169,24 @@ def turnitin_submission
 
       @turnitin_api.request_md5(md5_params).should eql(post_params[:md5])
     end
+
+    it "should get a first and last name for users" do
+      args = @turnitin_submit_args.clone
+      args[:user].name = "User"
+
+      params = @turnitin_api.prepare_params(:create_user, '2', args)
+
+      params[:ufn].should=="User"
+      params[:uln].should_not be_empty
+
+      args = @turnitin_submit_args.clone
+      args[:user].name = "First Last"
+      args[:user].sortable_name = "Last, First"
+
+      params = @turnitin_api.prepare_params(:create_user, '2', args)
+      params[:ufn].should=="First"
+      params[:uln].should=="Last"
+    end
   end
 
   describe "#request_md5" do