remove non-draft-state features from quizzes

fixes CNVS-16048

test plan:
  - do regression testing around publishing / unpublishing quizzes
    - all publishing / unpublishing scenarios should work correctly
    - make sure to check publishing on:
      - quizzes#index
      - quizzes#show
      - from modules
      - from module items
    - make sure that warnings about unpublished quizzes work
    - make sure that warnings about not being able to unpublish quizzes with
      submissions work
    - make sure that the module sequence footer still works on the quizzes page
    - make sure we can still review published quizzes in speedgrader

Change-Id: I1112e3b28ed6388077bfc165056bb1ab0d84b3fd
Reviewed-on: https://gerrit.instructure.com/42258
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Trevor deHaan <tdehaan@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: James Williams  <jamesw@instructure.com>

Author: Derek DeVries

app/coffeescripts/models/PublishableModuleItem.coffee

@@ -33,17 +33,15 @@ define [
       assignment:       -> "#{@baseUrl()}/assignments/#{@get('id')}"
       discussion_topic: -> "#{@baseUrl()}/discussion_topics/#{@get('id')}"
       module:           -> "#{@baseUrl()}/modules/#{@get('id')}"
-      quiz: ->
-        action = if @get('published') then 'publish' else 'unpublish'
-        "/courses/#{@get('course_id')}/quizzes/#{action}"
+      quiz:             -> "#{@baseUrl()}/quizzes/#{@get('id')}"
 
     toJSONs:
       generic: ->          module_item: @attributes
       #attachment: ->       hidden: !@get('published')
       wiki_page: ->        wiki_page: @attributes
       assignment: ->       assignment: @attributes
       discussion_topic: -> @attributes
-      quiz: ->             quizzes: [@get('id')]
+      quiz: ->             quiz: @attributes
       module: ->           module: @attributes
 
     disabledMessages:

app/controllers/quizzes/quizzes_controller.rb

@@ -57,7 +57,6 @@ class Quizzes::QuizzesController < ApplicationController
   def index
     return unless authorized_action(@context, @current_user, :read)
     return unless tab_enabled?(@context.class::TAB_QUIZZES)
-    return index_legacy unless @context.feature_enabled?(:draft_state)
 
     can_manage = is_authorized_action?(@context, @current_user, :manage_assignments)
 
@@ -131,37 +130,6 @@ def index
     log_asset_access("quizzes:#{@context.asset_string}", "quizzes", 'other')
   end
 
-  # TODO: update non-DS specs to use the DS version and remove this entirely
-  # as it is no longer available in the UI
-  def index_legacy
-    @quizzes = @context.quizzes.active.include_assignment.sort_by do |quiz|
-      [
-        (quiz.assignment ? quiz.assignment.due_at : quiz.lock_at) || CanvasSort::Last,
-        Canvas::ICU.collation_key(quiz.title || CanvasSort::First)
-      ]
-    end
-
-    @unpublished_quizzes = @quizzes.select{|q| !q.available?}
-    @quizzes = @quizzes.select{|q| q.available?}
-    @assignment_quizzes = @quizzes.select{|q| q.assignment_id}
-    @open_quizzes = @quizzes.select{|q| q.quiz_type == 'practice_quiz'}
-    @surveys = @quizzes.select{|q| q.quiz_type == 'survey' || q.quiz_type == 'graded_survey' }
-
-    # needed by _quiz_summary.html.erb
-    @submissions_hash = if @current_user.present?
-      @current_user
-        .quiz_submissions
-          .where('quizzes.context_id=? AND quizzes.context_type=?', @context, @context.class.to_s)
-          .includes(:quiz)
-          .each_with_object({}) { |sub, user_subs| user_subs[sub.quiz_id] = sub }
-    else
-      {}
-    end
-
-    log_asset_access("quizzes:#{@context.asset_string}", "quizzes", 'other')
-    render action: "index_legacy"
-  end
-
   def show
     if @quiz.deleted?
       flash[:error] = t('errors.quiz_deleted', "That quiz has been deleted")
@@ -385,9 +353,6 @@ def update
       respond_to do |format|
         @quiz.transaction do
           overrides = delete_override_params
-          if !@context.feature_enabled?(:draft_state) && params[:activate]
-            @quiz.with_versioning(true) { @quiz.publish! }
-          end
           notify_of_update = value_to_boolean(params[:quiz][:notify_of_update])
           params[:quiz][:notify_of_update] = false
 
@@ -397,7 +362,7 @@ def update
             old_assignment.id = @quiz.assignment.id
           end
 
-          auto_publish = @context.feature_enabled?(:draft_state) && @quiz.published?
+          auto_publish = @quiz.published?
           @quiz.with_versioning(auto_publish) do
             params[:quiz].delete(:only_visible_to_overrides) unless @context.feature_enabled?(:differentiated_assignments)
             # using attributes= here so we don't need to make an extra

app/helpers/quizzes_helper.rb

@@ -20,15 +20,9 @@ module QuizzesHelper
   RE_EXTRACT_BLANK_ID = /['"]question_\w+_(.*?)['"]/
 
   def needs_unpublished_warning?(quiz=@quiz, user=@current_user)
-    if quiz.feature_enabled?(:draft_state)
-      return false unless can_publish(quiz)
-      show_unpublished_changes = true
-    else
-      return false unless can_read(quiz)
-      show_unpublished_changes = can_publish(quiz)
-    end
+    return false unless can_publish(quiz)
 
-    !quiz.available? || (show_unpublished_changes && quiz.unpublished_changes?)
+    !quiz.available? || quiz.unpublished_changes?
   end
 
   def can_read(quiz, user=@current_user)
@@ -46,15 +40,7 @@ def unpublished_quiz_warning
       :wrapper => '<strong class=unpublished_quiz_warning>\1</strong>')
   end
 
-  def unpublished_changes_warning
-    I18n.t(
-      '*You have made unpublished changes to this quiz.* '+
-      'These changes will not appear for students until you publish or ' +
-      'republish the quiz.',
-      :wrapper => '<strong class=unpublished_quiz_warning>\1</strong>')
-  end
-
-  def draft_state_unsaved_changes_warning
+  def unsaved_changes_warning
     I18n.t(
       '*You have made changes to the questions in this quiz.* '+
       'These changes will not appear for students until you ' +
@@ -63,19 +49,11 @@ def draft_state_unsaved_changes_warning
   end
 
   def quiz_published_state_warning(quiz=@quiz)
-    if !quiz.available?
-      unpublished_quiz_warning
-    else
-      if quiz.feature_enabled? :draft_state
-        draft_state_unsaved_changes_warning
-      else
-        unpublished_changes_warning
-      end
-    end
+    !quiz.available? ? unpublished_quiz_warning : unsaved_changes_warning
   end
 
   def display_save_button?(quiz=@quiz)
-    quiz.available? && quiz.feature_enabled?(:draft_state) && can_publish(quiz)
+    quiz.available? && can_publish(quiz)
   end
 
   def render_score(score, precision=2)

app/models/quizzes/quiz.rb

@@ -99,10 +99,9 @@ def self.polymorphic_names
   sanitize_field :description, CanvasSanitize::SANITIZE
   copy_authorized_links(:description) { [self.context, nil] }
 
-  before_save :generate_quiz_data_on_publish, :if => :needs_republish?
+  before_save :generate_quiz_data_on_publish, :if => :workflow_state_changed?
   before_save :build_assignment
   before_save :set_defaults
-  before_save :flag_columns_that_need_republish
   after_save :update_assignment
   after_save :touch_context
   after_save :regrade_if_published
@@ -179,30 +178,6 @@ def generate_quiz_data_on_publish
   end
   private :generate_quiz_data_on_publish
 
-  # @return [Boolean] Whether the quiz has unsaved changes due for a republish.
-  def needs_republish?
-    # TODO: remove this conditional and the non-DS scenario once Draft State is
-    # permanently turned on
-    if context.feature_enabled?(:draft_state)
-      return true if @publishing || workflow_state_changed?
-
-    # pre-draft state we need ability to republish things. Since workflow_state
-    # stays available, we need to flag when we're forcing to publish!
-    else
-      return true if @publishing
-    end
-  end
-
-  # some attributes require us to republish for non-draft state
-  # We can safely remove this when draft state is permanent
-  def flag_columns_that_need_republish
-    return if context.feature_enabled?(:draft_state)
-
-    if shuffle_answers_changed? && !shuffle_answers
-      self.last_edited_at = Time.now.utc
-    end
-  end
-
   protected :set_defaults
 
   def new_assignment_id?
@@ -235,14 +210,13 @@ def link_assignment_overrides
   end
 
   def build_assignment
-    if (context.feature_enabled?(:draft_state) || self.available?) &&
-      !self.assignment_id && self.graded? && ![:assignment, :clone, :migration].include?(@saved_by)
+    if !self.assignment_id && self.graded? && ![:assignment, :clone, :migration].include?(@saved_by)
       assignment = self.assignment
       assignment ||= self.context.assignments.build(:title => self.title, :due_at => self.due_at, :submission_types => 'online_quiz')
       assignment.assignment_group_id = self.assignment_group_id
       assignment.only_visible_to_overrides = self.only_visible_to_overrides
       assignment.saved_by = :quiz
-      if context.feature_enabled?(:draft_state) && !deleted?
+      unless deleted?
         assignment.workflow_state = self.published? ? 'published' : 'unpublished'
       end
       assignment.save
@@ -445,7 +419,7 @@ def update_assignment
         a.assignment_group_id = self.assignment_group_id
         a.saved_by = :quiz
         a.workflow_state = 'published' if a.deleted?
-        if context.feature_enabled?(:draft_state) && !deleted?
+        unless deleted?
           a.workflow_state = self.published? ? 'published' : 'unpublished'
         end
         @notify_of_update ||= a.workflow_state_changed? && a.published?
@@ -1115,8 +1089,7 @@ def self.serialization_excludes
     can :submit
 
     given do |user, session|
-      (feature_enabled?(:draft_state) ? published? : true) &&
-        context.grants_right?(user, session, :read)
+      published? && context.grants_right?(user, session, :read)
     end
     can :read
 
@@ -1217,10 +1190,8 @@ def unpublish
   end
 
   def publish!
-    @publishing = true
     publish
     save!
-    @publishing = false
     self
   end
 
@@ -1305,9 +1276,8 @@ def questions_regraded_since(created_at)
     question_regrades.count
   end
 
-  # override for draft state
   def available?
-    feature_enabled?(:draft_state) ? published? : workflow_state == 'available'
+    published?
   end
 
   delegate :feature_enabled?, to: :context