allow single character usernames fixes #5818

Change-Id: Ied53f5d44ec0a2ae38a4917af69bbc41eee90868
Reviewed-on: https://gerrit.instructure.com/5966
Reviewed-by: JT Olds <jt@instructure.com>
Tested-by: Hudson <hudson@instructure.com>

Author: ccutrer

app/models/pseudonym.rb

@@ -43,11 +43,12 @@ class Pseudonym < ActiveRecord::Base
   attr_accessor :path, :path_type
 
   acts_as_authentic do |config|
-    config.validates_format_of_login_field_options = {:with => /\A\w[\w\.\+\-_@ =]+\z/}
+    config.validates_format_of_login_field_options = {:with => /\A\w[\w\.\+\-_@ =]*\z/}
     config.login_field :unique_id
     config.validations_scope = :account_id
     config.perishable_token_valid_for = 30.minutes
     config.validates_length_of_password_field_options = { :minimum => 6, :if => :require_password? }
+    config.validates_length_of_login_field_options = {:within => 1..100}
   end
 
   def require_password?

spec/lib/sis_csv_importer_spec.rb

@@ -782,18 +782,18 @@ def gen_ssha_password(password)
 
     end
 
-    it "should catch active-record-level errors, like too short unique_id" do
+    it "should catch active-record-level errors, like invalid unique_id" do
       before_user_count = User.count
       before_pseudo_count = Pseudonym.count
       importer = process_csv_data(
         "user_id,login_id,first_name,last_name,email,status",
-        "U1,u1,User,Uno,user@example.com,active"
+        "U1,@,User,Uno,user@example.com,active"
       )
       user = User.find_by_email('user@example.com')
       user.should be_nil
 
       importer.errors.map(&:last).should == []
-      importer.warnings.map(&:last).should == ["Failed saving user. Internal error: unique_id is too short (minimum is 3 characters)"]
+      importer.warnings.map(&:last).should == ["Failed saving user. Internal error: unique_id is invalid"]
       [User.count, Pseudonym.count].should == [before_user_count, before_pseudo_count]
     end
 

spec/models/pseudonym_spec.rb

@@ -24,6 +24,13 @@
     user_model
     factory_with_protected_attributes(Pseudonym, valid_pseudonym_attributes)
   end
+
+  it "should allow single character usernames" do
+    user_model
+    pseudonym_model
+    @pseudonym.unique_id = 'c'
+    @pseudonym.save!
+  end
 
   it "should associate to another user" do
     user_model