Skip to content

Commit 1990e41

Browse files
committed
Changes wording on usage rights
This commit modifies the wording shown on the restricted access dialog. It also makes it so that the restricted access dialog is able to be submitted without specifying a copyright holder. It makes a small styling change to fix spacing between the warning icon and the message text as well. fixes CNVS-18021 refs CNVS-18015 Test Plan: - Enable Usage Rights - Upload a file - Click to publish it. - The warning should say "Before publishing, you must set usage rights on your files." - The warning icon should be spaced away from the "B" in Before. - You should be able to publish the file without filling in the Copyright Holder field. Change-Id: I0b0c7e97d13c05459516a34de7a4ad86818178d6 Reviewed-on: https://gerrit.instructure.com/47323 Reviewed-by: Dan Minkevitch <dan@instructure.com> Tested-by: Jenkins <jenkins@instructure.com> QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com> Product-Review: Cosme Salazar <cosme@instructure.com>
1 parent 2e16cd3 commit 1990e41

2 files changed

Lines changed: 2 additions & 5 deletions

File tree

app/coffeescripts/react_files/components/RestrictedDialogForm.coffee

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -82,10 +82,6 @@ define [
8282
if (values.use_justification == 'choose')
8383
$(@refs.usageSelection.refs.usageRightSelection.getDOMNode()).errorBox(I18n.t('You must specify a usage right.'))
8484
return false
85-
# No copyright specified
86-
if (!values.copyright and @refs.usageSelection.refs.copyright?)
87-
$(@refs.usageSelection.refs.copyright.getDOMNode()).errorBox(I18n.t('You must specify the copyright holder.'))
88-
return false
8985

9086
# We need to first set usage rights before handling the setting of
9187
# restricted access things.
@@ -141,7 +137,7 @@ define [
141137
div {className: 'RestrictedDialogForm__banner col-xs-12'},
142138
span {className: 'alert'},
143139
i {className: 'icon-warning RestrictedDialogForm__warning'}
144-
I18n.t('Before publishing you must set usage rights on your files. This is set by your account admin. If you have problems please contact them.')
140+
I18n.t('Before publishing, you must set usage rights on your files.')
145141

146142
###
147143
# Renders out the restricted access form

app/stylesheets/pages/react_files/_RestrictedDialogForm.scss

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,4 +15,5 @@
1515

1616
.RestrictedDialogForm__warning {
1717
color: $canvas-alert;
18+
margin-right: 10px;
1819
}

0 commit comments

Comments
 (0)