show correct assignment course home for admin users

test plan:
* create a course
* set the course home page to the "Assignment List"
* should be able to edit assignments on the front page
 as an admin (should not show the student view)

closes #CNVS-23280

Change-Id: I9ddb5debe2b413f9865d5356c7cbb44f4a4f5128
Reviewed-on: https://gerrit.instructure.com/67813
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: James Williams  <jamesw@instructure.com>

Author: maneframe

app/coffeescripts/views/assignments/IndexView.coffee

@@ -113,7 +113,7 @@ define [
 
     ensureContentStyle: ->
       # when loaded from homepage, need to change content style
-      if window.location.href.indexOf('assignments') == -1
+      if !@canManage() && window.location.href.indexOf('assignments') == -1
         $("#content").css("padding", "0em")
 
     filterKeyBindings: =>

app/controllers/application_controller.rb

@@ -1971,6 +1971,30 @@ def set_js_wiki_data(opts = {})
     js_env hash
   end
 
+  def set_js_assignment_data
+    rights = [:manage_assignments, :manage_grades, :read_grades]
+    permissions = @context.rights_status(@current_user, *rights)
+    permissions[:manage] = permissions[:manage_assignments]
+    js_env({
+      :URLS => {
+        :new_assignment_url => new_polymorphic_url([@context, :assignment]),
+        :course_url => api_v1_course_url(@context),
+        :sort_url => reorder_course_assignment_groups_url(@context),
+        :assignment_sort_base_url => course_assignment_groups_url(@context),
+        :context_modules_url => api_v1_course_context_modules_path(@context),
+        :course_student_submissions_url => api_v1_course_student_submissions_url(@context)
+      },
+      :PERMISSIONS => permissions,
+      :DIFFERENTIATED_ASSIGNMENTS_ENABLED => @context.feature_enabled?(:differentiated_assignments),
+      :VALID_DATE_RANGE => CourseDateRange.new(@context),
+      :assignment_menu_tools => external_tools_display_hashes(:assignment_menu),
+      :discussion_topic_menu_tools => external_tools_display_hashes(:discussion_topic_menu),
+      :quiz_menu_tools => external_tools_display_hashes(:quiz_menu),
+      :current_user_has_been_observer_in_this_course => @context.user_has_been_observer?(@current_user),
+      :observed_student_ids => ObserverEnrollment.observed_student_ids(@context, @current_user)
+    })
+  end
+
   def google_docs_connection
     ## @real_current_user first ensures that a masquerading user never sees the
     ## masqueradee's files, but in general you may want to block access to google

app/controllers/assignments_controller.rb

@@ -43,29 +43,7 @@ def index
       # It'd be nice to do this as an after_create, but it's not that simple
       # because of course import/copy.
       @context.require_assignment_group
-
-      rights = [:manage_assignments, :manage_grades, :read_grades]
-      permissions = @context.rights_status(@current_user, *rights)
-      permissions[:manage] = permissions[:manage_assignments]
-      js_env({
-        :URLS => {
-          :new_assignment_url => new_polymorphic_url([@context, :assignment]),
-          :course_url => api_v1_course_url(@context),
-          :sort_url => reorder_course_assignment_groups_url,
-          :assignment_sort_base_url => course_assignment_groups_url,
-          :context_modules_url => api_v1_course_context_modules_path(@context),
-          :course_student_submissions_url => api_v1_course_student_submissions_url(@context)
-        },
-        :PERMISSIONS => permissions,
-        :DIFFERENTIATED_ASSIGNMENTS_ENABLED => @context.feature_enabled?(:differentiated_assignments),
-        :VALID_DATE_RANGE => CourseDateRange.new(@context),
-        :assignment_menu_tools => external_tools_display_hashes(:assignment_menu),
-        :discussion_topic_menu_tools => external_tools_display_hashes(:discussion_topic_menu),
-        :quiz_menu_tools => external_tools_display_hashes(:quiz_menu),
-        :current_user_has_been_observer_in_this_course => @context.user_has_been_observer?(@current_user),
-        :observed_student_ids => ObserverEnrollment.observed_student_ids(@context, @current_user)
-      })
-
+      set_js_assignment_data # in application_controller.rb, because the assignments page can be shared with the course home
 
       respond_to do |format|
         format.html do

app/controllers/courses_controller.rb

@@ -1583,7 +1583,8 @@ def show
         @padless = true
       when 'assignments'
         add_crumb(t('#crumbs.assignments', "Assignments"))
-        set_urls_and_permissions_for_assignment_index
+        set_js_assignment_data
+        js_env(:COURSE_HOME => true)
         get_sorted_assignments
       when 'modules'
         add_crumb(t('#crumbs.modules', "Modules"))
@@ -2333,22 +2334,6 @@ def changed_settings(changes, new_settings, old_settings=nil)
     changes
   end
 
-  def set_urls_and_permissions_for_assignment_index
-    permissions = {manage: false}
-    js_env({
-      :COURSE_HOME => true,
-      :URLS => {
-        :new_assignment_url => new_polymorphic_url([@context, :assignment]),
-        :course_url => api_v1_course_url(@context),
-        :context_modules_url => api_v1_course_context_modules_path(@context),
-        :course_student_submissions_url => api_v1_course_student_submissions_url(@context)
-      },
-      :PERMISSIONS => permissions,
-      :current_user_has_been_observer_in_this_course => @context.user_has_been_observer?(@current_user),
-      :observed_student_ids => ObserverEnrollment.observed_student_ids(@context, @current_user)
-    })
-  end
-
   def ping
     render json: {success: true}
   end

app/views/courses/show.html.erb

@@ -128,7 +128,8 @@
     js_bundle :context_modules
     css_bundle :context_modules2
   when 'assignments'
-    js_bundle :assignments
+    js_bundle :assignment_index
+    css_bundle :new_assignments
   when 'syllabus'
     js_bundle :syllabus
     css_bundle :tinymce