Enchance a11y on dashboard activity feed

Fixes CNVS-14501

Makes the show/hide more and remove options in the dashboard activity
feed show all the time, not just on mouseover, in order to improve
keyboard a11y.

Adds aria-label to the context link informing a screenreader user where
that link is going to go.

Test Plan:

1) Give yourself at least one announcement, conversation message,
   assignment notification, and discussion. Easiest way is to create a
   a course and add an announcement, send a message to yourself from
   another user, add an assignment, and add a discussion.
2) Visit the dashboard (localhost:3000/)
3) Verify that the list of notifications is navigable with the keyboard
   only, because you can see from the get go that the 'show more' option
   and remove/ignore option.
4) Using a screenreader, navigate to the notification heading, then onto
   the course name link. Verify that you hear label text like
   "Visit Course Discussions" or similar. This should help SR users only
   click that option if that's what they want, so they keep looking for
the "Show More" option (it's one link further through the tab flow) if
that's what they want instead.

Change-Id: I0726510a351f16768d98657e9891cb7a1c162be3
Reviewed-on: https://gerrit.instructure.com/41417
Reviewed-by: Joel Hough <joel@instructure.com>
Product-Review: Aaron Cannon <acannon@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>

Author: mcwqy9

app/helpers/dashboard_helper.rb

@@ -73,10 +73,27 @@ def activity_category_links(category, items)
 
     contexts.map do |name, url|
       url = nil if category == 'Conversation'
-      url.present? ? "<a href=\"#{url}\">#{h(name)}</a>" : h(name)
+      url.present? ? "<a href=\"#{url}\" aria-label=\"#{accessibility_category_label(category)}\">#{h(name)}</a>" : h(name)
     end.to_sentence.html_safe
   end
 
+  def accessibility_category_label(category)
+    case category
+    when "Announcement"
+      return I18n.t('helpers.dashboard_helper.announcement_label', "Visit Course Announcements")
+    when "Conversation"
+      return I18n.t('helpers.dashboard_helper.conversation_label', "Visit Conversations")
+    when "Assignment"
+      return I18n.t('helpers.dashboard_helper.assignment_label', "Visit Course Assignments")
+    when "DiscussionTopic"
+      return I18n.t('helpers.dashboard_helper.discussion_label', "Visit Course Discussions")
+    when "AssessmentRequest"
+      return I18n.t('helpers.dashboard_helper.peer_review_label', "Visit Course Peer Reviews")
+    else
+      raise "Unknown activity category"
+    end
+  end
+
   def category_details_label(category)
     case category
     when "Announcement"

app/stylesheets/pages/dashboard/_dashboard_activity.sass

@@ -62,13 +62,10 @@ $ignore-col-width: 50px
 
 .toggle-details
   display: block
-  text-align: left
-  text-indent: -9999px
+  text-align: right
+  text-indent: 0
   &:hover
     text-decoration: none
-  &:focus
-    text-indent: 0
-    text-align: right
 
 .details_container
   display: none
@@ -82,9 +79,6 @@ $ignore-col-width: 50px
     line-height: 250%
     &:hover
       background: $hover-color
-      .ignore-item
-        text-align: center
-        text-indent: 0
 
   .date
     font-size: 11px
@@ -98,11 +92,8 @@ $ignore-col-width: 50px
 .ignore-item
   float: none
   display: block
-  text-align: left
-  text-indent: -9999px
-  &:focus
-    text-indent: 0
-    text-align: center
+  text-align: center
+  text-indent: 0
 
 .content_summary
   display: block