grade calculator: ignore pending_review submissions

fixes CNVS-26685

Test plan:
  * make and take a quiz with multiple choice and essay questions
  * the student's quiz grade should not be included in their current
    score on the grades-overview page (or in the api)
  * the partial quiz grade *will* affect their "final" score.

Change-Id: I70252375aac87c73e25b9e3dd7f3af4555826a97
Reviewed-on: https://gerrit.instructure.com/75754
Reviewed-by: Keith T. Garner <kgarner@instructure.com>
Reviewed-by: Jeremy Neander <jneander@instructure.com>
Reviewed-by: Spencer Olson <solson@instructure.com>
Tested-by: Jenkins
QA-Review: KC Naegle <knaegle@instructure.com>
Product-Review: Cameron Matheson <cameron@instructure.com>

Author: cmatheson

lib/grade_calculator.rb

@@ -54,7 +54,7 @@ def compute_scores
         except(:order, :select).
         for_user(@user_ids).
         where(assignment_id: @assignments.map(&:id)).
-        select("submissions.id, user_id, assignment_id, score, excused")
+        select("submissions.id, user_id, assignment_id, score, excused, submissions.workflow_state")
     submissions_by_user = @submissions.group_by(&:user_id)
 
     result = []
@@ -150,6 +150,9 @@ def create_group_sums(submissions, user_id, ignore_ungraded=true)
         # ignore submissions for muted assignments
         s = nil if @ignore_muted && a.muted?
 
+        # ignore pending_review quiz submissions
+        s = nil if ignore_ungraded && s.try(:pending_review?)
+
         {
           assignment: a,
           submission: s,

spec/lib/grade_calculator_spec.rb

@@ -372,6 +372,21 @@ def nil_graded_assignment
       expect(@user.enrollments.first.computed_final_score).to eql(48.41)
     end
 
+    it "ignores pending_review submissions" do
+      course_with_student(active_all: true)
+      a1 = @course.assignments.create! name: "fake quiz", points_possible: 50
+      a2 = @course.assignments.create! name: "assignment", points_possible: 50
+
+      s1 = a1.grade_student(@student, grade: 25).first
+      Submission.update_all({workflow_state: "pending_review"}, {id: s1.id})
+
+      a2.grade_student(@student, grade: 50)
+
+      enrollment = @student.enrollments.first.reload
+      expect(enrollment.computed_current_score).to eq 100.0
+      expect(enrollment.computed_final_score).to eq 75.0
+    end
+
     it "should not include unpublished assignments" do
       two_graded_assignments
       @assignment2.unpublish