patch several specs to cleanup DOM state

Not cleaning up the DOM after tests that put markup into "fixtures"
can cause inconsistent starting state for other specs.

This takes several specs that do that and cleans them up in my push
to have less fragile aux builds

Change-Id: Id83a5724b9ea23d5d6879eae08f7ae29c8a3f7f2
Reviewed-on: https://gerrit.instructure.com/52335
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Product-Review: Ethan Vizitei <evizitei@instructure.com>
QA-Review: Ethan Vizitei <evizitei@instructure.com>
Tested-by: Ethan Vizitei <evizitei@instructure.com>

Author: evizitei

spec/coffeescripts/flashNotificationSpec.coffee

@@ -2,12 +2,15 @@ define [
   'jquery'
   'compiled/jquery.rails_flash_notifications'
 ], ($) ->
+  fixtures = null
   module 'FlashNotifications',
     setup: ->
-      @fixture = $('<div id="flash_message_holder"/><div id="flash_screenreader_holder"/>').appendTo('#fixtures')
+      fixtures = document.getElementById("fixtures")
+      flashHtml = "<div id='flash_message_holder'/><div id='flash_screenreader_holder'/>"
+      fixtures.innerHTML = flashHtml
       $.initFlashContainer()
     teardown: ->
-      @fixture.remove()
+      fixtures.innerHTML = ""
 
   test 'text notification', ->
     $.flashMessage('here is a thing')

spec/coffeescripts/views/SearchViewSpec.coffee

@@ -39,6 +39,7 @@ define [
       clock.restore()
       server.restore()
       searchView.remove()
+      $("#fixtures").empty()
 
   # asserts match and order of rendered items
   assertRenderedItems = (names=[]) ->

spec/coffeescripts/views/SelectViewSpec.coffee

@@ -19,6 +19,7 @@ define [
       view.$el.appendTo $('#fixtures')
     teardown: ->
       view.remove()
+      $("#fixtures").empty()
 
   test 'onChange it updates the model', ->
     view.model = new Backbone.Model

spec/coffeescripts/views/SyllabusViewSpec.coffee

@@ -141,6 +141,7 @@ define [
       @clock.restore()
       tz.restore(@tzSnapshot)
       @server.restore()
+      document.getElementById("fixtures").innerHTML = ""
 
     render: ->
       @view.render()

spec/coffeescripts/views/courses/roster/InvitationsViewSpec.coffee

@@ -5,24 +5,21 @@ define [
   'helpers/assertions'
 ], ($, InvitationsView, RosterUser, assert) ->
 
-  view = null
-  server = null
-
   module 'InvitationsView',
     setup: ->
     teardown: ->
 
   buildView = (enrollment)->
     model = new RosterUser( enrollments: [enrollment] )
     model.currentRole = 'student'
-    view = new InvitationsView(model: model)
+    new InvitationsView(model: model)
 
   test 'knows when invitation is pending', ->
     enrollment = {id: 1, role: 'student', enrollment_state: 'invited'}
-    buildView enrollment
+    view = buildView enrollment
     equal view.invitationIsPending(), true
 
   test 'knows when invitation is not pending', ->
     enrollment = {id: 1, role: 'student', enrollment_state: 'accepted'}
-    buildView enrollment
+    view = buildView enrollment
     equal view.invitationIsPending(), false

spec/coffeescripts/views/groups/manage/GroupCategoriesViewSpec.coffee

@@ -8,6 +8,8 @@ define [
   clock = null
   view = null
   categories = null
+  wrapper = null
+  sanbox = null
 
   module 'GroupCategoriesView',
     setup: ->
@@ -18,16 +20,19 @@ define [
         {id: 1, name: "group set 1"}
         {id: 2, name: "group set 2"}
       ]
+      sinon.stub(categories, "fetch").returns([])
       view = new GroupCategoriesView
         collection: categories
       view.render()
-      view.$el.appendTo($(document.body))
+      wrapper = document.getElementById("fixtures")
+      wrapper.innerHTML = ""
+      view.$el.appendTo($("#fixtures"))
 
     teardown: ->
       fakeENV.teardown()
       clock.restore()
       view.remove()
-      $('.group_categories_area').remove()
+      wrapper.innerHTML = ""
 
   test 'render tab and panel elements', ->
     # find the tabs

spec/coffeescripts/views/quizzes/IndexViewSpec.coffee

@@ -10,7 +10,7 @@ define [
   'helpers/jquery.simulate'
 ], (Backbone, Quiz, QuizCollection, IndexView, QuizItemGroupView, NoQuizzesView, $, fakeENV) ->
 
-  fixtures = $('#fixtures')
+  fixtures = null
 
   indexView = (assignments, open, surveys) ->
     $('<div id="content"></div>').appendTo fixtures
@@ -53,12 +53,16 @@ define [
       permissions:     permissions
       flags:           flags
       urls:            urls
-    view.$el.appendTo $('#fixtures')
+    view.$el.appendTo fixtures
     view.render()
 
   module 'IndexView',
-    setup: -> fakeENV.setup()
-    teardown: -> fakeENV.teardown()
+    setup: ->
+      fixtures = $("#fixtures")
+      fakeENV.setup()
+    teardown: ->
+      fakeENV.teardown()
+      fixtures.empty()
 
   # hasNoQuizzes
   test '#hasNoQuizzes if assignment and open quizzes are empty', ->

spec/coffeescripts/views/wiki/WikiPageRevisionsViewSpec.coffee

@@ -4,7 +4,10 @@ define [
   'compiled/views/wiki/WikiPageRevisionsView'
 ], ($, WikiPageRevisionsCollection, WikiPageRevisionsView) ->
 
-  module 'WikiPageRevisionsView'
+  module 'WikiPageRevisionsView',
+    setup: ->
+    teardown: ->
+      document.getElementById("fixtures").innerHTML = ""
 
   test 'selecting a model/view sets the selected attribute on the model', ->
     fixture = $('<div id="main"><div id="content"></div></div>').appendTo('#fixtures')