spec: rspec2 --tags for parallel_excluded specs

Change-Id: I20bf507acb2d0c26d34220d8e52fdf02cbde3e12
Reviewed-on: https://gerrit.instructure.com/32627
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Shawn Meredith <shawn@instructure.com>
Product-Review: Shawn Meredith <shawn@instructure.com>
QA-Review: Shawn Meredith <shawn@instructure.com>

Author: smeredith0506

lib/tasks/parallelized.rake

@@ -16,6 +16,7 @@ unless ARGV.any? { |a| a =~ /\Agems/ }
     task :nonselenium, :count do |t, args|
       Rake::Task['spec:single'].execute #first rake task to run the files that fail in parallel in a single thread
 
+      #bug funky exit_codes resolved in ruby193p288 fix when resolved
       if File.zero?('tmp/parallel_log/rspec.failures')
         Rake::Task['parallel:nonseleniumparallel'].invoke(args[:count])
       else
@@ -32,11 +33,22 @@ unless ARGV.any? { |a| a =~ /\Agems/ }
       Rake::Task['parallel:spec'].invoke(count, '', '', test_files.join(' '))
     end
 
+    task :selenium_tags, :test_files, :tag do |t, args|
+      require "parallelized_specs"
+      puts 'starting single threaded selenium specs'
+      #fix better logging as tags matures
+      output = `bundle exec rspec --format doc #{args[:test_files]} --tag #{args[:tag]}`
+      puts output
+      #bug funky exit_codes resolved in ruby193p288 fix when resolved
+      output.match(/(\d) failure/).to_a.last.to_i != 0 ? exit(1) : puts('all non_parallel selenium specs passed')
+    end
+
     task :selenium, :count, :build_section do |t, args|
       require "parallelized_specs"
       #used to split selenium builds when :build_section is set split it in two.
       test_files = FileList['spec/selenium/**/*_spec.rb'] + FileList['vendor/plugins/*/spec_canvas/selenium/*_spec.rb']
       test_files = test_files.to_a.sort_by! { |file| File.size(file) }
+
       args[:build_section].to_i == 0 ? section = nil : section = args[:build_section].to_i
 
       unless section.nil?
@@ -69,6 +81,12 @@ unless ARGV.any? { |a| a =~ /\Agems/ }
       end
       test_files.map! { |f| "#{Rails.root}/#{f}" }
       test_files.each { |f| puts f }
+
+      unless CANVAS_RAILS2
+        Rake::Task['parallel:selenium_tags'].invoke(test_files.join(' '), 'non_parallel')
+      end
+
+      puts 'starting paralellized selenium spec runtime'
       Rake::Task['parallel:spec'].invoke(args[:count], '', '', test_files.join(' '))
     end
 
@@ -84,4 +102,4 @@ unless ARGV.any? { |a| a =~ /\Agems/ }
       Rake::Task['parallel:spec'].invoke(count, '', '', test_files.join(' '))
     end
   end
-end
+end

spec/selenium/content_migrations_spec.rb

@@ -77,7 +77,7 @@ def test_selective_content(source_course=nil)
   @course.assignments.count.should == 1
 end
 
-describe "content migrations" do
+describe "content migrations", :non_parallel do
   include_examples "in-process server selenium tests"
 
   context "common cartridge importing" do

spec/selenium/course_settings_spec.rb

@@ -165,7 +165,7 @@ def test_select_standard_for(context)
   end
 
   context "right sidebar" do
-    it "should allow entering student view from the right sidebar" do
+    it "should allow entering student view from the right sidebar", :non_parallel do
       @fake_student = @course.student_view_student
       get "/courses/#{@course.id}/settings"
       f(".student_view_button").click

spec/selenium/dashboard_spec.rb

@@ -112,7 +112,7 @@ def disable_recent_activity_header_course_link
       a2 = @course.account.announcements.create!(:message => "another announcement")
 
       get "/"
-      messages =  ffj("#dashboard .global-message .message.user_content")
+      messages = ffj("#dashboard .global-message .message.user_content")
       messages.size.should == 2
       messages[0].text.should == a2.message
       messages[1].text.should == a1.message
@@ -122,7 +122,7 @@ def disable_recent_activity_header_course_link
       announcement = @course.account.announcements.create!(:message => "blah blah http://random-survey-startup.ly/?some_GET_parameter_by_which_to_differentiate_results={{ACCOUNT_DOMAIN}}")
 
       get "/"
-      fj("#dashboard .global-message .message.user_content").text.should == announcement.message.gsub("{{ACCOUNT_DOMAIN}}",@course.account.domain)
+      fj("#dashboard .global-message .message.user_content").text.should == announcement.message.gsub("{{ACCOUNT_DOMAIN}}", @course.account.domain)
     end
 
     it "should show appointment stream items on the dashboard" do
@@ -215,25 +215,21 @@ def check_list_text(list_element, text, should_have_text = true)
       f('.to-do-list > li').should include_text(assignment.submission_action_string)
 
       #verify assignment is in drop down
-      assignment_menu = f('#assignments_menu_item')
-      driver.action.move_to(assignment_menu).perform
-      keep_trying_until { assignment_menu.should include_text("To Turn In") }
-      assignment_menu.should include_text(assignment.title)
+      driver.execute_script %{$('#assignments_menu_item').addClass('hover');}
+      wait_for_ajaximations
+      f('#assignments_menu_item').should include_text("To Turn In")
+      f('#assignments_menu_item').should include_text(assignment.title)
     end
 
     it "should display course name in course menu" do
       @course.update_attributes(:start_at => 2.days.from_now, :conclude_at => 4.days.from_now, :restrict_enrollments_to_course_dates => false)
       Enrollment.update_all(:created_at => 1.minute.ago)
 
       get "/"
-
-      course_menu = f('#courses_menu_item')
-      
-      driver.action.move_to(course_menu).perform
-      keep_trying_until {
-        course_menu.should include_text('My Courses')
-        course_menu.should include_text(@course.name)  
-      }
+      driver.execute_script %{$('#courses_menu_item').addClass('hover');}
+      wait_for_ajaximations
+      f('#courses_menu_item').should include_text('My Courses')
+      f('#courses_menu_item').should include_text(@course.name)
     end
 
     it "should display should display student groups in course menu" do
@@ -244,14 +240,10 @@ def check_list_text(list_element, text, should_have_text = true)
       Enrollment.update_all(:created_at => 1.minute.ago)
 
       get "/"
-
-      course_menu = f('#courses_menu_item')
-
-      driver.action.move_to(course_menu).perform
-      keep_trying_until {
-        course_menu.should include_text(group.name)
-        course_menu.should include_text('Current Groups')
-      }
+      driver.execute_script %{$('#courses_menu_item').addClass('hover');}
+      wait_for_ajaximations
+      f('#courses_menu_item').should include_text(group.name)
+      f('#courses_menu_item').should include_text('Current Groups')
     end
 
     it "should go to /courses when the courses nav item is clicked" do
@@ -349,10 +341,10 @@ def check_list_text(list_element, text, should_have_text = true)
       c1.save!
       get "/"
 
-      driver.action.move_to(f('#courses_menu_item')).perform
-      course_menu = f('#menu_enrollments')
-      keep_trying_until { course_menu.should be_displayed }
-      course_menu.should_not include_text(c1.name)
+      driver.execute_script %{$('#courses_menu_item').addClass('hover');}
+      item = fj('#menu_enrollments')
+      item.should be_displayed
+      item.should_not include_text(c1.name)
     end
 
     it "should show recent feedback and it should work" do
@@ -403,10 +395,12 @@ def check_list_text(list_element, text, should_have_text = true)
       f('.to-do-list > li').should include_text('Grade ' + assignment.title)
 
       #verify assignment is in drop down
-      assignment_menu = f('#assignments_menu_item')
-      driver.action.move_to(assignment_menu).perform
-      keep_trying_until { assignment_menu.should include_text("To Grade") }
-      assignment_menu.should include_text(assignment.title)
+      driver.execute_script %{$('#assignments_menu_item').addClass('hover');}
+
+      wait_for_ajaximations
+
+      f('#assignments_menu_item').should include_text("To Grade")
+      f('#assignments_menu_item').should include_text(assignment.title)
     end
 
     it "should show submitted essay quizzes in the todo list" do
@@ -436,27 +430,25 @@ def check_list_text(list_element, text, should_have_text = true)
 
         get "/"
 
-        course_menu = f('#courses_menu_item')
-        driver.action.move_to(course_menu).perform
-        keep_trying_until do
-          course_menu.should include_text('My Courses')
-          course_menu.should include_text('Customize')
-          course_menu.should include_text('View all courses')
-        end
+        driver.execute_script %{$('#courses_menu_item').addClass('hover');}
+        wait_for_ajaximations
+
+        fj('#courses_menu_item').should include_text('My Courses')
+        fj('#courses_menu_item').should include_text('Customize')
+        fj('#courses_menu_item').should include_text('View all courses')
       end
 
+
       it "should allow customization if there are sufficient course invitations" do
         20.times { course_with_teacher({:user => user_with_communication_channel(:user_state => :creation_pending), :active_course => true}) }
-
         get "/"
 
-        course_menu = f('#courses_menu_item')
-        driver.action.move_to(course_menu).perform
-        keep_trying_until do
-          course_menu.should include_text('My Courses')
-          course_menu.should include_text('Customize')
-          course_menu.should include_text('View all courses')
-        end
+        driver.execute_script %{$('#courses_menu_item').addClass('hover');}
+        wait_for_ajaximations
+
+        fj('#courses_menu_item').should include_text('My Courses')
+        fj('#courses_menu_item').should include_text('Customize')
+        fj('#courses_menu_item').should include_text('View all courses')
       end
 
       it "should allow customization if all courses are already favorited" do
@@ -467,13 +459,11 @@ def check_list_text(list_element, text, should_have_text = true)
         }
 
         get "/"
+        driver.execute_script %{$('#courses_menu_item').addClass('hover');}
+        wait_for_ajaximations
 
-        course_menu = f('#courses_menu_item')
-        driver.action.move_to(course_menu).perform
-        keep_trying_until do
-          course_menu.should include_text('My Courses')
-          course_menu.should include_text('Customize')
-        end
+        fj('#courses_menu_item').should include_text('My Courses')
+        fj('#courses_menu_item').should include_text('Customize')
       end
 
       it "should allow customization even before the course ajax request comes back" do

spec/spec_helper.rb

@@ -26,7 +26,10 @@ def include_examples(*args)
 end
 
 unless CANVAS_RAILS2 || ENV['NO_RERUN']
-  require 'timeout'
+  Spec.configure do |c|
+   c.treat_symbols_as_metadata_keys_with_true_values = true
+  end 
+
   RSpec.configure do |c|
     c.around(:each) do |example|
       attempts = 0