assignments: no changing group status after students submit (frontend)

closes CNVS-11813

Test plan:
  * make an assignment
  * submit some homework
  * make sure you can't turn it into a group assignment
  * repeat the above steps for a group assignment (you shouldn't be
    able to make it an individual assignment, or change the group
    category)

Change-Id: I9fe2cb1b01972492e3707307281cee7954f8c56c
Reviewed-on: https://gerrit.instructure.com/32717
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: Cameron Matheson <cameron@instructure.com>

Author: cmatheson

app/coffeescripts/views/assignments/GroupCategorySelector.coffee

@@ -38,8 +38,6 @@ define [
       # delete this after Ifa654f7d853fd167d5bfbaee6184657209d58272 hits prod
       gc.id = gc.id.toString() for gc in @groupCategories
 
-      @startedOutAsGroupAssignment = @parentModel.get('group_category_id')?
-
     showGroupCategoryCreateDialog: =>
       if @$groupCategoryID.val() == 'new'
         # TODO: Yikes, we need to pull the javascript out of manage_groups.js
@@ -56,30 +54,30 @@ define [
     toggleGroupCategoryOptions: =>
       @$groupCategoryOptions.toggleAccessibly @$hasGroupCategory.prop('checked')
 
-      @$(".group_submission_warning").toggleAccessibly(
-        !@startedOutAsGroupAssignment and
-        @$hasGroupCategory.prop('checked') and
-        @parentModel.attributes.has_submitted_submissions
-      )
-
       if @$hasGroupCategory.prop('checked') and @groupCategories.length == 0
         @showGroupCategoryCreateDialog()
 
     toJSON: =>
       frozenAttributes = @parentModel.frozenAttributes()
+      groupCategoryFrozen = _.include frozenAttributes, 'group_category_id'
+      groupCategoryLocked = @parentModel.attributes.has_submitted_submissions
 
       groupCategoryId: @parentModel.groupCategoryId()
       groupCategories: @groupCategories
       gradeGroupStudentsIndividually: @parentModel.gradeGroupStudentsIndividually()
-      frozenAttributes: frozenAttributes
-      groupCategoryIdFrozen: _.include(frozenAttributes, 'group_category_id')
+      groupCategoryLocked: groupCategoryLocked
+
+      hasGroupCategoryDisabled:  groupCategoryFrozen || groupCategoryLocked
+      gradeIndividuallyDisabled: groupCategoryFrozen
+      groupCategoryIdDisabled:   groupCategoryFrozen || groupCategoryLocked
+
       nested: @nested
       prefix: 'assignment' if @nested
 
     filterFormData: (data) =>
       hasGroupCategory = data.has_group_category
       delete data.has_group_category
-      unless hasGroupCategory is '1'
+      if hasGroupCategory == '0'
         data.group_category_id = null
         data.grade_group_students_individually = false
       data

app/views/jst/assignments/GroupCategorySelector.handlebars

@@ -4,31 +4,25 @@
 
 <div class="form-column-right">
   <div class="border border-trbl border-round">
-
     {{!-- Group Assignment selection --}}
     <label class="checkbox flush">
       {{checkbox "has_group_category"
         id="assignment_has_group_category"
         prefix=prefix
         checked=groupCategoryId
-        disabled=groupCategoryIdFrozen}}
+        disabled=hasGroupCategoryDisabled}}
       {{#t "is_group_assignment"}}This is a Group Assignment{{/t}}
     </label>
 
     {{!-- Individual grading? --}}
     <div class="nested">
-      <div class="group_submission_warning alert" style="display:none">
-        {{#t "students_already_submitted_warning"}}Prior individual submissions will
-        not be counted as group submissions and will show incorrectly in
-        speedgrader.{{/t}}
-      </div>
       <div id="group_category_options" style="{{hiddenUnless groupCategoryId}}">
         <label class="checkbox" >
           {{checkbox "grade_group_students_individually"
             id=null
             prefix=prefix
             checked=gradeGroupStudentsIndividually
-            disabled=groupCategoryIdFrozen}}
+            disabled=gradeIndividuallyDisabled}}
           {{#t "grade_group_students_individually"}}
             Assign Grades to Each Student Individually
           {{/t}}
@@ -40,7 +34,7 @@
         </label>
         <select id="assignment_group_category_id"
           name="{{#if nested}}assignment[group_category_id]{{else}}group_category_id{{/if}}"
-          {{disabledIfIncludes frozenAttributes "group_category_id"}}>
+          {{disabledIf groupCategoryIdDisabled}}>
           {{#each groupCategories}}
             <option value="{{id}}" {{selectedIf ../groupCategoryId this.id}}>
               {{name}}
@@ -52,5 +46,14 @@
         </select>
       </div>
     </div>
+
+    {{#if groupCategoryLocked}}
+      <div class="group_category_locked_explanation alert"
+           style="margin: 15px 20px 0">
+        {{#t "group_category_locked_explanation"}}Students have already
+        submitted homework on this assignment, so group settings cannot be
+        changed.{{/t}}
+      </div>
+    {{/if}}
   </div>
 </div>

spec/coffeescripts/views/assignments/EditViewSpec.coffee

@@ -102,32 +102,23 @@ define [
     view = editView description: "<p>&lt;E&gt;</p>"
     equal view.$description.val().match(desc), desc
 
-  # fragile spec
-  checkWarning = (view, showsWarning) ->
-    view.$("#assignment_toggle_advanced_options").click()
-    equal view.$(".group_submission_warning").is(":visible"), false, 'warning isn\'t initially shown'
-    view.$("#assignment_has_group_category").click()
-    # equal view.$(".group_submission_warning").is(":visible"), showsWarning, 'warning has expected visibility of visible:'+showsWarning
-    view.$("#assignment_has_group_category").click()
-    equal view.$(".group_submission_warning").is(":visible"), false, 'warning is hidden after clicking again'
-
-  module 'EditView: warning on group status change',
+  module 'EditView: group category locked',
     setup: ->
       fakeENV.setup()
       window.addGroupCategory = sinon.stub()
     teardown: ->
       fakeENV.teardown()
       window.addGroupCategory = null
 
-  test 'warns when has submitted submissions', ->
+  test 'lock down group category after students submit', ->
     view = editView has_submitted_submissions: true
-    checkWarning view, true
-
-  test 'does not warn if starting with a group', ->
-    view = editView has_submitted_submissions: true, group_category_id: 1
-    checkWarning view, false
-
-  test 'does not warn if there are no submitted submissions', ->
-    view = editView()
-    checkWarning view, false
-
+    ok view.$(".group_category_locked_explanation").length
+    ok view.$("#assignment_has_group_category").prop("disabled")
+    ok view.$("#assignment_group_category_id").prop("disabled")
+    ok !view.$("[type=checkbox][name=grade_group_students_individually]").prop("disabled")
+
+    view = editView has_submitted_submissions: false
+    equal view.$(".group_category_locked_explanation").length, 0
+    ok !view.$("#assignment_has_group_category").prop("disabled")
+    ok !view.$("#assignment_group_category_id").prop("disabled")
+    ok !view.$("[type=checkbox][name=grade_group_students_individually]").prop("disabled")