disable speedgrader in courses with large_roster flag.

fixes CNVS-3111

test plan:
  * enable the 'large_roster' flag on a course and verify
    that, in that course, links to the speedgrader are
    hidden in the following places:
    - graded discussion topic gear menu;
    - graded discussion entry gear menu
    - quiz show page (right side bar);
    - assignment show page (right side bar);
    - gradebook1 assignment header dropdown;
    - gradebook1 grade cell popup;
    - gradebook2 assignment header dropdown;
    - gradebook2 grade cell popup;
  * also verify that attempting to navigate to the
    speedgrader directly via /courses/:id/gradebook path
    displays a message that the speedgrader is disabled
    for that course.

Change-Id: Iab82bd7281208f6e2d3745bb3184c90068090535
Reviewed-on: https://gerrit.instructure.com/17710
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Eric Berry <ericb@instructure.com>
Tested-by: Eric Berry <ericb@instructure.com>
Reviewed-by: Joel Hough <joel@instructure.com>
QA-Review: Myller de Araujo <myller@instructure.com>

Author: Mark Ericksen

app/coffeescripts/SubmissionDetailsDialog.coffee

@@ -15,10 +15,15 @@ define [
 
   class SubmissionDetailsDialog
     constructor: (@assignment, @student, @options) ->
+      speedGraderUrl = if @options.speed_grader_enabled
+        "#{@options.context_url}/gradebook/speed_grader?assignment_id=#{@assignment.id}#%7B%22student_id%22%3A#{@student.id}%7D"
+      else
+        null
+
       @url = @options.change_grade_url.replace(":assignment", @assignment.id).replace(":submission", @student.id)
       @submission = $.extend {}, @student["assignment_#{@assignment.id}"],
         assignment: @assignment
-        speedGraderUrl: "#{@options.context_url}/gradebook/speed_grader?assignment_id=#{@assignment.id}#%7B%22student_id%22%3A#{@student.id}%7D"
+        speedGraderUrl: speedGraderUrl
         loading: true
       @dialog = $('<div class="use-css-transitions-for-show-hide" style="padding:0;"/>')
       @dialog.html(submissionDetailsDialog(@submission))

app/coffeescripts/gradebook2/GradebookHeaderMenu.coffee

@@ -21,6 +21,7 @@ define [
       templateLocals =
         assignmentUrl: "#{@gradebook.options.context_url}/assignments/#{@assignment.id}"
         speedGraderUrl: "#{@gradebook.options.context_url}/gradebook/speed_grader?assignment_id=#{@assignment.id}"
+      templateLocals.speedGraderUrl = null unless @gradebook.options.speed_grader_enabled
       @$menu = $(gradebookHeaderMenuTemplate(templateLocals)).insertAfter(@$trigger)
       @$trigger.kyleMenu(noButton:true)
       @$menu

app/controllers/discussion_topics_controller.rb

@@ -180,6 +180,7 @@ def edit
   def show
     parent_id = params[:parent_id]
     @topic = @context.all_discussion_topics.find(params[:id])
+    @presenter = DiscussionTopicPresenter.new(@topic, @current_user)
     @assignment = if @topic.for_assignment?
       AssignmentOverrideApplicator.assignment_overridden_for(@topic.assignment, @current_user)
     else
@@ -244,8 +245,12 @@ def show
               :INITIAL_POST_REQUIRED => @initial_post_required,
               :THREADED => @topic.threaded?
             }
-            if @topic.for_assignment? && @topic.assignment.grants_right?(@current_user, session, :grade)
-              env_hash[:SPEEDGRADER_URL_TEMPLATE] = named_context_url(@topic.assignment.context, :speed_grader_context_gradebook_url, :assignment_id => @topic.assignment.id, :anchor => {:student_id => ":student_id"}.to_json)
+            if @topic.for_assignment? &&
+               @topic.assignment.grants_right?(@current_user, session, :grade) && @presenter.allows_speed_grader?
+              env_hash[:SPEEDGRADER_URL_TEMPLATE] = named_context_url(@topic.assignment.context,
+                                                                      :speed_grader_context_gradebook_url,
+                                                                      :assignment_id => @topic.assignment.id,
+                                                                      :anchor => {:student_id => ":student_id"}.to_json)
             end
             js_env :DISCUSSION => env_hash
 

app/controllers/gradebook2_controller.rb

@@ -24,6 +24,7 @@ def show
           :grading_standard =>  @context.grading_standard_enabled? && (@context.grading_standard.try(:data) || GradingStandard.default_grading_standard),
           :course_is_concluded => @context.completed?,
           :gradebook_is_editable => @gradebook_is_editable,
+          :speed_grader_enabled => @context.allows_speed_grader?,
         }
 
     end

app/controllers/gradebooks_controller.rb

@@ -74,12 +74,12 @@ def grade_summary
             )
             # pre-cache the assignment group for each assignment object
             @assignments.each { |a| a.assignment_group = @groups.find { |g| g.id == a.assignment_group_id } }
-            all_submissions = if @context.large_roster?
-                                []
-                              else
+            all_submissions = if @context.allows_gradebook_uploads?
                                 # Yes, fetch *all* submissions for this course; otherwise the view will end up doing a query for each
                                 # assignment in order to calculate grade distributions
                                 @context.submissions.all(:select => "submissions.assignment_id, submissions.score, submissions.grade, submissions.quiz_submission_id")
+                              else
+                                []
                               end
 
             @submissions_by_assignment = submissions_by_assignment(all_submissions)
@@ -200,7 +200,8 @@ def show
 
           # this can't happen in the slave block because this may trigger
           # writes in ContextModule
-          js_env :assignment_groups => assignment_groups_json
+          js_env :assignment_groups => assignment_groups_json,
+                 :speed_grader_enabled => @context.allows_speed_grader?
           set_gradebook_warnings(@groups, @just_assignments)
           if params[:view] == "simple"
             @headers = false
@@ -375,16 +376,25 @@ def submissions_zip_upload
   end
 
   def speed_grader
-    if authorized_action(@context, @current_user, [:manage_grades, :view_all_grades])
-      @assignment = @context.assignments.active.find(params[:assignment_id])
-      respond_to do |format|
-        format.html {
-          @headers = false
-          @outer_frame = true
-          log_asset_access("speed_grader:#{@context.asset_string}", "grades", "other")
-          render :action => "speed_grader"
-        }
-        format.json { render :json => @assignment.speed_grader_json(@current_user, service_enabled?(:avatars)) }
+    if !@context.allows_speed_grader?
+      flash[:notice] = t(:speed_grader_disabled, 'SpeedGrader is disabled for this course')
+      return redirect_to(course_gradebook_path(@context))
+    end
+
+    return unless authorized_action(@context, @current_user, [:manage_grades, :view_all_grades])
+
+    @assignment = @context.assignments.active.find(params[:assignment_id])
+
+    respond_to do |format|
+      format.html do
+        @headers = false
+        @outer_frame = true
+        log_asset_access("speed_grader:#{@context.asset_string}", "grades", "other")
+        render :action => "speed_grader"
+      end
+
+      format.json do
+        render :json => @assignment.speed_grader_json(@current_user, service_enabled?(:avatars))
       end
     end
   end

app/controllers/quizzes_controller.rb

@@ -68,7 +68,7 @@ def new
 
   def statistics
     if authorized_action(@quiz, @current_user, :read_statistics)
-      if @context.large_roster?
+      if !@context.allows_speed_grader?
         flash[:notice] = t "#application.notices.page_disabled_for_course", "That page has been disabled for this course"
         redirect_to named_context_url(@context, :context_quiz_url, @quiz)
         return

app/models/course.rb

@@ -1074,6 +1074,13 @@ def allows_gradebook_uploads?
     !large_roster?
   end
 
+  # Public: Determine if SpeedGrader is enabled for the Course.
+  #
+  # Returns a boolean.
+  def allows_speed_grader?
+    !large_roster?
+  end
+
   def enrollment_allows(user, session, permission)
     return false unless user && permission
 

app/presenters/discussion_topic_presenter.rb

@@ -112,4 +112,22 @@ def comments_disabled?
       topic.context.is_a?(Course) &&
       topic.context.settings[:lock_all_announcements]
   end
+
+  # Public: Determine if the discussion's context has a large roster flag set.
+  #
+  # Returns a boolean.
+  def large_roster?
+    if topic.context.respond_to?(:large_roster?)
+      topic.context.large_roster?
+    else
+      topic.context.try(:context).try(:large_roster?)
+    end
+  end
+
+  # Public: Determine if SpeedGrader should be enabled for the Discussion Topic.
+  #
+  # Returns a boolean.
+  def allows_speed_grader?
+    !large_roster?
+  end
 end

app/views/assignments/_grade_assignment.html.erb

@@ -19,11 +19,13 @@
 <% end %>
 
 <ul class='page-action-list'>
-  <li>
-    <a target="_blank" href="<%= context_url(@context, :speed_grader_context_gradebook_url, :assignment_id => @assignment.id) %>">
-      <i class="icon-speed-grader"></i> SpeedGrader&trade;
-    </a>
-  </li>
+  <% if @context.allows_speed_grader? %>
+    <li>
+      <a target="_blank" href="<%= context_url(@context, :speed_grader_context_gradebook_url, :assignment_id => @assignment.id) %>">
+        <i class="icon-speed-grader"></i> SpeedGrader&trade;
+      </a>
+    </li>
+  <% end %>
 
   <% if @current_student_submissions.present? %>
     <% if @assignment.submission_types && @assignment.submission_types.match(/(online_upload|online_text_entry|online_url)/)%>

app/views/discussion_topics/show.html.erb

@@ -1,7 +1,6 @@
 <%
   content_for :page_title, join_title( t(:topic, "Topic"), @topic.title)
 %>
-<% @presenter = DiscussionTopicPresenter.new(@topic, @current_user) %>
 <% content_for :auto_discovery do %>
   <% if @context_enrollment %>
     <%= auto_discovery_link_tag(:atom, feeds_topic_format_path(@topic.id, @context_enrollment.feed_code, :atom), {:title => t(:discussion_atom_feed_title, "Discussion Atom Feed")}) %>
@@ -91,7 +90,7 @@
                   <li><a href="<%= context_url(@context, :context_discussion_topic_url, @topic.id) %>" data-method="delete" rel="nofollow" data-confirm="<%= t :confirm_delete_discussion, 'Are you sure you want to delete this discussion?' %>"><i class="icon-trash"></i> <%= t :delete, 'Delete' %></a></li>
                 <% end %>
 
-                <% if @presenter.can_grade?(@current_user) %>
+                <% if @presenter.can_grade?(@current_user) && @presenter.allows_speed_grader? %>
                   <li><a href="<%= context_url(@topic.assignment.context,
                                                :speed_grader_context_gradebook_url,
                                                :assignment_id => @topic.assignment.id) %>">