fix account reports query cross-shard

fixes CNVS-33224

test plan:
 * create an account on a separate shard, but without its own domain
 * you should still be able to view its settings page following the
   link from site admin

Change-Id: If181662c83cc78e52d17ac372afb2add596dd153
Reviewed-on: https://gerrit.instructure.com/100718
Reviewed-by: Simon Williams <simon@instructure.com>
Tested-by: Jenkins
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>

Author: ccutrer

app/controllers/accounts_controller.rb

@@ -659,16 +659,18 @@ def settings
     if authorized_action(@account, @current_user, :read)
       @available_reports = AccountReport.available_reports if @account.grants_right?(@current_user, @session, :read_reports)
       if @available_reports
-        scope = @account.account_reports.where("report_type=name").most_recent
-        @last_complete_reports = AccountReport.from("unnest('{#{@available_reports.keys.join(',')}}'::text[]) report_types (name),
-              LATERAL (#{scope.complete.to_sql}) account_reports ").
-            order("report_types.name").
-            preload(:attachment).
-            index_by(&:report_type)
-        @last_reports = AccountReport.from("unnest('{#{@available_reports.keys.join(',')}}'::text[]) report_types (name),
-              LATERAL (#{scope.to_sql}) account_reports ").
-            order("report_types.name").
-            index_by(&:report_type)
+        @account.shard.activate do
+          scope = @account.account_reports.where("report_type=name").most_recent
+          @last_complete_reports = AccountReport.from("unnest('{#{@available_reports.keys.join(',')}}'::text[]) report_types (name),
+                LATERAL (#{scope.complete.to_sql}) account_reports ").
+              order("report_types.name").
+              preload(:attachment).
+              index_by(&:report_type)
+          @last_reports = AccountReport.from("unnest('{#{@available_reports.keys.join(',')}}'::text[]) report_types (name),
+                LATERAL (#{scope.to_sql}) account_reports ").
+              order("report_types.name").
+              index_by(&:report_type)
+        end
       end
       load_course_right_side
       @account_users = @account.account_users

spec/controllers/accounts_controller_spec.rb

@@ -16,7 +16,7 @@
 # with this program. If not, see <http://www.gnu.org/licenses/>.
 #
 
-require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
+require File.expand_path(File.dirname(__FILE__) + '/../sharding_spec_helper')
 
 describe AccountsController do
   def account_with_admin_logged_in(opts = {})
@@ -540,6 +540,19 @@ def cross_listed_course
       expect(assigns[:last_reports].first.last).to eq report
     end
 
+    context "sharding" do
+      specs_require_sharding
+
+      it "loads even from the wrong shard" do
+        account_with_admin_logged_in
+
+        @shard1.activate do
+          get 'settings', account_id: @account
+          expect(response).to be_success
+        end
+      end
+    end
+
     context "external_integration_keys" do
       before(:once) do
         ExternalIntegrationKey.key_type :external_key0, rights: { write: true }