fix some errors in coffeescript files

ryankshaw · ryankshaw · commit 36bd600ad422 · 2017-02-06T16:11:24.000Z
mostly things that tried to use a module without requiring it Change-Id: Iedb2826534ce842a41333c5757195e88d2a4ce38 Reviewed-on: https://gerrit.instructure.com/101114 Tested-by: Jenkins Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
diff --git a/app/coffeescripts/behaviors/firefox_number_fix.coffee b/app/coffeescripts/behaviors/firefox_number_fix.coffee
@@ -2,9 +2,9 @@
 # Should be removed once firefox fixes the issue and is used in production version of firefox.
 define [
   'jquery'
-  'jquery.instructure_forms'
   'i18n!firefox_fix'
-], ($) ->
+  'jquery.instructure_forms'
+], ($, I18n) ->
 
   onChangeHandler = (e) ->
     numInput = $(e.target)
diff --git a/app/coffeescripts/bundles/legacy/external_content_success.coffee b/app/coffeescripts/bundles/legacy/external_content_success.coffee
@@ -8,7 +8,7 @@ require [
 
   dataReady = (data, service_id) ->
 
-    e = jQuery.Event( "externalContentReady" )
+    e = $.Event( "externalContentReady" )
     e.contentItems = data
     e.service_id = service_id
     parentWindow.$(parentWindow).trigger "externalContentReady", e
diff --git a/app/coffeescripts/bundles/student_group_dialog.coffee b/app/coffeescripts/bundles/student_group_dialog.coffee
@@ -1,8 +1,10 @@
 require [
+  'jquery'
   'compiled/models/Group'
   'compiled/models/GroupCategory'
   'compiled/views/groups/manage/GroupEditView'
-], (Group, GroupCategory, GroupEditView) ->
+], ($, Group, GroupCategory, GroupEditView) ->
+
   group = new Group(ENV.group)
   groupCategory = new GroupCategory(ENV.group_category)
   @editView = new GroupEditView({model: group, groupCategory: groupCategory, nameOnly: true})
diff --git a/app/coffeescripts/collections/PaginatedCollection.coffee b/app/coffeescripts/collections/PaginatedCollection.coffee
@@ -17,9 +17,10 @@
 #
 
 define [
+  'jquery'
   'Backbone'
   'underscore'
-], (Backbone, _) ->
+], ($, Backbone, _) ->
 
   capitalize = (string = '') ->
     string.charAt(0).toUpperCase() + string.substring(1).toLowerCase()
diff --git a/app/coffeescripts/jquery.kylemenu.coffee b/app/coffeescripts/jquery.kylemenu.coffee
@@ -46,7 +46,7 @@ define [
               else
                 tabKey = { which: $.ui.keyCode.TAB }
 
-              pressTab = jQuery.Event('keydown', tabKey)
+              pressTab = $.Event('keydown', tabKey)
               @$trigger.focus().trigger(pressTab)
 
         popupInstance = @$menu.data('popup')
diff --git a/app/coffeescripts/react_files/utils/setUsageRights.coffee b/app/coffeescripts/react_files/utils/setUsageRights.coffee
@@ -47,6 +47,6 @@ define [
       },
       success: (data) ->
         callback(true, data)
-      error: ->
+      error: (data) ->
         callback(false, data)
     )
diff --git a/app/coffeescripts/registration/signupDialog.coffee b/app/coffeescripts/registration/signupDialog.coffee
@@ -65,7 +65,7 @@ define [
           $("input[name='#{htmlEscape data.error.input_name}']").
           next('.error_message').
           text(htmlEscape error_msg)
-          $.screenReaderFlashMessage(error_message)
+          $.screenReaderFlashMessage(error_msg)
 
     $node.dialog
       resizable: false
diff --git a/app/coffeescripts/str/TextHelper.coffee b/app/coffeescripts/str/TextHelper.coffee
@@ -17,9 +17,10 @@
 #
 
 define [
+  'jquery'
   'i18n!lib.text_helper'
   'str/htmlEscape'
-], (I18n, htmlEscape) ->
+], ($, I18n, htmlEscape) ->
 
   AUTO_LINKIFY_PLACEHOLDER = "LINK-PLACEHOLDER"
   AUTO_LINKIFY_REGEX = ///
diff --git a/app/coffeescripts/util/addPrivacyLinkToDialog.coffee b/app/coffeescripts/util/addPrivacyLinkToDialog.coffee
@@ -1,6 +1,7 @@
 define [
+  'jquery'
   'i18n!site'
-], (I18n) ->
+], ($, I18n) ->
 
   addPrivacyLinkToDialog = ($dialog) ->
     return unless ENV.ACCOUNT.privacy_policy_url
diff --git a/app/coffeescripts/util/mimeClass.coffee b/app/coffeescripts/util/mimeClass.coffee
@@ -1,6 +1,6 @@
 define [
   'i18n!mimeClass'
-], ->
+], (I18n) ->
 
   # this module works together with app/stylesheets/components/_MimeClassIcons.scss
   # so, given the mime-type of a file you can give it a css class name that corresponds to it.
@@ -122,4 +122,4 @@ define [
       mimeClass.mimeClasses[mimeType] = cls
 
 
-  return mimeClass
+  return mimeClass
diff --git a/app/coffeescripts/views/TreeBrowserView.coffee b/app/coffeescripts/views/TreeBrowserView.coffee
@@ -100,7 +100,7 @@ define [
 
     # focus the last item in the tree.
     focusLast: ($from) ->
-      $to = $tree.find '[role=treeitem][aria-level=1]'
+      $to = @$tree.find '[role=treeitem][aria-level=1]'
       level = 1
       # if the last item is expanded, focus the last node from the last expanded item.
       while @ariaPropIsTrue($to, 'aria-expanded') and $to.find('[role=treeitem]:first').length
diff --git a/app/coffeescripts/views/UserObserveesView.coffee b/app/coffeescripts/views/UserObserveesView.coffee
@@ -1,11 +1,12 @@
 define [
+  'jquery'
   'underscore'
   'i18n!observees'
   'jst/UserObservees'
   'jst/ExternalAuthUserObservees'
   'compiled/views/UserObserveeView'
   'compiled/views/PaginatedCollectionView'
-], (_, I18n, template, extAuthTemplate, itemView, PaginatedCollectionView) ->
+], ($, _, I18n, template, extAuthTemplate, itemView, PaginatedCollectionView) ->
 
   class UserObserveesView extends PaginatedCollectionView
     autoFetch: true
diff --git a/app/coffeescripts/views/assignments/AssignmentSettingsView.coffee b/app/coffeescripts/views/assignments/AssignmentSettingsView.coffee
@@ -1,10 +1,11 @@
 define [
+  'jquery'
   'compiled/util/round'
   'underscore'
   'compiled/views/DialogFormView'
   'jst/EmptyDialogFormWrapper'
   'jst/assignments/AssignmentSettings'
-], (round, _, DialogFormView, wrapper, assignmentSettingsTemplate) ->
+], ($, round, _, DialogFormView, wrapper, assignmentSettingsTemplate) ->
 
   class AssignmentSettingsView extends DialogFormView
     template: assignmentSettingsTemplate
diff --git a/app/coffeescripts/views/assignments/DueDateOverride.coffee b/app/coffeescripts/views/assignments/DueDateOverride.coffee
@@ -1,4 +1,5 @@
 define [
+  'jquery'
   'Backbone'
   'underscore'
   'react'
@@ -10,7 +11,7 @@ define [
   'jsx/due_dates/StudentGroupStore'
   'compiled/api/gradingPeriodsApi'
   'timezone'
-], (Backbone, _, React, ReactDOM, template, DateValidator, I18n, DueDates, StudentGroupStore, GradingPeriodsAPI, tz) ->
+], ($, Backbone, _, React, ReactDOM, template, DateValidator, I18n, DueDates, StudentGroupStore, GradingPeriodsAPI, tz) ->
 
   class DueDateOverrideView extends Backbone.View
 
diff --git a/app/coffeescripts/views/conversations/InboxHeaderView.coffee b/app/coffeescripts/views/conversations/InboxHeaderView.coffee
@@ -1,4 +1,5 @@
 define [
+  'jquery'
   'i18n!conversations'
   'underscore'
   'Backbone'
@@ -7,7 +8,7 @@ define [
   'compiled/views/conversations/SearchView'
   'vendor/bootstrap/bootstrap-dropdown'
   'vendor/bootstrap-select/bootstrap-select'
-], (I18n, _, {View}, Spinner, CourseSelectionView, SearchView) ->
+], ($, I18n, _, {View}, Spinner, CourseSelectionView, SearchView) ->
 
   class InboxHeaderView extends View
 
diff --git a/app/coffeescripts/views/wiki/WikiPageContentView.coffee b/app/coffeescripts/views/wiki/WikiPageContentView.coffee
@@ -1,8 +1,9 @@
 define [
   'jquery'
+  'underscore'
   'Backbone'
   'jst/wiki/WikiPageContent'
-], ($, Backbone, template) ->
+], ($, _, Backbone, template) ->
 
   class WikiPageContentView extends Backbone.View
     tagName: 'article'

Original file line number	Diff line number	Diff line change
`@@ -47,6 +47,6 @@ define [`
`47`	`47`	`},`
`48`	`48`	`success: (data) ->`
`49`	`49`	`callback(true, data)`
`50`		`- error: ->`
	`50`	`+ error: (data) ->`
`51`	`51`	`callback(false, data)`
`52`	`52`	`)`