Skip to content

Commit 37bd952

Browse files
committed
ignore access for completed enrollments on course user page
test plan: * have a course that restricts students from viewing in past * have a student * view the course user page for the student * conclude the enrollment * refresh the page * it should say the enrollment was completed (not inactive) closes #CNVS-33646 Change-Id: Ib7f0c58f4ffd71748a62315a1c6abd86795727fd Reviewed-on: https://gerrit.instructure.com/102478 Tested-by: Jenkins Reviewed-by: Jeremy Stanley <jeremy@instructure.com> QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com> Product-Review: James Williams <jamesw@instructure.com>
1 parent d26fb13 commit 37bd952

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

app/views/context/roster_user.html.erb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@
129129
</div>
130130
<% end %>
131131
<div style="font-size: 0.8em; padding-left: 20px; <%= hidden unless enrollment.completed? || enrollment.inactive? %>" class="completed_at_holder">
132-
<% if enrollment.inactive? %>
132+
<% if enrollment.workflow_state == 'inactive' %>
133133
<%= t 'inactive' %>
134134
<% elsif enrollment.completed_at %>
135135
<%= t 'completed_enrollment', "completed *%{completed_at}*", :completed_at => datetime_string(enrollment.completed_at), :wrapper => '<span class="completed_at">\1</span>' %>

0 commit comments

Comments
 (0)