spec: shared spec removal and refactor

Change-Id: I8011da7dd9c827e6118ded28acbacdf0aa3d5283
Reviewed-on: https://gerrit.instructure.com/18899
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jake Sorce <jake@instructure.com>
Product-Review: Jake Sorce <jake@instructure.com>
QA-Review: Jake Sorce <jake@instructure.com>

Author: smeredith0506

spec/selenium/admin/account_admin_rubrics_spec.rb

@@ -1,10 +1,39 @@
 require File.expand_path(File.dirname(__FILE__) + '/../common')
-require File.expand_path(File.dirname(__FILE__) + '/../helpers/rubrics_specs')
-describe "account rubrics" do
-  describe "shared rubric specs" do
-    let(:rubric_url) { "/accounts/#{Account.default.id}/rubrics" }
-    let(:who_to_login) { 'admin' }
-    let(:account) { Account.default }
-    it_should_behave_like "rubric tests"
-  end
-end
+require File.expand_path(File.dirname(__FILE__) + '/../helpers/rubrics_common')
+require File.expand_path(File.dirname(__FILE__) + '/../common')
+
+describe "account shared rubric specs" do
+  it_should_behave_like "in-process server selenium tests"
+
+  let(:rubric_url) { "/accounts/#{Account.default.id}/rubrics" }
+  let(:who_to_login) { 'admin' }
+  let(:account) { Account.default }
+
+  before (:each) do
+    course_with_admin_logged_in
+  end
+
+  it "should delete a rubric" do
+    should_delete_a_rubric
+  end
+  it "should edit a rubric" do
+    should_edit_a_rubric
+  end
+
+  it "should allow fractional points" do
+    should_allow_fractional_points
+  end
+
+
+  it "should round to 2 decimal places" do
+    should_round_to_2_decimal_places
+  end
+
+  it "should round to an integer when splitting" do
+    should_round_to_an_integer_when_splitting
+  end
+
+  it "should pick the lower value when splitting without room for an integer" do
+    should_pick_the_lower_value_when_splitting_without_room_for_an_integer
+  end
+end

spec/selenium/admin/sub_accounts/rubrics_spec.rb

@@ -1,11 +1,37 @@
 require File.expand_path(File.dirname(__FILE__) + '/../../common')
-require File.expand_path(File.dirname(__FILE__) + '/../../helpers/rubrics_specs')
-
-describe "sub account rubrics" do
-  describe "shared rubric specs" do
-    let(:account) { Account.create(:name => 'sub account from default account', :parent_account => Account.default) }
-    let(:rubric_url) { "/accounts/#{account.id}/rubrics" }
-    let(:who_to_login) { 'admin' }
-    it_should_behave_like "rubric tests"
+require File.expand_path(File.dirname(__FILE__) + '/../../helpers/rubrics_common')
+
+describe "sub account shared rubric specs" do
+  it_should_behave_like "in-process server selenium tests"
+  let(:account) { Account.create(:name => 'sub account from default account', :parent_account => Account.default) }
+  let(:rubric_url) { "/accounts/#{account.id}/rubrics" }
+  let(:who_to_login) { 'admin' }
+
+  before (:each) do
+    course_with_admin_logged_in
+  end
+
+  it "should delete a rubric" do
+    should_delete_a_rubric
+  end
+  it "should edit a rubric" do
+    should_edit_a_rubric
+  end
+
+  it "should allow fractional points" do
+    should_allow_fractional_points
+  end
+
+
+  it "should round to 2 decimal places" do
+    should_round_to_2_decimal_places
+  end
+
+  it "should round to an integer when splitting" do
+    should_round_to_an_integer_when_splitting
+  end
+
+  it "should pick the lower value when splitting without room for an integer" do
+    should_pick_the_lower_value_when_splitting_without_room_for_an_integer
   end
 end

spec/selenium/announcements_spec.rb

@@ -1,5 +1,4 @@
 require File.expand_path(File.dirname(__FILE__) + '/common')
-require File.expand_path(File.dirname(__FILE__) + '/helpers/discussion_announcement_specs')
 
 describe "announcements" do
   it_should_behave_like "in-process server selenium tests"
@@ -106,13 +105,171 @@ def create_announcement_manual(css_checkbox)
     describe "shared bulk topics specs" do
       let(:url) { "/courses/#{@course.id}/announcements/" }
       let(:what_to_create) { Announcement }
-      it_should_behave_like "discussion and announcement main page tests"
+
+      before (:each) do
+        @context = @course
+        5.times do |i|
+          title = "new #{i.to_s.rjust(3, '0')}"
+          what_to_create == DiscussionTopic ? @course.discussion_topics.create!(:title => title, :user => @user) : announcement_model(:title => title, :user => @user)
+        end
+        get url
+        wait_for_ajaximations
+        @checkboxes = ff('.toggleSelected')
+      end
+
+      def update_attributes_and_validate(attribute, update_value, search_term = update_value, expected_results = 1)
+        what_to_create.last.update_attributes(attribute => update_value)
+        refresh_page # in order to get the new topic information
+        replace_content(f('#searchTerm'), search_term)
+        ff('.discussionTopicIndexList .discussion-topic').count.should == expected_results
+      end
+
+      def refresh_and_filter(filter_type, filter, expected_text, expected_results = 1)
+        refresh_page # in order to get the new topic information
+        wait_for_ajaximations
+        keep_trying_until { ff('.toggleSelected').count.should == what_to_create.count }
+        filter_type == :css ? driver.execute_script("$('#{filter}').click()") : replace_content(f('#searchTerm'), filter)
+        ff('.discussionTopicIndexList .discussion-topic').count.should == expected_results
+        expected_results > 1 ? ff('.discussionTopicIndexList .discussion-topic').each { |topic| topic.should include_text(expected_text) } : (f('.discussionTopicIndexList .discussion-topic').should include_text(expected_text))
+      end
+
+      it "should bulk delete topics" do
+        5.times { |i| @checkboxes[i].click }
+        f('#delete').click
+        driver.switch_to.alert.accept
+        wait_for_ajax_requests
+        ff('.discussion-topic').count.should == 0
+        what_to_create.where(:workflow_state => 'active').count.should == 0
+      end
+
+      it "should bulk lock topics" do
+        5.times { |i| @checkboxes[i].click }
+        f('#lock').click
+        wait_for_ajax_requests
+        #TODO: check the UI to make sure the topics have a locked symbol
+        what_to_create.where(:workflow_state => 'locked').count.should == 5
+      end
+
+      it "should search by title" do
+        expected_text = 'hey there'
+        update_attributes_and_validate(:title, expected_text)
+      end
+
+      it "should search by body" do
+        body_text = 'new topic body'
+        update_attributes_and_validate(:message, body_text, 'topic')
+      end
+
+      it "should search by author" do
+        user_name = 'jake@instructure.com'
+        title = 'new one'
+        new_teacher = teacher_in_course(:course => @course, :active_all => true, :name => user_name)
+        what_to_create == DiscussionTopic ? @course.discussion_topics.create!(:title => title, :user => new_teacher.user) : announcement_model(:title => title, :user => new_teacher.user)
+        refresh_and_filter(:string, 'jake', user_name)
+      end
+
+      it "should return multiple items in the search" do
+        new_title = 'updated'
+        what_to_create.first.update_attributes(:title => "#{new_title} first")
+        what_to_create.last.update_attributes(:title => "#{new_title} last")
+        refresh_and_filter(:string, new_title, new_title, 2)
+      end
+
+      it "should filter by unread" do
+        what_to_create.last.change_read_state('unread', @user)
+        refresh_and_filter(:css, '#onlyUnread', 'new 004')
+      end
     end
 
     describe "shared main page topics specs" do
       let(:url) { "/courses/#{@course.id}/announcements/" }
       let(:what_to_create) { Announcement }
-      it_should_behave_like "discussion and announcement individual tests"
+
+      def add_attachment_and_validate
+        filename, fullpath, data = get_file("testfile5.zip")
+        f('input[name=attachment]').send_keys(fullpath)
+        type_in_tiny('textarea[name=message]', 'file attachement discussion')
+        expect_new_page_load { submit_form('.form-actions') }
+        wait_for_ajaximations
+        f('.zip').should include_text(filename)
+      end
+
+      def edit(title, message)
+        replace_content(f('input[name=title]'), title)
+        type_in_tiny('textarea[name=message]', message)
+        expect_new_page_load { submit_form('.form-actions') }
+        f('#discussion_topic .discussion-title').text.should == title
+      end
+
+      before (:each) do
+        @topic_title = 'new discussion'
+        @context = @course
+      end
+
+      it "should start a new topic" do
+        get url
+
+        expect_new_page_load { f('.btn-primary').click }
+        edit(@topic_title, 'new topic')
+      end
+
+      it "should add an attachment to a new topic" do
+        topic_title = 'new topic with file'
+        get url
+
+        expect_new_page_load { f('.btn-primary').click }
+        replace_content(f('input[name=title]'), topic_title)
+        add_attachment_and_validate
+        what_to_create.find_by_title(topic_title).attachment_id.should be_present
+      end
+
+      it "should add an attachment to a graded topic" do
+        what_to_create == DiscussionTopic ? @course.discussion_topics.create!(:title => 'graded attachment topic', :user => @user) : announcement_model(:title => 'graded attachment topic', :user => @user)
+        if what_to_create == DiscussionTopic
+          what_to_create.last.update_attributes(:assignment => @course.assignments.create!(:name => 'graded topic assignment'))
+        end
+        get url
+        expect_new_page_load { f('.discussion-title').click }
+        expect_new_page_load { f(".edit-btn").click }
+
+        add_attachment_and_validate
+      end
+
+      it "should edit a topic" do
+        edit_name = 'edited discussion name'
+        topic = what_to_create == DiscussionTopic ? @course.discussion_topics.create!(:title => @topic_title, :user => @user) : announcement_model(:title => @topic_title, :user => @user)
+        get url + "#{topic.id}"
+        expect_new_page_load { f(".edit-btn").click }
+
+        edit(edit_name, 'edit message')
+      end
+
+      it "should delete a topic" do
+        what_to_create == DiscussionTopic ? @course.discussion_topics.create!(:title => @topic_title, :user => @user) : announcement_model(:title => @topic_title, :user => @user)
+        get url
+
+        f('.toggleSelected').click
+        f('#delete').click
+        driver.switch_to.alert.accept
+        wait_for_ajaximations
+        what_to_create.last.workflow_state.should == 'deleted'
+        f('.discussionTopicIndexList').should be_nil
+      end
+
+      it "should reorder topics" do
+        3.times { |i| what_to_create == DiscussionTopic ? @course.discussion_topics.create!(:title => "new topic #{i}", :user => @user) : announcement_model(:title => "new topic #{i}", :user => @user) }
+        get url
+        wait_for_ajax_requests
+
+        topics = ff('.discussion-topic')
+        driver.action.move_to(topics[0]).perform
+        # drag first topic to second place
+        # (using topics[2] as target to get the dragging to work)
+        driver.action.drag_and_drop(fj('.discussion-drag-handle:visible', topics[0]), topics[2]).perform
+        wait_for_ajax_requests
+        new_topics = ffj('.discussion-topic') # using ffj to avoid selenium caching
+        new_topics[0].should_not include_text('new topic 0')
+      end
     end
 
     it "should create a delayed announcement" do

spec/selenium/assignments_discussion_spec.rb

@@ -1,7 +1,8 @@
 require File.expand_path(File.dirname(__FILE__) + '/helpers/assignments_common')
 
 describe "discussion assignments" do
-  it_should_behave_like "assignments selenium tests"
+  it_should_behave_like "in-process server selenium tests"
+
 
   before (:each) do
     course_with_teacher_logged_in

spec/selenium/assignments_quizzes_spec.rb

@@ -1,7 +1,8 @@
 require File.expand_path(File.dirname(__FILE__) + '/helpers/assignments_common')
 
 describe "quizzes assignments" do
-  it_should_behave_like "assignments selenium tests"
+  it_should_behave_like "in-process server selenium tests"
+
 
   before (:each) do
     course_with_teacher_logged_in

spec/selenium/calendar2_spec.rb

@@ -1,7 +1,16 @@
+require File.expand_path(File.dirname(__FILE__) + '/common')
 require File.expand_path(File.dirname(__FILE__) + '/helpers/calendar2_common')
 
 describe "calendar2" do
-  it_should_behave_like "calendar2 selenium tests"
+  it_should_behave_like "in-process server selenium tests"
+
+  before (:each) do
+    Account.default.tap do |a|
+      a.settings[:enable_scheduler] = true
+      a.settings[:show_scheduler] = true
+      a.save!
+    end
+  end
 
   def make_event(params = {})
     opts = {
@@ -635,7 +644,7 @@ def create_middle_day_assignment(name = 'new assignment')
         # click the event in the calendar
         fj('.fc-event').click
         fj("#popover-0").should be_displayed
-        expect_new_page_load  { driver.execute_script("$('.view_event_link').hover().click()") }
+        expect_new_page_load { driver.execute_script("$('.view_event_link').hover().click()") }
 
         page_title = f('.title')
         page_title.should be_displayed

spec/selenium/context_modules_spec.rb

@@ -1,8 +1,7 @@
 require File.expand_path(File.dirname(__FILE__) + '/helpers/context_modules_common')
 
 describe "context_modules" do
-  it_should_behave_like "context module tests"
-
+  it_should_behave_like "in-process server selenium tests"
   context "as a teacher" do
 
     before (:each) do