Skip to content

Commit 423f1b5

Browse files
committed
move css for #aligned_outcomes to the only place that uses it
refs: CNVS-28781 instead of loading this css on every page I moved it out into its own bundle so it can be only loaded in the one place that uses it test plan: * go to view a question bank * on the right side, there should be a "Aligned Outcomes" section. * it should be styled like it was before Change-Id: Ia9d6deb189da25c6741d11a854f03e4b42fd63ba Reviewed-on: https://gerrit.instructure.com/77312 QA-Review: Benjamin Christian Nelson <bcnelson@instructure.com> Reviewed-by: Simon Williams <simon@instructure.com> Tested-by: Jenkins Product-Review: Ryan Shaw <ryan@instructure.com>
1 parent 3743e30 commit 423f1b5

3 files changed

Lines changed: 37 additions & 37 deletions

File tree

Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,36 @@
1+
#aligned_outcomes {
2+
.outcomes {
3+
list-style-type: none;
4+
padding-left: 10px;
5+
.outcome {
6+
margin-bottom: 5px;
7+
.short_description {
8+
font-weight: bold;
9+
}
10+
.description {
11+
font-size: 0.8em;
12+
margin-left: 20px;
13+
}
14+
.mastery {
15+
margin-top: 5px;
16+
font-size: 0.7em;
17+
font-style: italic;
18+
margin-left: 20px;
19+
}
20+
}
21+
}
22+
}
23+
24+
#align_outcomes_dialog {
25+
.all_outcomes {
26+
list-style-type: none;
27+
padding-left: 10px;
28+
.outcome {
29+
padding: 2px 5px;
30+
margin-bottom: 2px;
31+
&.selected_outcome {
32+
background-color: #eee;
33+
}
34+
}
35+
}
36+
}

app/stylesheets/components/_g_instructure.scss

Lines changed: 0 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -1684,43 +1684,6 @@ body.padless-content #content, #content.padless {
16841684
}
16851685
}
16861686

1687-
#aligned_outcomes {
1688-
.outcomes {
1689-
list-style-type: none;
1690-
padding-left: 10px;
1691-
.outcome {
1692-
margin-bottom: 5px;
1693-
.short_description {
1694-
font-weight: bold;
1695-
}
1696-
.description {
1697-
font-size: 0.8em;
1698-
margin-left: 20px;
1699-
}
1700-
.mastery {
1701-
margin-top: 5px;
1702-
font-size: 0.7em;
1703-
font-style: italic;
1704-
margin-left: 20px;
1705-
}
1706-
}
1707-
}
1708-
}
1709-
1710-
#align_outcomes_dialog {
1711-
.all_outcomes {
1712-
list-style-type: none;
1713-
padding-left: 10px;
1714-
.outcome {
1715-
padding: 2px 5px;
1716-
margin-bottom: 2px;
1717-
&.selected_outcome {
1718-
background-color: #eee;
1719-
}
1720-
}
1721-
}
1722-
}
1723-
17241687
h2.h-margin-top, h3.h-margin-top, .h2.h-margin-top, .h3.h-margin-top {
17251688
margin-top: 20px;
17261689
}

app/views/question_banks/show.html.erb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
<button class="btn button-sidebar-wide disabled" disabled="true"><%= image_tag("bookmark.png", alt: "") %> <%= t 'buttons.already_bookmarked', "Already Bookmarked" %></button>
1818
<% end %>
1919
</div>
20+
<% css_bundle("aligned_outcomes") %>
2021
<h2 id="aligned_outcomes"><%= t 'headings.aligned_outcomes', "Aligned Outcomes" %></h2>
2122
<div class="rs-margin-lr rs-margin-bottom">
2223
<ul class="unstyled_list" id="aligned_outcomes_list">

0 commit comments

Comments
 (0)