include unconfirmed email addresses in user search

test plan:
 - enable new user search
 - create a user but don't confirm their email right away
 - ensure the user can be found by account search by
   email address

fixes CNVS-33430

Change-Id: I9c61e8389ee6e10d5bd133cb23ab74567e1e24ff
Reviewed-on: https://gerrit.instructure.com/95730
Tested-by: Jenkins
Reviewed-by: Steven Burnett <sburnett@instructure.com>
QA-Review: Heath Hales <hhales@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>

Author: jstanley0

lib/user_search.rb

@@ -107,7 +107,7 @@ def self.complex_sql
          WHERE communication_channels.user_id = users.id
            AND communication_channels.path_type = ?
            AND #{like_condition('communication_channels.path')}
-           AND communication_channels.workflow_state='active'))
+           AND communication_channels.workflow_state in ('active', 'unconfirmed')))
     SQL
   end
 

spec/lib/user_search_spec.rb

@@ -187,6 +187,11 @@
             cc.retire!
             expect(UserSearch.for_user_in_context("the.giver", course, user)).to eq []
           end
+
+          it 'matches unconfirmed channels' do
+            cc2 = user.communication_channels.create!(path: 'unconfirmed@example.com')
+            expect(UserSearch.for_user_in_context("unconfirmed", course, user)).to eq [user]
+          end
         end
 
         describe 'searching by a DB ID' do