Skip to content

Commit 5243433

Browse files
committed
add nofollow to links that bots are commonly retrieving that they shouldn't
Change-Id: Iff821dcd63ac1d936e8620a1713bbadace4b3afd Reviewed-on: https://gerrit.instructure.com/3663 Tested-by: Hudson <hudson@instructure.com> Reviewed-by: Brian Palmer <brianp@instructure.com>
1 parent ff179e5 commit 5243433

3 files changed

Lines changed: 4 additions & 4 deletions

File tree

app/views/context_modules/_context_module.html.erb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
<div class="clear"></div>
2626
<div style="display: none;">
2727
<span class="require_sequential_progress"><%= context_module.try_rescue(:require_sequential_progress) || nbsp %></span>
28-
<a href="<%= context_url(@context, :context_url) %>/modules/<%= context_module ? context_module.id : "{{ id }}" %>/reorder" class="reorder_items_url" style="display: none;">&nbsp;</a>
28+
<a href="<%= context_url(@context, :context_url) %>/modules/<%= context_module ? context_module.id : "{{ id }}" %>/reorder" rel="nofollow" class="reorder_items_url" style="display: none;">&nbsp;</a>
2929
</div>
3030
</div>
3131
<div class="content">
@@ -46,7 +46,7 @@
4646
<a href="<%= context_url(@context, :context_url) %>/modules/<%= context_module ? context_module.id : "{{ id }}" %>/collapse" class="collapse_module_link collapse-small">Hide module contents</a>
4747
</div>
4848
<div class="manage_module">
49-
<a href="<%= context_url(@context, :context_url) %>/modules/<%= context_module ? context_module.id : "{{ id }}" %>/items" class="add_module_item_link add-small">Add item to module</a>
49+
<a href="<%= context_url(@context, :context_url) %>/modules/<%= context_module ? context_module.id : "{{ id }}" %>/items" rel="nofollow" class="add_module_item_link add-small">Add item to module</a>
5050
<a href="#" class="add_prerequisite_link edit-small" style="display: none;">Module Settings</a>
5151
</div>
5252
<div class="progression_container">

app/views/shared/_grading_standard.html.erb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@
110110
</div>
111111
</div>
112112
<div style="display: none;" class="find_grading_standard">
113-
<a href="<%= context_url(@context, :context_grading_standards_url) %>" class="grading_standards_url" style="display: none;">&nbsp;</a>
113+
<a href="<%= context_url(@context, :context_grading_standards_url) %>" rel="nofollow" class="grading_standards_url" style="display: none;">&nbsp;</a>
114114
<div class="loading_message" style="margin: 10px; text-align: center;">
115115
Loading Grading Standards...
116116
</div>

app/views/shared/_rubric.html.erb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
<div class="rubric_association_id"><%= rubric_association ? rubric_association.id : nbsp %></div>
2828
<div class="user_id"><%= assessment ? assessment.user_id : nbsp %></div>
2929
<div class="assessment_type"><%= assessment ? assessment.assessment_type : "" %></div>
30-
<a href="<%= context_url(context, :context_rubric_association_rubric_assessment_url, rubric_association ? rubric_association.id : "{{ rubric_association_id }}", (assessment ? assessment.id : "{{ assessment_id }}")) %>" class="edit_assessment_link">&nbsp;</a>
30+
<a href="<%= context_url(context, :context_rubric_association_rubric_assessment_url, rubric_association ? rubric_association.id : "{{ rubric_association_id }}", (assessment ? assessment.id : "{{ assessment_id }}")) %>" rel="nofollow" class="edit_assessment_link">&nbsp;</a>
3131
<a href="<%= context_url(context, :context_rubric_url, "{{ rubric_id }}") %>" class="edit_rubric_url">&nbsp;</a>
3232
<% if for_context %>
3333
<a href="<%= context_url(context, :context_rubric_url, rubric ? rubric.id : "{{ id }}") %>" class="delete_rubric_url">&nbsp;</a>

0 commit comments

Comments
 (0)