spec: speed up api specs

liberal applicataion of once-ler and bulk_insert helpers, reduce runtime
from 50min -> 25min

Change-Id: I07c1952c4ead0a1c6caafc389de0b9586b27dc68
Reviewed-on: https://gerrit.instructure.com/37794
Reviewed-by: Landon Wilkins <lwilkins@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: Jon Jensen <jon@instructure.com>
QA-Review: Jon Jensen <jon@instructure.com>

Author: jenseng

app/models/folder.rb

@@ -309,6 +309,11 @@ def self.assert_path(path, context)
     @@path_lookups[key] = current_folder
   end
 
+  def self.reset_path_lookups!
+    @@root_folders = {}
+    @@path_lookups = {}
+  end
+
   def self.unfiled_folder(context)
     folder = context.folders.find_by_parent_folder_id_and_workflow_state_and_name(Folder.root_folders(context).first.id, 'visible', 'unfiled')
     unless folder

spec/apis/auth_spec.rb

@@ -21,8 +21,11 @@
 
 describe "API Authentication", type: :request do
 
-  before do
+  before :once do
     @key = DeveloperKey.create!
+  end
+
+  before :each do
     @client_id = @key.id
     @client_secret = @key.api_key
     consider_all_requests_local(false)
@@ -72,9 +75,12 @@
 
     describe "should continue to allow developer key + basic auth access" do
       # this will continue to be supported until we notify api users and explicitly phase it out
-      before do
+      before :once do
         user_with_pseudonym(:active_user => true, :username => 'test1@example.com', :password => 'test123')
         course_with_teacher(:user => @user)
+      end
+
+      before :each do
         post '/login', 'pseudonym_session[unique_id]' => 'test1@example.com', 'pseudonym_session[password]' => 'test123'
       end
 
@@ -469,7 +475,7 @@ def cas.validate_service_ticket(st)
   end
 
   describe "access token" do
-    before do
+    before :once do
       user_with_pseudonym(:active_user => true, :username => 'test1@example.com', :password => 'test123')
       course_with_teacher(:user => @user)
       @token = @user.access_tokens.create!
@@ -566,7 +572,7 @@ def check_used
   end
 
   describe "as_user_id" do
-    before do
+    before :once do
       course_with_teacher(:active_all => true)
       @course1 = @course
       course_with_student(:user => @user, :active_all => true)
@@ -722,7 +728,7 @@ def check_used
   end
 
   describe "CSRF protection" do
-    before do
+    before :once do
       course_with_teacher(:active_all => true)
       @course1 = @course
       course_with_student(:user => @user, :active_all => true)

spec/apis/error_handling_spec.rb

@@ -19,7 +19,7 @@
 require File.expand_path(File.dirname(__FILE__) + '/api_spec_helper')
 
 describe "API Error Handling", type: :request do
-  before do
+  before :once do
     user_with_pseudonym(:active_all => true)
     @token = @user.access_tokens.create!
   end

spec/apis/general_api_spec.rb

@@ -82,7 +82,7 @@ def @course.filter_attributes_for_user(hash, user, session)
   end
 
   describe "json post format" do
-    before do
+    before :once do
       course_with_teacher(:user => user_with_pseudonym, :active_all => true)
       @token = @user.access_tokens.create!(:purpose => "specs")
     end

spec/apis/locked_spec.rb

@@ -39,7 +39,7 @@ def verify_locked(*lock_info_extra)
     lock_info_extra.each { |attribute| lock_info[attribute.to_s].should_not be_nil, "expected lock_info to contain '#{attribute.to_s}'" }
   end
 
-  before(:each) do
+  before(:once) do
     course_with_student(:active_all => true)
   end
 

spec/apis/lti/grade_passback_spec.rb

@@ -19,7 +19,7 @@
 require File.expand_path(File.dirname(__FILE__) + '/../api_spec_helper')
 
 describe LtiApiController, type: :request do
-  before do
+  before :once do
     course_with_student(:active_all => true)
     @student = @user
     @course.enroll_teacher(user_with_pseudonym(:active_all => true))

spec/apis/user_content_spec.rb

@@ -19,9 +19,12 @@
 require File.expand_path(File.dirname(__FILE__) + '/api_spec_helper')
 
 describe UserContent, type: :request do
-  it "should translate course file download links to directly-downloadable urls" do
-    course_with_teacher_logged_in(:active_all => true)
+  before :once do
+    course_with_teacher(:active_all => true)
     attachment_model
+  end
+
+  it "should translate course file download links to directly-downloadable urls" do
     @assignment = @course.assignments.create!(:title => "first assignment", :description => <<-HTML)
     <p>
       Hello, students.<br>
@@ -39,7 +42,6 @@
   end
 
   it "should translate group file download links to directly-downloadable urls" do
-    course_with_teacher_logged_in(:active_all => true)
     @group = @course.groups.create!(:name => "course group")
     attachment_model(:context => @group)
     @group.add_user(@teacher)
@@ -60,8 +62,6 @@
   end
 
   it "should translate file download links to directly-downloadable urls for deleted and replaced files" do
-    course_with_teacher_logged_in(:active_all => true)
-    attachment_model
     @attachment.destroy
     attachment2 = Attachment.create!(:folder => @attachment.folder, :context => @attachment.context, :filename => @attachment.filename, :uploaded_data => StringIO.new("first"))
     @context.attachments.find(@attachment.id).id.should == attachment2.id
@@ -83,7 +83,6 @@
   end
 
   it "should not corrupt absolute links" do
-    course_with_teacher_logged_in
     attachment_model(:context => @course)
     @topic = @course.discussion_topics.create!(:title => "course topic", :user => @teacher, :message => <<-HTML)
     <p>
@@ -100,8 +99,6 @@
   end
 
   it "should translate file preview links to directly-downloadable preview urls" do
-    course_with_teacher_logged_in(:active_all => true)
-    attachment_model
     @assignment = @course.assignments.create!(:title => "first assignment", :description => <<-HTML)
     <p>
       Hello, students.<br>
@@ -119,8 +116,6 @@
   end
 
   it "should translate media comment links to embedded video tags" do
-    course_with_teacher_logged_in(:active_all => true)
-    attachment_model
     @assignment = @course.assignments.create!(:title => "first assignment", :description => <<-HTML)
     <p>
       Hello, students.<br>
@@ -149,8 +144,6 @@
   end
 
   it "should translate media comment audio tags" do
-    course_with_teacher_logged_in(:active_all => true)
-    attachment_model
     @assignment = @course.assignments.create!(:title => "first assignment", :description => <<-HTML)
     <p>
       Hello, students.<br>
@@ -175,8 +168,6 @@
   end
 
   it "should not translate links in content not viewable by user" do
-    course_with_teacher_logged_in(:active_all => true)
-    attachment_model
     @assignment = @course.assignments.create!(:title => "first assignment", :description => <<-HTML)
     <p>
       Hello, students.<br>
@@ -201,7 +192,6 @@
   end
 
   it "should prepend the hostname to all absolute-path links" do
-    course_with_teacher_logged_in(:active_all => true)
     @assignment = @course.assignments.create!(:title => "first assignment", :description => <<-HTML)
     <p>
       Hello, students.<br>
@@ -229,7 +219,6 @@
   end
 
   it "should not choke on funny email addresses" do
-    course_with_teacher_logged_in(:active_all => true)
     @wiki_page = @course.wiki.front_page
     @wiki_page.body = "<a href='mailto:djmankiewicz@homestarrunner,com'>e-nail</a>"
     @wiki_page.workflow_state = 'active'
@@ -242,7 +231,6 @@
   context "data api endpoints" do
     context "course context" do
       it "should process links to each type of object" do
-        course_with_teacher_logged_in(:active_all => true)
         @wiki_page = @course.wiki.front_page
         @wiki_page.body = <<-HTML
         <p>
@@ -322,7 +310,6 @@
 
     context "user context" do
       it "should process links to each type of object" do
-        course_with_teacher_logged_in(:active_all => true)
         @topic = @course.discussion_topics.create!(:message => <<-HTML)
             <a href='/users/#{@teacher.id}/files'>file index</a>
             <a href='/users/#{@teacher.id}/files/789/preview'>file</a>
@@ -409,7 +396,6 @@ class Tester
 
   describe ".api_bulk_load_user_content_attachments" do
     it "returns a hash of assignment_id => assignment" do
-      course_with_teacher_logged_in(:active_all => true)
       a1, a2, a3 = attachment_model, attachment_model, attachment_model
       html1, html2 = <<-HTML1, <<-HTML2
         <a href="/courses/#{@course.id}/files/#{a1.id}/download">uh...</a>

spec/apis/v1/account_authorization_configs_api_spec.rb

@@ -19,7 +19,7 @@
 require File.expand_path(File.dirname(__FILE__) + '/../api_spec_helper')
 
 describe "AccountAuthorizationConfigs API", type: :request do
-  before do
+  before :once do
     @account = account_model(:name => 'root')
     user_with_pseudonym(:active_all => true, :account => @account)
     @account.account_users.create!(user: @user)
@@ -366,7 +366,7 @@ def call_destroy(id, status = 200)
   end
 
   context "discovery url" do
-    append_before do
+    before :once do
       @account.auth_discovery_url = "http://example.com/auth"
       @account.save!
     end

spec/apis/v1/account_authorization_configs_deprecated_api_spec.rb

@@ -20,7 +20,7 @@
 require File.expand_path(File.dirname(__FILE__) + '/../api_spec_helper')
 
 describe "AccountAuthorizationConfigs API", type: :request do
-  before do
+  before :once do
     @account = account_model(:name => 'root')
     user_with_pseudonym(:active_all => true, :account => @account)
     @account.account_users.create!(user: @user)

spec/apis/v1/account_reports_api_spec.rb

@@ -19,7 +19,7 @@
 require File.expand_path(File.dirname(__FILE__) + '/../api_spec_helper')
 
 describe 'Account Reports API', type: :request do
-  before do
+  before :once do
     @admin = account_admin_user
     user_with_pseudonym(:user => @admin)
     @report = AccountReport.new