Commit 577f78e
committed
i18nliner bump, fix pagination link issue
refs CNVS-11947
the scoping tweak ensures that translate call with an explicit :scope
(ohai will_paginate) do not have their keys incorrectly scoped to the
current file
version bump also fixes issue w/ 5 built-in ActiveRecord translations not
resolving (e.g. "1 error prohibited this %{model} from being saved"), due
to the unfortunately named `i18n_scope` stomping an existing method with
a slightly different purpose. it doesn't appear that a user would ever
actually see any of these 5 strings in canvas, but ¯\_(ツ)_/¯
test plan:
0. create a bunch of page errors if necessary
1. go to /error_reports
2. confirm the pagination links say stuff like "Next →" instead of
"Next Label"
Change-Id: I9ff182863691fbceda44b105ab9bb94d9321b177
Reviewed-on: https://gerrit.instructure.com/43640
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: Jennifer Stern <jstern@instructure.com>
Reviewed-by: Jennifer Stern <jstern@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>1 parent 628df26 commit 577f78e
4 files changed
Lines changed: 20 additions & 20 deletions
File tree
- Gemfile.d
- config/initializers
- gems/i18n_extraction
- lib/i18n_extraction
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
47 | 47 | | |
48 | 48 | | |
49 | 49 | | |
50 | | - | |
| 50 | + | |
51 | 51 | | |
52 | 52 | | |
53 | 53 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
129 | 129 | | |
130 | 130 | | |
131 | 131 | | |
132 | | - | |
133 | | - | |
| 132 | + | |
| 133 | + | |
134 | 134 | | |
135 | | - | |
| 135 | + | |
136 | 136 | | |
137 | | - | |
| 137 | + | |
138 | 138 | | |
139 | | - | |
| 139 | + | |
140 | 140 | | |
141 | | - | |
| 141 | + | |
142 | 142 | | |
143 | 143 | | |
144 | 144 | | |
145 | | - | |
| 145 | + | |
146 | 146 | | |
147 | 147 | | |
148 | 148 | | |
149 | | - | |
150 | | - | |
| 149 | + | |
| 150 | + | |
151 | 151 | | |
152 | 152 | | |
153 | 153 | | |
154 | 154 | | |
155 | 155 | | |
156 | 156 | | |
157 | 157 | | |
158 | | - | |
159 | | - | |
| 158 | + | |
| 159 | + | |
160 | 160 | | |
161 | 161 | | |
162 | | - | |
163 | | - | |
| 162 | + | |
| 163 | + | |
164 | 164 | | |
165 | 165 | | |
166 | 166 | | |
| |||
188 | 188 | | |
189 | 189 | | |
190 | 190 | | |
191 | | - | |
192 | | - | |
| 191 | + | |
| 192 | + | |
193 | 193 | | |
194 | 194 | | |
195 | 195 | | |
196 | 196 | | |
197 | 197 | | |
198 | | - | |
| 198 | + | |
199 | 199 | | |
200 | 200 | | |
201 | 201 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
20 | | - | |
| 20 | + | |
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
| |||
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
| 6 | + | |
7 | 7 | | |
8 | | - | |
| 8 | + | |
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
0 commit comments